Hi, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 04, 2014 2:37 AM > To: Chen, Jing D > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v2 2/6] igb: change for VMDQ arguments expansion > > 2014-10-16 18:07, Chen Jing D: > > --- a/lib/librte_pmd_e1000/igb_ethdev.c > > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > > @@ -1286,18 +1286,21 @@ eth_igb_infos_get(struct rte_eth_dev *dev, > > dev_info->max_rx_queues = 16; > > dev_info->max_tx_queues = 16; > > dev_info->max_vmdq_pools = ETH_8_POOLS; > > + dev_info->vmdq_queue_num = 16; > > break; > > > > case e1000_82580: > > dev_info->max_rx_queues = 8; > > dev_info->max_tx_queues = 8; > > dev_info->max_vmdq_pools = ETH_8_POOLS; > > + dev_info->vmdq_queue_num = 8; > > break; > > > > case e1000_i350: > > dev_info->max_rx_queues = 8; > > dev_info->max_tx_queues = 8; > > dev_info->max_vmdq_pools = ETH_8_POOLS; > > + dev_info->vmdq_queue_num = 8; > > break; > > Why not simply set it only once? > dev_info->vmdq_queue_num = dev_info->max_rx_queues;
There are some other NIC types in this 'switch'. Vmdq_queue_num is set in case max_vmdq_pools is not 0. > > -- > Thomas
