gt;> b. Operator Wrap
>>>>>>>> c. One Statement Per Line
>>>>>>>> d. Multiple Variable Declarations
>>>>>>>>
>>>>>>>>
>>>>>>>> Step 4: (674 files, 6730 lines (with Step 1, Step
Empty Line Separator
>>>>>>> e. Separator Wrap
>>>>>>> f. Overload Methods Declaration Order
>>>>>>> g. Variable Declaration Usage Distance
>>>>>>> i. One Top Level Class
>>>>>>>
>>
>>>> importance are submitted first and sets the severity to Error. The
>>>>> Javadoc commits last and sets the severity to Warning.
>>>>>
>>>>>
>>>>>> 2022年4月18日 16:09，vin jake 写道：
>>>>>>
>>>>>>
t;>> 1. Add java doc check to CheckStyle and set severity to warning.
>>>>>>
>>>>>> 2. Fix java doc warning gradually
>>>>>>
>>>>>>
>>>>>>> 2022年4月28日 00:39，morrysnow 写道：
>>>>>>>
&g
f
> lines of code affected by all the rules and categorized them by importance.
> >>>>>
> >>>>> The link is here:
> https://github.com/apache/incubator-doris/issues/8985#issuecomment-214162
> <
> https://github.com/apache/incubator-doris/issues/
>>>>> of patch splitting is as follows. Those with low impact and high
>>>>> importance are submitted first and sets the severity to Error. The
>>>>> Javadoc commits last and sets the severity to Warning.
>>>>>
>>>>>
&g
should add for fe.
>>>>>
>>>>> All people who care about format rule can put up your thoughts.
>>>>>
>>>>> We can add it in the issue:
>>>>> https://github.com/apache/incubator-doris/issues/8985
>>>>>
gt;>>> On Thu, Apr 14, 2022 at 5:48 PM morrysnow wrote:
>>>>>
>>>>>> I agree with u.
>>>>>>
>>>>>> For the first point, I want to list rules first, and then change
>>>>>> checkstyle.xml.
>>>>&g
point, original change information in git is not lost, we
>>>>> just need to do blame on the version prior to the ‘code style’ commit and
>>>>> some gui tools could list history of one file. Anyway, it is not very
>>>>> convenience.
>>>
of code change after applying the code style rule,
>>>> we
>>>>> would lose the original changelog via `git blame`.
>>>>>
>>>>> vin jake 于2022年4月14日周四 17:12写道：
>>>>>
>>>>>> I have add it in PR
>>>> http
gt; 2. If the many lines of code change after applying the code style rule,
>>> we
>>>> would lose the original changelog via `git blame`.
>>>>
>>>> vin jake 于2022年4月14日周四 17:12写道：
>>>>
>>>>> I have add it in PR
>&g
道：
>> >
>> >> I have add it in PR
>> https://github.com/apache/incubator-doris/pull/8987
>> >>
>> >> On Thu, Apr 14, 2022 at 4:37 PM morrysnow wrote:
>> >>
>> >>> Hi, devs,
>> >>>
>> >>> Curre
; >>> Hi, devs,
> >>>
> >>> Currently, we only have two rules in checkstyle.xml in fe. These are
> all
> >>> about import. So, the code style in fe is very casual.
> >>> I want to add more rules to checkstyle.xml in fe to Improve code
>
pr 14, 2022 at 4:37 PM morrysnow wrote:
>>
>>> Hi, devs,
>>>
>>> Currently, we only have two rules in checkstyle.xml in fe. These are all
>>> about import. So, the code style in fe is very casual.
>>> I want to add more rules to checkstyle.xml in fe
very good
-- Original --
From: morrysnow https://github.com/apache/incubator-doris/pull/8987
>
> On Thu, Apr 14, 2022 at 4:37 PM morrysnow
gt; On Thu, Apr 14, 2022 at 4:37 PM morrysnow wrote:
>
>> Hi, devs,
>>
>> Currently, we only have two rules in checkstyle.xml in fe. These are all
>> about import. So, the code style in fe is very casual.
>> I want to add more rules to checkstyle.xml in fe to Imp
These are all
> > about import. So, the code style in fe is very casual.
> > I want to add more rules to checkstyle.xml in fe to Improve code
> > readability, and adjust all fe code to satisfy new code style step by
> step.
> > What do you think about it? If this is a good id
;> Currently, we only have two rules in checkstyle.xml in fe. These are all
>> about import. So, the code style in fe is very casual.
>> I want to add more rules to checkstyle.xml in fe to Improve code
>> readability, and adjust all fe code to satisfy new code style step by s
vs,
> >
> > Currently, we only have two rules in checkstyle.xml in fe. These are all
> > about import. So, the code style in fe is very casual.
> > I want to add more rules to checkstyle.xml in fe to Improve code
> > readability, and adjust all fe code to satisfy new cod
add more rules to checkstyle.xml in fe to Improve code
> readability, and adjust all fe code to satisfy new code style step by step.
> What do you think about it? If this is a good idea. I will research which
> rules apply to our code
>
> > Hi, devs,
> >
> > Currently, we only have two rules in checkstyle.xml in fe. These are all
> > about import. So, the code style in fe is very casual.
> > I want to add more rules to checkstyle.xml in fe to Improve code
> > readability, and adjust all fe code to
It is best to check the code style at compile time.
Ling Miao
morrysnow 于2022年4月14日周四 16:37写道：
> Hi, devs,
>
> Currently, we only have two rules in checkstyle.xml in fe. These are all
> about import. So, the code style in fe is very casual.
> I want to add more rules to checksty
Hi, devs,
Currently, we only have two rules in checkstyle.xml in fe. These are all about
import. So, the code style in fe is very casual.
I want to add more rules to checkstyle.xml in fe to Improve code readability,
and adjust all fe code to satisfy new code style step by step.
What do you
23 matches
Mail list logo
