Great! But I think maybe we should list all rules in a some place and checked by every one care about it before we merge it to ensure the new code style is good enough.
> 2022年4月14日 17:09，vin jake <jakevin...@gmail.com> 写道： > > I have add it in PR https://github.com/apache/incubator-doris/pull/8987 > > On Thu, Apr 14, 2022 at 4:37 PM morrysnow <morrys...@126.com> wrote: > >> Hi, devs, >> >> Currently, we only have two rules in checkstyle.xml in fe. These are all >> about import. So, the code style in fe is very casual. >> I want to add more rules to checkstyle.xml in fe to Improve code >> readability, and adjust all fe code to satisfy new code style step by step. >> What do you think about it? If this is a good idea. I will research which >> rules apply to our code and put together a list. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org >> For additional commands, e-mail: dev-h...@doris.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
