great, I will trim it in my PR. checkstyle.xml need more discussion
On Thu, Apr 14, 2022 at 5:48 PM morrysnow <morrys...@126.com> wrote: > I agree with u. > > For the first point, I want to list rules first, and then change > checkstyle.xml. > > For the second point, original change information in git is not lost, we > just need to do blame on the version prior to the ‘code style’ commit and > some gui tools could list history of one file. Anyway, it is not very > convenience. > > > 2022年4月14日 17:35，Shuo Wang <wangshuo...@gmail.com> 写道： > > > > In general, I believe that we should do some work to make the code clean > > and readable. > > > > My concern is: > > 1. We should have an agreement on the code style specification in the > > community at first. > > 2. If the many lines of code change after applying the code style rule, > we > > would lose the original changelog via `git blame`. > > > > vin jake <jakevin...@gmail.com> 于2022年4月14日周四 17:12写道： > > > >> I have add it in PR https://github.com/apache/incubator-doris/pull/8987 > >> > >> On Thu, Apr 14, 2022 at 4:37 PM morrysnow <morrys...@126.com> wrote: > >> > >>> Hi, devs, > >>> > >>> Currently, we only have two rules in checkstyle.xml in fe. These are > all > >>> about import. So, the code style in fe is very casual. > >>> I want to add more rules to checkstyle.xml in fe to Improve code > >>> readability, and adjust all fe code to satisfy new code style step by > >> step. > >>> What do you think about it? If this is a good idea. I will research > which > >>> rules apply to our code and put together a list. > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > >>> For additional commands, e-mail: dev-h...@doris.apache.org > >>> > >>> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > For additional commands, e-mail: dev-h...@doris.apache.org > >
