Re: Add more rules to checkstyle.xml in fe

[41108453]

very good





------------------ Original ------------------
From: morrysnow <morrys...@126.com&gt;
Date: Thu,Apr 14,2022 5:39 PM
To: dev@doris.apache.org <dev@doris.apache.org&gt;
Subject: Re: Add more rules to checkstyle.xml in fe



Great! But I think maybe we should list all rules in a some place and checked 
by every one care about it before we merge it to ensure the new code style is 
good enough.

&gt; 2022年4月14日 17:09，vin jake <jakevin...@gmail.com&gt; 写道：
&gt; 
&gt; I have add it in PR https://github.com/apache/incubator-doris/pull/8987
&gt; 
&gt; On Thu, Apr 14, 2022 at 4:37 PM morrysnow <morrys...@126.com&gt; wrote:
&gt; 
&gt;&gt; Hi, devs,
&gt;&gt; 
&gt;&gt; Currently, we only have two rules in checkstyle.xml in fe. These are 
all
&gt;&gt; about import. So, the code style in fe is very casual.
&gt;&gt; I want to add more rules to checkstyle.xml in fe to Improve code
&gt;&gt; readability, and adjust all fe code to satisfy new code style step by 
step.
&gt;&gt; What do you think about it? If this is a good idea. I will research 
which
&gt;&gt; rules apply to our code and put together a list.
&gt;&gt; 
&gt;&gt; ---------------------------------------------------------------------
&gt;&gt; To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
&gt;&gt; For additional commands, e-mail: dev-h...@doris.apache.org
&gt;&gt; 
&gt;&gt; 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org