[VOTE] Release Imaging 1.0 based on RC2

2012-07-23 Thread Damjan Jovanovic
aging-1.0-RC2/site/rat-report.html Votes, please. This vote will close in 72 hours, Friday 27 July 2012 at 02:00 GMT. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you! Damjan Jova

Re: [VOTE] Release Imaging 1.0 based on RC2

2012-07-23 Thread Damjan Jovanovic
On Tue, Jul 24, 2012 at 5:47 AM, Gary Gregory wrote: > On Jul 23, 2012, at 21:19, Damjan Jovanovic wrote: > >> It's been 3 years since Imaging 0.97 was released, >> and many bugs have been fixed and many features added, >> so I would like to release a long overdue I

Re: [DISCUSS] Release Imaging 1.0 based on RC2

2012-07-24 Thread Damjan Jovanovic
On Tue, Jul 24, 2012 at 5:44 PM, Matt Benson wrote: > On Tue, Jul 24, 2012 at 1:31 AM, Damjan Jovanovic > wrote: >> On Tue, Jul 24, 2012 at 5:47 AM, Gary Gregory wrote: >>> On Jul 23, 2012, at 21:19, Damjan Jovanovic wrote: >>> >>>> It's been 3

Re: [VOTE] Release Imaging 1.0 based on RC2

2012-07-27 Thread Damjan Jovanovic
On Thu, Jul 26, 2012 at 2:00 PM, sebb wrote: > On 24 July 2012 02:18, Damjan Jovanovic wrote: >> It's been 3 years since Imaging 0.97 was released, >> and many bugs have been fixed and many features added, >> so I would like to release a long overdue Imaging 1.0.

Re: My vote for release

2012-08-02 Thread Damjan Jovanovic
On Wed, Aug 1, 2012 at 7:00 PM, Gary Lucas wrote: > > Damjan, > > I just saw that you were soliciting votes for release. I think you've done > an outstanding job and I'm all for it. I would vote twice if I could :-) > > I saw that some of the folks on the Apache page were complaining about so

Re: UTF8 filename issue with TarOutputStream

2012-09-02 Thread Damjan Jovanovic
The test on http://jira.codehaus.org/browse/MASSEMBLY-515 Succeeds with ?'s instead of non-ASCII characters on commons-compress-1.0 Succeeds with the correct characters on commons-compress-1.4.1 Why is there 2 projects? Why don't Maven and Ant use commons-compress? Damjan On Sun, Sep 2, 2012 at

[VOTE] Release Imaging 1.0 from RC4

2012-09-24 Thread Damjan Jovanovic
should fix... [ ] -1 I oppose this release because... Thank you! Damjan Jovanovic - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Binary file manipulation tool?

2012-09-28 Thread Damjan Jovanovic
Hi You wouldn't believe it, but one of the most invaluable testing tools for commons-imaging I've discovered has been an x86 assembler :-). Why? Because images are binary files which often use internal offsets to portions of the image. An assembler lets you easily calculate and insert offsets at

Re: [imaging] bz2 archive format - can it be dropped?

2012-09-28 Thread Damjan Jovanovic
+1 to getting rid of it then (binding) On Fri, Sep 28, 2012 at 10:44 PM, sebb wrote: > The assembly descriptors are currently set up to create bz2 archives > in addition to the standard tar.gz and zip ones. > > Is the bz2 format really needed? > It's larger than the tar.gz, at least for sanselan.

Re: [Sanselan][Imaging] Snapshot release.

2012-12-15 Thread Damjan Jovanovic
Sorry about the release situation, the latest nightly build is here: https://repository.apache.org/content/groups/snapshots/org/apache/commons/commons-imaging/1.0-SNAPSHOT/ On Sat, Dec 15, 2012 at 12:33 PM, Jan-Paul Bultmann wrote: > Hey, > Is there a chance for a SNAPSHOT release of commons-im

[all] logging practices in Commons components?

2013-02-04 Thread Damjan Jovanovic
Hi I see few Commons components do any logging, and net, io and csv don't even have any dependencies. Is this a recommended practice? Imaging prints to System.out (!!) instead of logging, and I am wondering if I should add slf4j or log4j2 instead? Regards Damjan

Re: [compress] (Internal)LZWInputStream

2015-02-01 Thread Damjan Jovanovic
Hi I have a patch waiting to be committed to commons-imaging which uses the LZW stuff in commons-compress (brief mention of it by me on IMAGING-126), so it could break with these changes. My hope was to wait for the next release of compress before committing, so I could use that version of compres

Re: [VOTE] Move COMPRESS to git

2015-08-23 Thread Damjan Jovanovic
+1 On Sat, Aug 22, 2015 at 9:29 PM, Stefan Bodewig wrote: > Hi all > > more thann half a year ago I promised to call for a vote for migrating > to git as soon as 1.10 has been released. Well that took longer than > expected :-) > > Anyway, here is the vote: > > +1 Move to git > -1 Stick with svn

[COMPRESS] generalize RandomAccessFile in ZipFile and SevenZFile

2015-09-30 Thread Damjan Jovanovic
Hi (At least) our ZipFile and SevenZFile use RandomAccessFile to read an actual file, meaning they cannot operate on file contents in an array, java.nio channels and buffers, or anything other than an actual file, even if it is randomly accessible. RandomAccessFile also cannot benefit from memory-

Re: [math] [POLL] new TLP name

2016-02-01 Thread Damjan Jovanovic
Apache Math On Mon, Feb 1, 2016 at 7:06 PM, Phil Steitz wrote: > Please select your top choice among the following suggested names > for the new [math]-based TLP. All are welcome and encouraged to > respond. This POLL will be open for 72 hours, at which time two > tallies will be presented: o

Re: Writing 16 Bits Per Sample To Tiff File

2018-06-05 Thread Damjan Jovanovic
You can make a BufferedImage with TYPE_USHORT_GRAY for 16 bits per sample. Damjan On Tue, Jun 5, 2018 at 11:15 AM Juergen Stumpe wrote: > Hello, > > I need to write grayscale pixels with 16 bits per sample into a Tiff file. > > In the provided Apache examples the Imaging.writeImage() method i

Re: svn commit: r1781785 - in /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/pcx: PcxConstants.java PcxWriter.java

2017-02-05 Thread Damjan Jovanovic
Thank you. I have tons of changes I want to make, many of them large and affecting the API. If we have to make a release soon, maybe a 0.98 would be better? Regards Damjan On Sun, Feb 5, 2017 at 7:09 PM, Benedikt Ritter wrote: > Hi Damjan, > > It’s nice to see some activity in IMAGING again. D

Re: [IMAGING] Why don't we just release it?

2017-05-18 Thread Damjan Jovanovic
Imaging is in quite a sad state compared to javax.imageio, with very limited JPEG support that is hard to improve without major research, and doesn't add that much value. People seem to mostly use it for extracting image metadata. I would like to see most of the following in 1.0: * Proper support

Re: [VOTE][LAZY] Move commons-imaging to git

2017-05-19 Thread Damjan Jovanovic
+1 On Thu, May 18, 2017 at 7:22 PM, Rob Tompkins wrote: > Hello all, > > I would like to propose that we move commons-imaging to git in hopes of > doing that before the potential of releasing a 1.0. I figure that it would > be an easier migration with only a trunk to manage in getting it over th

Re: [sanselan]:1.0 Release

2012-02-03 Thread Damjan Jovanovic
On Fri, Feb 3, 2012 at 4:10 PM, Shashank Gupta wrote: > Hi, > We have been using sanselan incubator 0.97 release which has performance > issues on .tif format. I hope that the next 1.0 release version contains > fixes around performance. When this big-bang release is scheduled? > > Also I checke

Maven bugs when building Sanselan

2012-02-29 Thread Damjan Jovanovic
Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that "mvn assembly:assembly" failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/brow

Re: Maven bugs when building Sanselan

2012-02-29 Thread Damjan Jovanovic
On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg wrote: > On 2012-02-29 19:00, Damjan Jovanovic wrote: >> Hi >> >> As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am >> having showstopper problems with Maven. >> >> The first problem, now

Re: Maven bugs when building Sanselan

2012-03-01 Thread Damjan Jovanovic
On Thu, Mar 1, 2012 at 9:25 PM, Dennis Lundberg wrote: > On 2012-03-01 06:23, Damjan Jovanovic wrote: >> On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg wrote: >>> On 2012-02-29 19:00, Damjan Jovanovic wrote: >>>> Hi >>>> >>>> As we near t

Re: Maven bugs when building Sanselan

2012-03-01 Thread Damjan Jovanovic
On Thu, Mar 1, 2012 at 11:37 PM, Dennis Lundberg wrote: > On 2012-02-29 19:00, Damjan Jovanovic wrote: >> Hi >> >> As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am >> having showstopper problems with Maven. >> >> The first problem, now

Re: [VOTE] Promote [csv] to Commons proper

2012-03-06 Thread Damjan Jovanovic
On Tue, Mar 6, 2012 at 7:42 PM, Emmanuel Bourg wrote: > Commons CSV is approaching a releasable state. Considering the general > interest in this component I think it's time to promote it to Commons > proper. > > There are a few points I'd like to address before a release: > - Handle CSV headers,

Re: [Math] maven: Problem with "clirr"

2012-04-25 Thread Damjan Jovanovic
On Tue, Apr 24, 2012 at 11:19 PM, Gilles Sadowski wrote: > Hi. > > Clirr now fails the build on error: > ---CUT--- > [ERROR] Unable to find information in class > org.apache.commons.math3.linear.SymmLQ referring back to nested class > org.apache.commons.math3.linear.SymmLQ$SymmLQEvent > [ERROR]

Re: [sanselan] EXIF_TAG_MODIFY_DATE removed from new imaging package?

2012-04-25 Thread Damjan Jovanovic
On Wed, Apr 25, 2012 at 10:30 PM, Gary Lucas wrote: > I'm taking a stab at transitioning from Sanselan to the new Apache Imaging.   > One thing I've noticed is that one of the EXIF tags my existing software uses > seems to have been removed from imaging: > >  public static final TagInfo EXIF_TAG

Re: [sanselan] EXIF_TAG_MODIFY_DATE removed from new imaging package?

2012-04-26 Thread Damjan Jovanovic
On Thu, Apr 26, 2012 at 2:16 PM, Gary Lucas wrote: > > Since we're on the subject, another question.  In encoding data, I was > constructing field types and coding the information.  But it looks like > you've got some static declarations for doing the same thing.  Could you > verify that the fo

Re: [sanselan] EXIF_TAG_MODIFY_DATE removed from new imaging package?

2012-04-26 Thread Damjan Jovanovic
nswered my > question.  So thanks. > > > > g. > > > > -Original Message- > From: Damjan Jovanovic [mailto:damjan@gmail.com] > Sent: Thursday, April 26, 2012 8:26 AM > To: Commons Developers List > Subject: Re: [sanselan] EXIF_TAG_MODIFY_DATE removed from ne

[imaging][csv][configuration][net] "mvn -Prc install" doesn't generate zip/tar.gz/tar.bz2 files?

2012-06-03 Thread Damjan Jovanovic
Hi I am trying to make an RC release of Commons Imaging, and according to http://commons.apache.org/releases/prepare.html the command which is meant to generate the release artifacts is: mvn -Prc -DcreateChecksum=true install However this only generates .jar/javadoc.jar/sources.jar files, not the

Re: [imaging][csv][configuration][net] "mvn -Prc install" doesn't generate zip/tar.gz/tar.bz2 files?

2012-06-04 Thread Damjan Jovanovic
On Sun, Jun 3, 2012 at 7:07 PM, Oliver Heger wrote: > Am 03.06.2012 15:56, schrieb Gary Gregory: > >> I use http://wiki.apache.org/commons/UsingNexus >> >> Gary >> >> On Jun 3, 2012, at 4:25, Damjan Jovanovic  wrote: >> >>> Hi >>> &

Re: [IMAGING]/[SANSELAN] JIRA error

2012-06-27 Thread Damjan Jovanovic
On Wed, Jun 27, 2012 at 1:50 AM, sebb wrote: > On 26 June 2012 22:50, sebb wrote: >> Some new SANSELAN JIRAs have just been raised, however the JIRA was >> renamed to IMAGING. >> >> Looks like something is wrong with JIRA; I'll raise an Infra issue. > > https://issues.apache.org/jira/browse/INFRA

Re: svn commit: r1307494 - in /commons/proper/sanselan/trunk/src/test/data/images/jpg/2: 2008-07-27+-+Photo+216+-+WE+a+l'etang+de+Blodelsheim.jpg 2008-07-27+-+Photo+216+-+WE+à+l'étang+de+Blodelsheim.j

2012-06-29 Thread Damjan Jovanovic
oto+216+-+WE+à+l'étang+de+Blodelsheim.jpg > Removed: >     > commons/proper/sanselan/trunk/src/test/data/images/jpg/2/2008-07-27+-+Photo+216+-+WE+à+l'étang+de+Blodelsheim.jpg > Which CI systems don't work with Unicode filenames? They should also be fixed. Damjan Jovan

Re: [IMAGING] TagInfo and distinction between TagName and FieldName

2012-07-02 Thread Damjan Jovanovic
On Mon, Jul 2, 2012 at 11:33 PM, Farrukh Najmi wrote: > > Hi Guys, > > I am new to the project so forgive me if the answer is obvious... > > I am working with latest svn bits and the > org.apache.commons.imaging.formats.tiff.taginfos.TagInfo class seems to only > support the TagName column of Tabl

Re: svn commit: r1356580 - in /commons/proper/imaging/trunk: pom.xml src/changes/ src/changes/changes.xml src/changes/release-notes.vm

2012-07-03 Thread Damjan Jovanovic
On Tue, Jul 3, 2012 at 4:54 PM, sebb wrote: > On 3 July 2012 07:45, wrote: >> Author: damjan >> Date: Tue Jul 3 06:45:40 2012 >> New Revision: 1356580 >> >> URL: http://svn.apache.org/viewvc?rev=1356580&view=rev >> Log: >> Add a changelog for the maven-changes-plugin >> and populate it with all

Re: [IMAGING] TagInfo and distinction between TagName and FieldName

2012-07-03 Thread Damjan Jovanovic
On Tue, Jul 3, 2012 at 3:48 PM, Farrukh Najmi wrote: > On 07/02/2012 11:22 PM, Damjan Jovanovic wrote: >> >> On Mon, Jul 2, 2012 at 11:33 PM, Farrukh Najmi >> wrote: >>> >>> Hi Guys, >>> >>> I am new to the project so forgive me if the

Re: [IMAGING] TagInfo and distinction between TagName and FieldName

2012-07-03 Thread Damjan Jovanovic
On Tue, Jul 3, 2012 at 9:03 PM, Farrukh Najmi wrote: > On 07/03/2012 01:56 PM, Damjan Jovanovic wrote: >> >> On Tue, Jul 3, 2012 at 3:48 PM, Farrukh Najmi >> wrote: >>> >>> On 07/02/2012 11:22 PM, Damjan Jovanovic wrote: >>>> >>>

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-03 Thread Damjan Jovanovic
I've also considered the metadata interfaces we use, and I am not sure the current approaches are any good. Most metadata formats are designed in a way specific to that format, eg. some have arbitrary levels of nesting, others have a flat structure, etc. But most are designed to be stored in any i

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-03 Thread Damjan Jovanovic
anges for the 1.0 release so consumers of the project do not get exposed > to a big API change? > > If we can do the proposed change without a long delay then I suggest we do > it for 1.0. If it means a long delay then I suggest we defer to 2.0. > > Thoughts? > > > >

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-05 Thread Damjan Jovanovic
; >>> >>> Hi Damjan, >>> >>> Confirming that your recent fix for supporting Exif FieldName looks good >>> great. Thank you! >>> >>> When do you think you may be able to commit the changes to support the >>> following metadata fo

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-05 Thread Damjan Jovanovic
the API changes are not >>> backward compatible and are in fact major). Or is it better to do these >>> changes for the 1.0 release so consumers of the project do not get >>> exposed >>> to a big API change? >>> >>> If we can do the proposed cha

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-05 Thread Damjan Jovanovic
that your recent fix for supporting Exif FieldName looks good >> great. Thank you! >> >> When do you think you may be able to commit the changes to support the >> following metadata format-specific methods so I can provide feedback: >> >> Imaging.getExifMetadata() >

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-05 Thread Damjan Jovanovic
gt;> The change I proposed for IPTC is contingent upon identifying what IPTC >> spec we are using. I am surprised that the IPTC IIM spec which is more >> recent makes no reference to the IPTC Core spec. I think we need to >> determine the correct spec before looking at my propose

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-06 Thread Damjan Jovanovic
Hi Farrukh Your patch is just an empty file. Regards Damjan On Fri, Jul 6, 2012 at 9:23 PM, Farrukh Najmi wrote: > Hi Damjan, > > Attached is the patch for implementing the proposed change outlined in > bullets below. > Please review and then commit if satisfied or discuss further. Thanks. > >

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-08 Thread Damjan Jovanovic
ttp://www.iptc.org/std/IIM/4.1/specification/IIMV4.1.pdf page 24 onwards. The names in your patch differ from that list. ? On Sat, Jul 7, 2012 at 3:55 PM, Farrukh Najmi wrote: > > Oops. Here is the correct file this time. > > > On 07/07/2012 01:39 AM, Damjan Jovanovic wrote: >&

Re: [IMAGING] Getting EXIF and IPTC metadata using metadata and image format neutral code

2012-07-10 Thread Damjan Jovanovic
he patch. I think we should change >> IptcTypes.name field to IptcTypes.propertyId field and perhaps later add a >> name field that aligns with the Name field values from the spec. BTW, I >> would be happy to have a skype (skype id: farrukh_najmi) call to discuss >> this

[sanselan] Multi-image files and API changes

2010-11-17 Thread Damjan Jovanovic
Hi I've noticed a number of problems with Sanselan's API: 1. There is a way to read files with multiple images (Sanselan.getAllBufferedImages()) but there is no way to write files with multiple images. This limits the usability of all multi-image file formats. 2. There needs to be a way to config

Sanselan: commit access?

2011-02-23 Thread Damjan Jovanovic
Hi My large patch to Sanselan (https://issues.apache.org/jira/browse/SANSELAN-49) has been sitting in Jira for 6 weeks with no comment. With it, > 50% of all image formats in Sanselan will have been written by me, and I've been practically the only contributor of late, so can I please have commit

Re: [Sanselan] release plan?

2011-12-09 Thread Damjan Jovanovic
Hi Yes, it's time for a release. All tests now pass, and most of the serious issues are now fixed. However I did promise a few people their patches would get attention, so first I would like to review and apply the TIFF performance enhancement patches by Gary Lucas (SANSELAN-56 to 58), and the TI

[sanselan] how to build a release

2011-12-15 Thread Damjan Jovanovic
Hi I promised to start the Sanselan release process early this week, but I've been having problem after problem: 1. The instructions on http://commons.apache.org/releases/prepare.html say that you run a variation of "mvn install" to build the release... but this only generates the .jar files, not

Re: [sanselan] how to build a release

2011-12-15 Thread Damjan Jovanovic
On Thu, Dec 15, 2011 at 7:33 PM, sebb wrote: > On 15 December 2011 17:10, sebb wrote: > > On 15 December 2011 16:58, Damjan Jovanovic > wrote: > >> Hi > >> > >> I promised to start the Sanselan release process early this week, but > I've > >

Re: [sanselan] how to build a release

2011-12-15 Thread Damjan Jovanovic
. > > HTH, have a nice day! > -Simo > > [1] http://wiki.apache.org/commons/CreatingReleases > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > > On Thu, D

Re: [sanselan] how to build a release

2011-12-16 Thread Damjan Jovanovic
On Sat, Dec 17, 2011 at 1:35 AM, Gary Gregory wrote: > On Fri, Dec 16, 2011 at 5:54 PM, sebb wrote: > > > On 16 December 2011 20:49, Gary Gregory wrote: > > > On Fri, Dec 16, 2011 at 1:43 PM, sebb wrote: > > > > > >> On 16 December 2011 17:27, Simone Tripodi > > >> wrote: > > >> > AH yes, that

Re: [sanselan] Comments on next release

2011-12-19 Thread Damjan Jovanovic
On Mon, Dec 19, 2011 at 9:33 PM, Gary Lucas wrote: > I see there's some discussion about the next release of Sanselan between > Damjan Jovanovic, Gary Gregory (I'm the other Gary) and some of the Apache > community leaders. My name was even mentioned... so I thought I'd

Re: [sanselan] JIRA administration

2011-12-20 Thread Damjan Jovanovic
Hi When I had similar permission issues with JIRA, I fixed it by contacting INFRA. Damjan On Tue, Dec 20, 2011 at 11:29 AM, Emmanuel Bourg wrote: > Hi, > > I wanted to create new versions for Sanselan in JIRA but it seems I do not > have access to the administration panel: > > https://issues.a

Re: [sanselan] ImageReadException and ImageWriteException

2011-12-21 Thread Damjan Jovanovic
On Wed, Dec 21, 2011 at 10:27 AM, Jörg Schaible wrote: > Gary Gregory wrote: > > > WRT ImageReadException and ImageWriteException > > > > Would IOException be better for this? > > javax.imageio.IIOException ? > > - Jörg > I'd rather require as little as possible of the javax.* packages, to make

Re: [ALL][VOTE] Rename Commons Sanselan to Commons Image

2011-12-22 Thread Damjan Jovanovic
On Thu, Dec 22, 2011 at 1:54 PM, Christian Grobmeier wrote: > On Thu, Dec 22, 2011 at 12:32 PM, Mark Thomas wrote: > > On 19/12/2011 14:54, Gary Gregory wrote: > >> This is a VOTE to [ALL] to rename Commons Sanselan to Commons Image. > >> > >> The drive is to have a meaningful obvious name like [

[compress] Ok to commit 7zip support patch?

2013-05-06 Thread Damjan Jovanovic
Hi I've been hacking on a patch that adds support for reading 7zip archives. Can I go ahead and commit it, or would you like to review it first? Regards Damjan

Re: [compress] Ok to commit 7zip support patch?

2013-05-07 Thread Damjan Jovanovic
On Tue, May 7, 2013 at 6:09 AM, Stefan Bodewig wrote: > On 2013-05-06, Damjan Jovanovic wrote: > >> I've been hacking on a patch that adds support for reading 7zip archives. > > COMPRESS-54 is the most popular issue so you'd make quite a few people > happy. I

Re: [compress] 7zip

2013-05-12 Thread Damjan Jovanovic
On Sun, May 12, 2013 at 12:34 PM, Stefan Bodewig wrote: > Hi > > I've rushed through Damjan's addition of (readonly) 7z and really like > it. It might need some more docs but it is a great start. There are > quite a few FIXMEs that we may want to address in one way or another. Thank you :). >

Re: [compress] 7zip

2013-05-12 Thread Damjan Jovanovic
On Sun, May 12, 2013 at 4:27 PM, Damjan Jovanovic wrote: > On Sun, May 12, 2013 at 12:34 PM, Stefan Bodewig wrote: >> As for LZMA compression, the required code in XZ for Java's lzma >> subpackage doesn't lend itself to streaming support but it may be >> possible

Re: svn commit: r1481509 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz: BoundedRandomAccessFileInputStream.java Coders.java SevenZFile.java

2013-05-13 Thread Damjan Jovanovic
On Mon, May 13, 2013 at 7:14 PM, sebb wrote: > On 12 May 2013 11:12, wrote: >> Author: damjan >> Date: Sun May 12 10:12:16 2013 >> New Revision: 1481509 >> >> URL: http://svn.apache.org/r1481509 >> Log: >> Add support for BZIP2 decompression and AES-256 + SHA-256 decryption >> to the 7z archive

Re: svn commit: r1482203 - /commons/proper/compress/trunk/pom.xml

2013-05-14 Thread Damjan Jovanovic
On Tue, May 14, 2013 at 1:00 PM, sebb wrote: > On 14 May 2013 06:01, wrote: >> Author: damjan >> Date: Tue May 14 05:01:35 2013 >> New Revision: 1482203 >> >> URL: http://svn.apache.org/r1482203 >> Log: >> Verify conformance to the Java 1.5 API using the animal-sniffer plugin. > > -1 > > Does no

Re: [COMPRESS] SevenZFile - fix debug so boxing is eliminated?

2013-05-22 Thread Damjan Jovanovic
On Tue, May 14, 2013 at 2:36 AM, sebb wrote: > The private debug method requires an array of Objects to be passed to > System.out.format. > > Any primitive parameters will be autoboxed. > > However, the boxing will be performed regardless of whether DEBUG is > true or not. > This is a bit wasteful

Re: [compress] Detecting LZMA standalone files

2013-06-10 Thread Damjan Jovanovic
On Mon, Jun 10, 2013 at 6:25 AM, Stefan Bodewig wrote: > Hi, > > when I added support for decompressing .lzma files I left out matches() > and you can only get an LZMACompressorInputStream from > CompressorStreamFactory if you use the version that explicitly specifies > the format. > > The reason

Re: [imaging] release 1.0 state?

2013-08-23 Thread Damjan Jovanovic
There's a few last patches I want to add while we can still break the API, but I am away this week, and only fully available for anything the week after next. Damjan On Fri, Aug 23, 2013 at 8:02 AM, Andreas Lehmkuehler wrote: > Hi, > > Am 22.08.2013 22:01, schrieb Gary Gregory: > > Hi all (Dam

Re: [compress] Do we want 7z Archive*Stream-like classes

2013-10-01 Thread Damjan Jovanovic
On Tue, Oct 1, 2013 at 6:09 AM, Stefan Bodewig wrote: > On 2013-09-30, Benedikt Ritter wrote: > >> 2013/9/30 Stefan Bodewig > >>> I'm in no way as familiar with the format as Damian is but IMHO it is >>> feasible - but likely pretty memory hungry. Even more so for the >>> writing side. Similar

Re: [VOTE] Move Apache Commons to Git for SCM...

2013-10-10 Thread Damjan Jovanovic
-1 (binding), it's a big change, so let's try Mark's idea of one component first. On Thu, Oct 10, 2013 at 5:06 PM, Mark Thomas wrote: > On 10/10/2013 15:50, James Carman wrote: >> All, >> >> We have had some great discussions about moving our SCM to Git. I >> think it's time to put it to a vot

Re: [CHALLENGE] Move All of Commons to the Dormant

2013-10-18 Thread Damjan Jovanovic
I agree. The only reason [imaging] has been "dormant" for so long is that I am busy making large changes that have taken many months to write, so it's not really that dormant after all. I understand the desire to do something about the current state of Commons, but please don't make things harder

Re: [VOTE] Release Imaging 1.0 from RC4

2013-10-21 Thread Damjan Jovanovic
On Tue, Sep 25, 2012 at 3:22 PM, Gary Gregory wrote: > Hi All, > > I happy to see another RC come along! :) This is large code base so I > appreciate that the reports generate a lot of potential work. I planned to send this email out just over a year ago, shortly after yours, but since we might a

Re: svn commit: r1534322 - in /commons/proper/imaging/trunk/src: changes/changes.xml main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java main/java/org/apache/commons/imaging/formats

2013-10-21 Thread Damjan Jovanovic
On Tue, Oct 22, 2013 at 3:02 AM, sebb wrote: >> + >> +public byte[] getComment() { >> +return comment; > > This is better, but the array can still be modified externally. > > Might make more sense to convert the array to a String and return that > instead - Strings are immutable, but a

[imaging] got anything left to add before release?

2013-10-23 Thread Damjan Jovanovic
Hi I've resolved many Jira issues and the rest can get postponed, so I am pretty happy with the state of Imaging at the moment. Does anyone have anything left to add before I start trying to make the next release candidate? Damjan

Re: [imaging] Closing stream

2013-10-23 Thread Damjan Jovanovic
On Thu, Oct 24, 2013 at 4:34 AM, Bernd Eckenfels wrote: > Am 24.10.2013, 02:16 Uhr, schrieb Gary Gregory : > >> try { >> if (outputStream != null) { >> outputStream.close(); >> } >> } catch (final Exception e) { >>

Re: [imaging] Closing stream

2013-10-24 Thread Damjan Jovanovic
As one of the perpetrators of the problem, I have now fixed it. The reasons I swallowed exceptions were simple: * when multiple resources need to be closed, earlier exceptions in finally cause later close() methods to get skipped and those resources to leak * when an exception is thrown and close()

Re: [imaging] Closing stream

2013-10-24 Thread Damjan Jovanovic
On Thu, Oct 24, 2013 at 11:29 PM, Gary Gregory wrote: > On Thu, Oct 24, 2013 at 4:31 PM, Jörg Schaible wrote: > >> Hi Damjan, >> >> Damjan Jovanovic wrote: >> >> > As one of the perpetrators of the problem, I have now fixed it. The >> > reasons

Re: [imaging] Closing stream

2013-10-25 Thread Damjan Jovanovic
On Fri, Oct 25, 2013 at 9:01 AM, Jörg Schaible wrote: > Hi Damjan, > > Damjan Jovanovic wrote: > >> On Thu, Oct 24, 2013 at 11:29 PM, Gary Gregory >> wrote: >>> On Thu, Oct 24, 2013 at 4:31 PM, Jörg Schaible >>> wrote: >>> >>>> Hi

Re: [imaging] Closing stream

2013-10-25 Thread Damjan Jovanovic
On Fri, Oct 25, 2013 at 12:36 PM, Jörg Schaible wrote: > Hi Damjan, > > Damjan Jovanovic wrote: > > [snip] > > Thanks for explanation. > >> We would be able to adapt that for Java < 1.7 by swallowing the close >> exception instead of calling addSuppressed

Re: [imaging] Closing stream

2013-10-26 Thread Damjan Jovanovic
an On Fri, Oct 25, 2013 at 5:24 PM, Jörg Schaible wrote: > Hi Damjan, > > Damjan Jovanovic wrote: > >> On Fri, Oct 25, 2013 at 12:36 PM, Jörg Schaible >> wrote: >>> Hi Damjan, >>> >>> Damjan Jovanovic wrote: >>> >>> [snip] &g

Re: [imaging] Closing stream

2013-10-30 Thread Damjan Jovanovic
ving Imaging to Java 7 as soon as 1.0 is released. Damjan On Sun, Oct 27, 2013 at 8:32 PM, Gary Gregory wrote: > On Sun, Oct 27, 2013 at 1:51 AM, Damjan Jovanovic >wrote: > > > an > > > > On Fri, Oct 25, 2013 at 5:24 PM, Jörg Schaible > > wrote: >

[VOTE] Release Imaging 1.0 from RC5

2013-11-01 Thread Damjan Jovanovic
from now, on Monday 4 November 2013 at 12:00 GMT. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you! Damjan Jovanovic

Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Damjan Jovanovic
On Fri, Oct 25, 2013 at 1:52 PM, Matt Benson wrote: > On Oct 25, 2013 6:30 AM, "Damjan Jovanovic" wrote: > > > > On Fri, Oct 25, 2013 at 12:36 PM, Jörg Schaible > > wrote: > > > Hi Damjan, > > > > > > Damjan Jovanovic wr

Re: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Damjan Jovanovic
ch is long > > overdue. > > > > I suppose D needs to weigh using ASM or [weaver] vs. adjusting the > current > > code with Java 5. > > > > Gary > > > >> > >> Matt > >> On Nov 3, 2013 2:30 AM, "Damjan Jovanovic" wrote: > &g

Re: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-04 Thread Damjan Jovanovic
> We may pushing the limits of Dajman's patience for a 1.0 which is long > > > overdue. > > > > > > I suppose D needs to weigh using ASM or [weaver] vs. adjusting the > > current > > > code with Java 5. > > > > > > Gary > >

[RESULT] [VOTE] Release Imaging 1.0 from RC5

2013-11-04 Thread Damjan Jovanovic
Vote closed, results were: +1: Thomas Neidhart +0.5: Benedikt Ritter -0: Gary Gregory Vote fails since majority approval needs at least 3 votes of +1 -> aborting release. Damjan On Fri, Nov 1, 2013 at 1:57 PM, Damjan Jovanovic wrote: > Please vote on releasing commons-imaging 1.0 fr

Re: [RESULT] [VOTE] Release Imaging 1.0 from RC5

2013-11-04 Thread Damjan Jovanovic
RC? > > Gary > > > On Mon, Nov 4, 2013 at 1:52 PM, Damjan Jovanovic > wrote: > > > Vote closed, results were: > > > > +1: > > Thomas Neidhart > > > > +0.5: > > Benedikt Ritter > > > > -0: > > Gary Gregory > &g

Re: [VOTE] Release Imaging 1.0 from RC5

2013-11-04 Thread Damjan Jovanovic
On Sun, Nov 3, 2013 at 1:00 AM, Jörg Schaible wrote: > Hi Damjan, > > Damjan Jovanovic wrote: > > > Please vote on releasing commons-imaging 1.0 from RC5. > > > > RC4 and its problems and their fixes were in this thread: > > > http://mail-archives.apac

Re: [VOTE] Release Imaging 1.0 from RC5

2013-11-06 Thread Damjan Jovanovic
filter could hide other bugs in the future. > Tested with: > > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 > 11:22:22-0400) > Maven home: C:\Java\apache-maven-3.1.1\bin\.. > Java version: 1.7.0_45, vendor: Oracle Corporation > Java home: C:\Progr

[sanselan] project dead?

2010-08-31 Thread Damjan Jovanovic
/msg14479.html) If everyone else is busy, can I please join as a committer or something? Thank you Damjan Jovanovic

Re: [sanselan] project dead?

2010-09-01 Thread Damjan Jovanovic
he ASF does not grant > committership on request - the ASF is a community, and like with every > community you need to "grow in it". > > However, welcome and I am looking for your patches :-) > Cheers > Christian > > On Tue, Aug 31, 2010 at 10:25 PM, Damjan Jovanovi

[sanselan] ICO format patch

2010-09-02 Thread Damjan Jovanovic
pport for compressed bitmaps Adds support for the Windows Vista (and later) PNG ICO format Verifies crucial fields in ICO files Adds extensive tests It's the latest patch by date at: https://issues.apache.org/jira/browse/SANSELAN-40 Thank you Damjan

Re: [CRYPTO] Switch from JNI to JNA

2016-04-23 Thread Damjan Jovanovic
There's also BridJ (https://github.com/nativelibs4java/BridJ), which claims to be very fast, supports C++ and COM, and JNAerator can autogenerate code for it from C/C++ headers. Java 9 will also have vastly enhanced access to native code (http://openjdk.java.net/projects/panama/). Damjan On Sat,

Back to contributing to Commons Imaging

2016-09-03 Thread Damjan Jovanovic
Hi I am back to contributing to Commons Imaging. Will start with some cleanups, like try-with-resources instead of IoUtils.closeQuietly(). Java and Maven are a heaven send after working in C++ and make with Apache OpenOffice. Regards Damjan

[VOTE] Release Imaging 1.0 from RC7

2013-11-24 Thread Damjan Jovanovic
1 I oppose this release because... Thank you! Damjan Jovanovic - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-25 Thread Damjan Jovanovic
es, there's plenty more. But users are begging for a 1.0 release, not higher API standards. Thank you again for the review - it will all get fixed or replaced at some stage. Finally, please remember: 1.0 releases are usually the ones that never work :-). > Emmanuel Bourg Damjan > Le 24/11/20

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Damjan Jovanovic
On Tue, Nov 26, 2013 at 3:47 PM, Gary Gregory wrote: > On Tue, Nov 26, 2013 at 4:05 AM, Emmanuel Bourg wrote: > >> Hi Damjan, >> >> Le 26/11/2013 06:31, Damjan Jovanovic a écrit : >> >> > Firstly, we discussed several options before for the 1.0 release, and

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-26 Thread Damjan Jovanovic
On Tue, Nov 26, 2013 at 4:32 PM, Gary Gregory wrote: > On Tue, Nov 26, 2013 at 12:31 AM, Damjan Jovanovic wrote: > >> On Mon, Nov 25, 2013 at 1:50 PM, Emmanuel Bourg wrote: >> > Hi Damjan, >> >> Hi Emmanuel >> >> > I reviewed the API, here are my

Re: svn commit: r1545710 - in /commons/proper/imaging/trunk: pmd-ruleset.xml pom.xml src/conf/pmd-ruleset.xml src/main/java/org/apache/commons/imaging/ColorTools.java

2013-11-26 Thread Damjan Jovanovic
On Tue, Nov 26, 2013 at 6:18 PM, wrote: > Author: ebourg > Date: Tue Nov 26 16:18:58 2013 > New Revision: 1545710 > > URL: http://svn.apache.org/r1545710 > Log: > Adjust PMD rules > > Copied: commons/proper/imaging/trunk/src/conf/pmd-ruleset.xml (from r1545174, > commons/proper/imaging/trunk/pm

Re: [VOTE] Release Imaging 1.0 from RC7

2013-11-27 Thread Damjan Jovanovic
Vote closed, results were: +1: Damjan Jovanovic No other votes were cast. Vote fails since majority approval needs at least 3 votes of +1 -> aborting release. Damjan On Sun, Nov 24, 2013 at 6:54 PM, Damjan Jovanovic wrote: > Please vote on releasing commons-imaging 1.0 from RC7. &g

Re: svn commit: r1546303 - in /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging: common/ common/bytesource/ common/itu_t4/ common/mylzw/ formats/bmp/pixelparsers/ formats/jpeg/dec

2013-11-27 Thread Damjan Jovanovic
Why? I've heard initializing fields, even to their defaults, is a good practice and makes code clearer. Damjan On Thu, Nov 28, 2013 at 9:43 AM, wrote: > Author: ebourg > Date: Thu Nov 28 07:43:15 2013 > New Revision: 1546303 > > URL: http://svn.apache.org/r1546303 > Log: > Removed field initial

[compress] ZIP unshrinking support

2013-12-06 Thread Damjan Jovanovic
Hi I just committed a patch for decompressing ZIP entries using method 1 ("unshrinking"), but it's only for ZipFile. If someone wants to help patch ZipInputStream, please feel free. It may be worth refactoring decompression in that class, because it will just keep getting worse as more compressio

  1   2   >