On Tue, Nov 26, 2013 at 6:18 PM, <ebo...@apache.org> wrote: > Author: ebourg > Date: Tue Nov 26 16:18:58 2013 > New Revision: 1545710 > > URL: http://svn.apache.org/r1545710 > Log: > Adjust PMD rules >
> Copied: commons/proper/imaging/trunk/src/conf/pmd-ruleset.xml (from r1545174, > commons/proper/imaging/trunk/pmd-ruleset.xml) > URL: > http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/conf/pmd-ruleset.xml?p2=commons/proper/imaging/trunk/src/conf/pmd-ruleset.xml&p1=commons/proper/imaging/trunk/pmd-ruleset.xml&r1=1545174&r2=1545710&rev=1545710&view=diff > ============================================================================== > --- commons/proper/imaging/trunk/pmd-ruleset.xml (original) > +++ commons/proper/imaging/trunk/src/conf/pmd-ruleset.xml Tue Nov 26 16:18:58 > 2013 > @@ -65,6 +65,8 @@ > <rule ref="rulesets/java/migrating.xml"/> > <rule ref="rulesets/java/optimizations.xml"> > <exclude name="AvoidInstantiatingObjectsInLoops"/> > + <exclude name="LocalVariableCouldBeFinal"/> > + <exclude name="MethodArgumentCouldBeFinal"/> > <exclude name="RedundantFieldInitializer"/> > <exclude name="PrematureDeclaration"/> > </rule> > Why are we excluding those? Final variables are a good thing. Damjan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
