Re: [vote] Release commons-net 2.0

2008-10-13 Thread Oliver Heger
+1 Oliver Rory Winston schrieb: Hi all you know the drill, so I'll keep it short... Tag: https://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_0_RC_5/ Site: http://people.apache.org/~rwinston/commons-net-2.0/site/ Release notes: http://people.apache.org/~rwinston/commons-net-2.0/RE

Re: [vote] Release commons-net 2.0

2008-10-13 Thread Jörg Schaible
+1 Rory Winston wrote: > Hi all > > you know the drill, so I'll keep it short... > > Tag: > > https://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_0_RC_5/ > > Site: > > http://people.apache.org/~rwinston/commons-net-2.0/site/ > > Release notes: > > http://people.apache.org/~rwinston

Re: [vote] Release commons-net 2.0

2008-10-12 Thread Phil Steitz
Rory Winston wrote: Hi all you know the drill, so I'll keep it short... Tag: https://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_0_RC_5/ Site: http://people.apache.org/~rwinston/commons-net-2.0/site/ Release notes: http://people.apache.org/~rwinston/commons-net-2.0/RELEASE-NOTES.tx

Re: [vote] Release commons-net 2.0

2008-10-12 Thread Luc Maisonobe
Rory Winston a écrit : > Hi all > > you know the drill, so I'll keep it short... > > Tag: > > https://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_0_RC_5/ > > Site: > > http://people.apache.org/~rwinston/commons-net-2.0/site/ > > Release notes: > > http://people.apache.org/~rwinston/c

Re: [vote] Release commons-net 2.0

2008-10-12 Thread James Carman
Again, you should probably create a different directory for each rc. That way, you know exactly what you're voting on. On Sun, Oct 12, 2008 at 4:03 PM, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi all > > you know the drill, so I'll keep it short... > > Tag: > > https://svn.apache.org/viewvc/commo

Re: [vote] Release commons-net 2.0

2008-10-12 Thread Niklas Gustavsson
On Sun, Oct 12, 2008 at 10:03 PM, Rory Winston <[EMAIL PROTECTED]> wrote: > +-0/1 as you think fit, thanks! Looks good to me. +1 /niklas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECT

[vote] Release commons-net 2.0

2008-10-12 Thread Rory Winston
Hi all you know the drill, so I'll keep it short... Tag: https://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_0_RC_5/ Site: http://people.apache.org/~rwinston/commons-net-2.0/site/ Release notes: http://people.apache.org/~rwinston/commons-net-2.0/RELEASE-NOTES.txt Binaries: http://

Re: [vote] Release commons-net 2.0

2008-10-04 Thread sebb
Also, it would help to know what Maven command-line was used to build the release (and on which OS), so it can readily be checked on other systems / OSes. The README file could perhaps be updated with this information - at the moment it only describes how to build the site. On 04/10/2008, sebb <[

Re: [vote] Release commons-net 2.0

2008-10-04 Thread sebb
The source and javadoc jars don't have LICENSE and NOTICE files. The NET_2_0 tag does not agree with the source file archive - the pom files differ. Which pom was actually used to generate the release? On 04/10/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Guys > > I know commons has been dyi

Re: [vote] Release commons-net 2.0

2008-10-04 Thread Rory Winston
James Thats a good idea, I'll do that...I'll recut and retag a new release and send out a new vote thread later on today. I did create a release tag which I had been reusing, but I think in retrospect I should have just created more RC tags. Thanks Rory James Carman wrote: How about sendin

Re: [vote] Release commons-net 2.0

2008-10-04 Thread James Carman
How about sending out a fresh [vote] thread email again? I don't tend to keep stuff around and it's hard to know what we're voting on when new versions of the rc keep getting uploaded. If you're cutting a new release candidate, I'd say you should upload it, but don't overwrite what you put out th

Re: [vote] Release commons-net 2.0

2008-10-04 Thread Rory Winston
Guys I know commons has been dying a slow death due to inactivity, but binding votes (either +-1) would be appreciated. I want to get this out finally... Rory Winston wrote: Ah, yes, you're right -Prc does actually generate them automatically. That explains the discrepancy. I have uplo

Re: [vote] Release commons-net 2.0

2008-10-02 Thread Rory Winston
Ah, yes, you're right -Prc does actually generate them automatically. That explains the discrepancy. I have uploaded the distribution again, based on the build with a -Prc switch. It's exactly the same, just the javadoc/src jar is generated by the parent pom automagically. James Carman w

Re: [vote] Release commons-net 2.0

2008-10-02 Thread James Carman
Does Net's pom not extend the proper parent pom? For Proxy, most of the proper build stuff was taken care of for me by the hard work that others put into the parent pom (thanks to those folks). Did you try using the "rc" profile when cutting your release candidates? On Thu, Oct 2, 2008 at 2:23 A

RE: [vote] Release commons-net 2.0

2008-10-01 Thread Jörg Schaible
[EMAIL PROTECTED] wrote: > On 10/1/08, Rory Winston <[EMAIL PROTECTED]> wrote: >> Thanks for the feedback. I have changed the pom (needed to add some >> plugins) to generate sources and javadoc jars. I have uploaded the >> signed jars to the site. I dont see an issue with the javadocs >> containing

Re: [vote] Release commons-net 2.0

2008-10-01 Thread James Carman
Shouldn't the Parent pom take care of this? On 10/1/08, Rory Winston <[EMAIL PROTECTED]> wrote: > Thanks for the feedback. I have changed the pom (needed to add some > plugins) to generate sources and javadoc jars. I have uploaded the > signed jars to the site. I dont see an issue with the javad

Re: [vote] Release commons-net 2.0

2008-10-01 Thread Rory Winston
Thanks for the feedback. I have changed the pom (needed to add some plugins) to generate sources and javadoc jars. I have uploaded the signed jars to the site. I dont see an issue with the javadocs containing the examples classes (its always been like that). Rory Jörg Schaible wrote: Hi

RE: [vote] Release commons-net 2.0

2008-10-01 Thread Jörg Schaible
Hi Rory, here comes part II, I try to build the jar from the src package with my compiler zoo. Jörg Schaible wrote: > Hi Rory, > > - the clirr report compares 2.0 against 1.4.1 instead of 1.5.0. > - the changes report is missing some information in the release history. > This is not your fault,

Re: [vote] Release commons-net 2.0

2008-10-01 Thread Niklas Gustavsson
On 10/1/08, sebb <[EMAIL PROTECTED]> wrote: > On 30/09/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > > Hmm, I havent explicitly put the pom.xml under > > > > META_INF/maven/commons-net/commons-net > > > > ...I suspect Maven may have done this itself. > > > > But is it correct? > > If not, will

Re: [vote] Release commons-net 2.0

2008-10-01 Thread sebb
On 30/09/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hmm, I havent explicitly put the pom.xml under > > META_INF/maven/commons-net/commons-net > > ...I suspect Maven may have done this itself. > But is it correct? If not, will the incorrect location cause any problems for Maven? If the ent

RE: [vote] Release commons-net 2.0

2008-09-30 Thread Jörg Schaible
Hi Rory, - the clirr report compares 2.0 against 1.4.1 instead of 1.5.0. - the changes report is missing some information in the release history. This is not your fault, but it would be nice anyway to provide complete infos. - the javadoc contains the classes in the example packages. Nothing of

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Niklas Gustavsson
On Wed, Oct 1, 2008 at 1:05 AM, Rory Winston <[EMAIL PROTECTED]> wrote: > Done! Great, +1 on releasing. /niklas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Niklas Gustavsson
On Wed, Oct 1, 2008 at 12:51 AM, Rory Winston <[EMAIL PROTECTED]> wrote: > ...I suspect Maven may have done this itself. You're right. You can disable this behavior with the following configuration: maven-jar-plugin 2.2 false

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Rory Winston
Done! Thanks Rory Niklas Gustavsson wrote: On Mon, Sep 29, 2008 at 11:50 PM, Rory Winston <[EMAIL PROTECTED]> wrote: Yes, sorry, I just realised that I have an older key in my key list which must be the default for signing. I've uploaded it to pgp.mit.edu and I will add it to the appropriate

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Rory Winston
Hmm, I havent explicitly put the pom.xml under META_INF/maven/commons-net/commons-net ...I suspect Maven may have done this itself. sebb wrote: On 28/09/2008, Rory Winston <[EMAIL PROTECTED]> wrote: Hi all After the RC inspection a week or so ago, I am putting up a candidate for relea

Re: [vote] Release commons-net 2.0

2008-09-30 Thread sebb
On 28/09/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi all > > After the RC inspection a week or so ago, I am putting up a candidate for > release. Based on the feedback on the RC, I have made the following changes: > > * Excluded the examples/ classes from the binary jar > * Put LICENSE.tx

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Niklas Gustavsson
On Mon, Sep 29, 2008 at 11:50 PM, Rory Winston <[EMAIL PROTECTED]> wrote: > Yes, sorry, I just realised that I have an older key in my key list which > must be the default for signing. I've uploaded it to pgp.mit.edu and I will > add it to the appropriate KEYS file as well. Now find it at pgp.mit.

Re: [vote] Release commons-net 2.0

2008-09-29 Thread Rory Winston
Yes, sorry, I just realised that I have an older key in my key list which must be the default for signing. I've uploaded it to pgp.mit.edu and I will add it to the appropriate KEYS file as well. Rory Niklas Gustavsson wrote: On Sun, Sep 28, 2008 at 8:21 PM, Rory Winston <[EMAIL PROTECTED]> w

Re: [vote] Release commons-net 2.0

2008-09-29 Thread Niklas Gustavsson
On Sun, Sep 28, 2008 at 8:21 PM, Rory Winston <[EMAIL PROTECTED]> wrote: > * Updated keys, checksums, etc, and added a release notes doc I still can't seem to find the key used for signing the artifacts (B6E5C0E2)., neither in: http://www.apache.org/dist/commons/KEYS nor in: https://svn.apache.or

Re: [vote] Release commons-net 2.0

2008-09-29 Thread Oliver Heger
+1 Artifacts look good, build works fine under JDK 1.6. One nit: I think the release notes should be contained at least in the binary distribution. And they should start with a short paragraph giving an introduction into what the component does. Well, I leave the decision to you and do not ve

[vote] Release commons-net 2.0

2008-09-28 Thread Rory Winston
Hi all After the RC inspection a week or so ago, I am putting up a candidate for release. Based on the feedback on the RC, I have made the following changes: * Excluded the examples/ classes from the binary jar * Put LICENSE.txt and NOTICE.txt in META-INF in the FTP-only jar * Fixed some oddi

Re: [VOTE] Release Commons Net 2.0

2008-04-14 Thread Rory Winston
Thanks Niklas! Cheers Rory On 8 Apr 2008, at 08:35, Niklas Gustavsson wrote: My bad, the branches/NET_2_0 actually gives the following test failures: Tests in error: testInitial(org.apache.commons.net.telnet.TelnetClientTest) testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTes

Re: [VOTE] Release Commons Net 2.0

2008-04-11 Thread Niklas Gustavsson
Hi On Mon, Apr 7, 2008 at 11:06 PM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > From where is this code built? I've tried building from some different > tags and branches, but always get test failures. Things have improved significantly on the 2.0 branch, thanks! Now I'm just getting one fai

Re: [VOTE] Release Commons Net 2.0

2008-04-08 Thread Niklas Gustavsson
On Tue, Apr 8, 2008 at 3:38 PM, sebb <[EMAIL PROTECTED]> wrote: > How many CPUs does the system have? It's a dual core laptop. > I raised JIRA NET-213 to record the bug you reported. Thanks! > Do you see any problem with always using the default platform encoding > when converting the line

Re: [VOTE] Release Commons Net 2.0

2008-04-08 Thread sebb
On 08/04/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Tue, Apr 8, 2008 at 12:11 PM, sebb <[EMAIL PROTECTED]> wrote: > > On 08/04/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > > > My bad, the branches/NET_2_0 actually gives the following test failures: > > > > > > > which J

Re: [VOTE] Release Commons Net 2.0

2008-04-08 Thread Niklas Gustavsson
On Tue, Apr 8, 2008 at 12:11 PM, sebb <[EMAIL PROTECTED]> wrote: > On 08/04/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > > My bad, the branches/NET_2_0 actually gives the following test failures: > > > > which JVM are you using for this? > > I don't see the error in 1.5.0 or 1.6.0 (Sun/

Re: [VOTE] Release Commons Net 2.0

2008-04-08 Thread sebb
On 08/04/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > My bad, the branches/NET_2_0 actually gives the following test failures: > which JVM are you using for this? I don't see the error in 1.5.0 or 1.6.0 (Sun/WinXP). > Tests in error: > testInitial(org.apache.commons.net.telnet.TelnetC

Re: [VOTE] Release Commons Net 2.0

2008-04-08 Thread Niklas Gustavsson
My bad, the branches/NET_2_0 actually gives the following test failures: Tests in error: testInitial(org.apache.commons.net.telnet.TelnetClientTest) testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTest) testOptionRenegotiation(org.apache.commons.net.telnet.TelnetClientTest)

Re: [VOTE] Release Commons Net 2.0

2008-04-07 Thread sebb
trunk (Java 1.3+) and branches/NET_2_0 (Java 1.5) have the most recent fixes. On 07/04/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > Hi > > From where is this code built? I've tried building from some different > tags and branches, but always get test failures. Here's the summaries >

Re: [VOTE] Release Commons Net 2.0

2008-04-07 Thread Niklas Gustavsson
Hi >From where is this code built? I've tried building from some different tags and branches, but always get test failures. Here's the summaries and the relevant surefire reports are attached. http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_2_0_RC3/ Tests in error: testInitial(org.

Re: [VOTE] Release Commons Net 2.0

2008-04-06 Thread sebb
Sorry, assumed it was a recent change. On 07/04/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > sigh. here it is - its been in there for a long time. > > > Added an ant target to the Maven build to generate an FTP-only jar file, > for clients who wish to use only FTP-based functionality. > >

Re: [VOTE] Release Commons Net 2.0

2008-04-06 Thread Rory Winston
sigh. here it is - its been in there for a long time. Added an ant target to the Maven build to generate an FTP-only jar file, for clients who wish to use only FTP-based functionality. sebb wrote: Just did - I'm none the wiser. On 07/04/2008, Rory Winston <[EMAIL PROTECTED]> wrote: look

Re: [VOTE] Release Commons Net 2.0

2008-04-06 Thread sebb
Just did - I'm none the wiser. On 07/04/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > look in the changes. > > sebb wrote: > > > On 07/04/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > > > > > > > Hi > > > > > > This is a release vote for Commons Net 2.0 RC3. This is a > > > maintenance rele

Re: [VOTE] Release Commons Net 2.0

2008-04-06 Thread Rory Winston
look in the changes. sebb wrote: On 07/04/2008, Rory Winston <[EMAIL PROTECTED]> wrote: Hi This is a release vote for Commons Net 2.0 RC3. This is a maintenance release. Thanks to everyone who contributed. The changes are here: http://people.apache.org/~rwinston/commons-net-2.0/site/c

Re: [VOTE] Release Commons Net 2.0

2008-04-06 Thread sebb
On 07/04/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi > > This is a release vote for Commons Net 2.0 RC3. This is a > maintenance release. Thanks to everyone who contributed. > > The changes are here: > > http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html > > T

[VOTE] Release Commons Net 2.0

2008-04-06 Thread Rory Winston
Hi This is a release vote for Commons Net 2.0 RC3. This is a maintenance release. Thanks to everyone who contributed. The changes are here: http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html The RC deployment is here: http://people.apache.org/~rwinston/commons-net-

Re: [VOTE] Release Commons Net 2.0

2008-03-09 Thread Rory Winston
That's great, thanks James! James Carman wrote: On 3/8/08, Rory Winston <[EMAIL PROTECTED]> wrote: Does anybody know if it is possible to generate a release notes skeleton automatically from JIRA? Sure. When you click "Browse Project" and you select Net (if it's not already selected

Re: [VOTE] Release Commons Net 2.0

2008-03-08 Thread James Carman
On 3/8/08, Rory Winston <[EMAIL PROTECTED]> wrote: > Does anybody know if it is possible to generate a release notes skeleton > automatically from JIRA? Sure. When you click "Browse Project" and you select Net (if it's not already selected), there's a "Release Notes" link under "All Projects."

Re: [VOTE] Release Commons Net 2.0

2008-03-08 Thread Rory Winston
Does anybody know if it is possible to generate a release notes skeleton automatically from JIRA? Rory Niall Pemberton wrote: I added the clirr report and it shows quite a few incompatible changes from the 1.4.1 release - this should be at least highlighted in release notes. Niall On Mon, Ma

Re: [VOTE] Release Commons Net 2.0

2008-03-07 Thread James Carman
On 3/2/08, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi > > This is a release vote for Commons Net 2.0. This release is a major new > release with a huge number of changes and fixes. This release requires > JDK 1.5+. > > The changes are here: > > http://people.apache.org/~rwinston/commons-net

Re: [VOTE] Release Commons Net 2.0

2008-03-03 Thread sebb
On 04/03/2008, Jeffrey Brekke <[EMAIL PROTECTED]> wrote: > I'm getting test failures, are they known issues? > > Tests in error: > > testInitial(org.apache.commons.net.telnet.TelnetClientTest) > > testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTest) > > testOptionRenegotiati

Re: [VOTE] Release Commons Net 2.0

2008-03-03 Thread Jeffrey Brekke
I'm getting test failures, are they known issues? Tests in error: testInitial(org.apache.commons.net.telnet.TelnetClientTest) testOptionNegotiation(org.apache.commons.net.telnet.TelnetClientTest) testOptionRenegotiation(org.apache.commons.net.telnet.TelnetClientTest) testNotification(o

Re: [VOTE] Release Commons Net 2.0

2008-03-03 Thread sebb
On 03/03/2008, sebb <[EMAIL PROTECTED]> wrote: > On 02/03/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > > Hi > > > > This is a release vote for Commons Net 2.0. This release is a major new > > release with a huge number of changes and fixes. This release requires > > JDK 1.5+. > > > >

Re: [VOTE] Release Commons Net 2.0

2008-03-03 Thread sebb
On 02/03/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi > > This is a release vote for Commons Net 2.0. This release is a major new > release with a huge number of changes and fixes. This release requires > JDK 1.5+. > > The changes are here: > > http://people.apache.org/~rwinston/commons

Re: [VOTE] Release Commons Net 2.0

2008-03-03 Thread Niall Pemberton
I added the clirr report and it shows quite a few incompatible changes from the 1.4.1 release - this should be at least highlighted in release notes. Niall On Mon, Mar 3, 2008 at 10:08 AM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > -1 from me because the source distro includes a "commons-net-2.

Re: [VOTE] Release Commons Net 2.0

2008-03-03 Thread Niall Pemberton
-1 from me because the source distro includes a "commons-net-2.0" folder (in src) which looks like a copy of the "target" folder containing the generated site, classes, distros etc. Not sure how this got generated because running the assembly target for me generated the source distro correctly. Als

[VOTE] Release Commons Net 2.0

2008-03-02 Thread Rory Winston
Hi This is a release vote for Commons Net 2.0. This release is a major new release with a huge number of changes and fixes. This release requires JDK 1.5+. The changes are here: http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html#a2.0 The RC deployment is here: http:/