I added the clirr report and it shows quite a few incompatible changes from the 1.4.1 release - this should be at least highlighted in release notes.
Niall On Mon, Mar 3, 2008 at 10:08 AM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > -1 from me because the source distro includes a "commons-net-2.0" > folder (in src) which looks like a copy of the "target" folder > containing the generated site, classes, distros etc. Not sure how this > got generated because running the assembly target for me generated the > source distro correctly. Also the main/java directory contains .class > files and a couple of java source files that are not in subversion > (FTPTest.java and TstFtp.java) - you need to do a *clean* checkout of > the tagged copy to build the RC from. > > Few of other points: > 1) The binary assembly descriptor for Net 2.x includes the javadocs in > the binary distro - but the "site" needs to be generated before the > assembly target is run, otherwise they are missing - as in they are in > this RC. > 2) If you use the "rc" profile, commons-parent automatically generates > -sources.jar and -javadoc.jar which are nice to have > 3) There are no tar.gz source/binary distros which the Net 2.x > source/binary assembly descriptors produce > > Running the following maven command when building resolves the above: > mvn -Prc site assembly:assembly > > 4) Would be nice to have release notes > 5) I prefer to vote on the actual aritfacts that are being > distributed, rather than SNAPSHOT versions - so the best you'll get > from me is a +0 when releasing this way > 6) Would be nice to see clirr reports to see if there are any > incompatibilities with previous releases. > > Niall > > > > On Sun, Mar 2, 2008 at 9:43 PM, Rory Winston <[EMAIL PROTECTED]> wrote: > > Hi > > > > This is a release vote for Commons Net 2.0. This release is a major new > > release with a huge number of changes and fixes. This release requires > > JDK 1.5+. > > > > The changes are here: > > > http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html#a2.0 > > > > The RC deployment is here: > > http://people.apache.org/~rwinston/commons-net-2.0/site/ > > > > Binaries: > > > http://people.apache.org/~rwinston/commons-net-2.0/commons-net-2.0.0-SNAPSHOT-bin.tar.gz > > > > Source: > > > http://people.apache.org/~rwinston/commons-net-2.0/commons-net-2.0.0-SNAPSHOT-src.tar.gz > > > > Javadocs: > > http://people.apache.org/~rwinston/commons-net-2.0/site/apidocs/index.html > > > > SVN tag: > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_2_0/ > > > > Here's my +1 in advance. > > Cheers > > Rory > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
