Re: [VOTE] Release configuration-1.10 based on RC1

On Tue, Oct 22, 2013 at 11:26 AM, sebb wrote: > On 22 October 2013 11:10, Henning Schmiedehausen > wrote: > > [haven't done that in a long time. Please bear with me...] > > > > Bug fixes and minor enhancements from configuration 1.9. > > > > So I would like to release configuration 1.10. > > > >

Re: [LANG] Findbugs and CheckStyle

Noting that we've not stopped having Findbugs, Checkstyle and PMD notes from blocking a release in the past if we didn't agree with them. Checkstyle should get improved, but it's not a regression (ie: 3.2 would be no worse than 3.1). Hen On Wed, Oct 23, 2013 at 11:21 PM, Benedikt Ritter wrote:

Re: [compress] Strong Crypto in Tests

On 2013-10-24, Benedikt Ritter wrote: > I don't see a reason to wait for 2.x before updating to JUnit 4. The > old tests will be executable without changes. There already are 4.x and 3.x tests mixed up. > Am I missing something here? It needs somebody to do it. As I expet us to rewrite all tes

Re: [VOTE] Release configuration-1.10 based on RC1

On Tue, Oct 22, 2013 at 9:48 AM, Gary Gregory wrote: > Hen: Welcome back to the release mud pit! ;) > Thank you Gar, I am glad to be here again. I am looking at your site and I also checked out the tag and built it. > > -1 > > The site, at the top says "Version 1.10-RC1", it should say "Versio

[LANG] Findbugs and CheckStyle

Hi guys, there are only two issues left in jira which can be fixed later than 3.2. If you agree feel free to change the Fix version, so that we can move on. I've looked through FindBugs and CheckStyle: CheckStyle: only missing JavaDoc in TypeUtils. To be honest I really don't know what the reflec

Re: [compress] Strong Crypto in Tests

2013/10/24 Gary Gregory > On Thu, Oct 24, 2013 at 1:45 AM, Benedikt Ritter >wrote: > > > > > > > Send from my mobile device > > > > > Am 23.10.2013 um 16:12 schrieb Stefan Bodewig : > > > > > >> On 2013-10-23, Gary Gregory wrote: > > >> > > >> Consider using JUnit's Assume to skip testing, this

Re: [compress] Strong Crypto in Tests

On Thu, Oct 24, 2013 at 1:45 AM, Benedikt Ritter wrote: > > > Send from my mobile device > > > Am 23.10.2013 um 16:12 schrieb Stefan Bodewig : > > > >> On 2013-10-23, Gary Gregory wrote: > >> > >> Consider using JUnit's Assume to skip testing, this will allow IDEs and > >> tools to know a test has

Re: [compress] Strong Crypto in Tests

Send from my mobile device > Am 23.10.2013 um 16:12 schrieb Stefan Bodewig : > >> On 2013-10-23, Gary Gregory wrote: >> >> Consider using JUnit's Assume to skip testing, this will allow IDEs and >> tools to know a test has been skipped. > > Unfortunately the test like many of Compress' tests

Re: [imaging] got anything left to add before release?

+1 for Java 6 Send from my mobile device > Am 24.10.2013 um 01:28 schrieb Gary Gregory : > > I could see updating to Java 6 and using Charset objects instead of String > encoding names to avoid catching exceptions in a bunch of places. That make > the code a little cleaner. > > Gary > > > On

Re: [imaging] Closing stream

On Thu, Oct 24, 2013 at 4:34 AM, Bernd Eckenfels wrote: > Am 24.10.2013, 02:16 Uhr, schrieb Gary Gregory : > >> try { >> if (outputStream != null) { >> outputStream.close(); >> } >> } catch (final Exception e) { >>

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

On Wed, Oct 23, 2013 at 8:33 PM, Sean Owen wrote: > it feels a little funny just > because then we should have similar logic for other decompositions. I > think I remember the LU one stops early, always. > The stopping early is definitely an option with QR. With LU, it isn't so clear.

Re: [imaging] Closing stream

Am 24.10.2013, 02:16 Uhr, schrieb Gary Gregory : try { if (outputStream != null) { outputStream.close(); } } catch (final Exception e) { Debug.debug(e); } this calls for a helper or a private

Re: BCEL 6 release?

On 24 October 2013 03:25, Gary Gregory wrote: > On Wed, Oct 23, 2013 at 10:12 PM, sebb wrote: > >> On 23 October 2013 23:10, Gary Gregory wrote: >> > I wish we could just keep each version on the site... >> >> We can; several components have multiple Javadoc directories. >> >> Also there is no r

Re: BCEL 6 release?

On Wed, Oct 23, 2013 at 10:12 PM, sebb wrote: > On 23 October 2013 23:10, Gary Gregory wrote: > > I wish we could just keep each version on the site... > > We can; several components have multiple Javadoc directories. > > Also there is no reason why the website should not reflect the > released

Re: BCEL 6 release?

On 23 October 2013 23:10, Gary Gregory wrote: > I wish we could just keep each version on the site... We can; several components have multiple Javadoc directories. Also there is no reason why the website should not reflect the released version, rather than current trunk. >From the point of view

Re: [imaging] Closing stream

On 24 October 2013 02:49, Gary Gregory wrote: > On Wed, Oct 23, 2013 at 9:38 PM, sebb wrote: > >> On 24 October 2013 01:16, Gary Gregory wrote: >> > Hi All: >> > >> > I see a log of this pattern: >> > >> > try { >> > if (outputStream != null) { >> >

Re: [imaging] Closing stream

On Wed, Oct 23, 2013 at 9:38 PM, sebb wrote: > On 24 October 2013 01:16, Gary Gregory wrote: > > Hi All: > > > > I see a log of this pattern: > > > > try { > > if (outputStream != null) { > > outputStream.close(); > > } > >

Re: [imaging] Closing stream

On 24 October 2013 01:16, Gary Gregory wrote: > Hi All: > > I see a log of this pattern: > > try { > if (outputStream != null) { > outputStream.close(); > } > } catch (final Exception e) { > Debug.debug(e);

Re: [maven build] Jira report?

On Wed, Oct 23, 2013 at 9:33 PM, sebb wrote: > On 23 October 2013 18:15, Gary Gregory wrote: > > One of the problems I have is that we do not solve is the following story > > well, and it is not a particular problem of Commons or the ASF: I want to > > update from [foo] version 2 to the current

Re: [maven build] Jira report?

On 23 October 2013 18:15, Gary Gregory wrote: > One of the problems I have is that we do not solve is the following story > well, and it is not a particular problem of Commons or the ASF: I want to > update from [foo] version 2 to the current version 5. How do I know what's > changed and what I ne

Re: [lang] clirr violations

On Wed, Oct 23, 2013 at 1:59 PM, Henri Yandell wrote: > Check http://issues.apache.org/jira/browse/LANG-462 comments for the > justification of the BC not being an issue. > Great, thank you for the pointer. Too bad we cannot annotate the Clirr report with custom comments, or maybe we can with so

[imaging] Closing stream

Hi All: I see a log of this pattern: try { if (outputStream != null) { outputStream.close(); } } catch (final Exception e) { Debug.debug(e); } for example in org.apache.commons.imaging.Imaging

Re: [imaging] got anything left to add before release?

I could see updating to Java 6 and using Charset objects instead of String encoding names to avoid catching exceptions in a bunch of places. That make the code a little cleaner. Gary On Wed, Oct 23, 2013 at 6:12 PM, Gary Gregory wrote: > I think a nice way to proceed would be to say something l

Re: [VOTE] Release Compress 1.6 based on RC3

+1 Checked out the tag and built "mvn site" with: Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 11:22:22-0400) Maven home: C:\Java\apache-maven-3.1.1\bin\.. Java version: 1.7.0_45, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_45\jre Default local

[functor] Add functor to svngit2jira

Hi,  Would it be all right to ask for [functor] component to be included in svngit2jira [1]? I've manually added commit messages to JIRA issues, but I believe this could be automated (thanks @Humbedooh). If there are no objections, I will file an issue during the weekend. Thanks! [1] https://

RE: [imaging] got anything left to add before release?

I think a nice way to proceed would be to say something like "I plan on cutting a release on such a date, so feel free to review trunk and tweak until then". This might save you a couple of RCs ;) Gary Sent via the Samsung Galaxy Note® 3, an AT&T 4G LTE smartphone Original message ---

[imaging] got anything left to add before release?

Hi I've resolved many Jira issues and the rest can get postponed, so I am pretty happy with the state of Imaging at the moment. Does anyone have anything left to add before I start trying to make the next release candidate? Damjan

Re: [VOTE] Release Compress 1.6 based on RC3

Hello Stefan, my environment is: Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 17:22:22+0200) Maven home: /Applications/dev/maven/apache-maven-3.1.1 Java version: 1.7.0_40, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

Ah I see so you can just stop computing the eigenvectors when the eigenvalues are too small. That does seem more efficient and then the zero values are left as literally 0. I think I should back up and implement the patch that way. The original question stands then -- what to do about the singular

Re: [maven build] Jira report?

Original message From: Matt Benson Date:10/23/2013 13:45 (GMT-05:00) To: Commons Developers List Subject: Re: [maven build] Jira report? On Wed, Oct 23, 2013 at 12:15 PM, Gary Gregory wrote: > One of the problems I have is that we do not solve is the following story > well

Re: svn commit: r1534380 - in /commons/proper/lang/trunk/src: main/java/org/apache/commons/lang3/NotImplementedException.java test/java/org/apache/commons/lang3/NotImplementedExceptionTest.java

On Tue, Oct 22, 2013 at 12:26 PM, Benedikt Ritter wrote: > Hi Hen, > > > 2013/10/21 > > > + * @author Apache Software Foundation > > > > This author tag looks strange. Did you add it by purpose? > > Removed :) Thanks for the catch; it was something we used to do in Commons but stopped doing. Whe

Re: [lang] clirr violations

Check http://issues.apache.org/jira/browse/LANG-462 comments for the justification of the BC not being an issue. Hen On Wed, Oct 23, 2013 at 10:24 AM, Gary Gregory wrote: > The current Clirr report shows errors. > > Do want to go to a 4.0 or fix the BC break and do a 3.2? > > Gary > > -- > E-Ma

Re: [maven build] Jira report?

On Wed, Oct 23, 2013 at 12:15 PM, Gary Gregory wrote: > One of the problems I have is that we do not solve is the following story > well, and it is not a particular problem of Commons or the ASF: I want to > update from [foo] version 2 to the current version 5. How do I know what's > changed and w

Re: [maven build] Jira report?

Can you point me to a good JIRA report? The Lang one is worthless, so maybe the issue is that I don't understand what good would be :) On Wed, Oct 23, 2013 at 10:15 AM, Gary Gregory wrote: > One of the problems I have is that we do not solve is the following story > well, and it is not a particu

[lang] clirr violations

The current Clirr report shows errors. Do want to go to a 4.0 or fix the BC break and do a 3.2? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition

Re: [maven build] Jira report?

One of the problems I have is that we do not solve is the following story well, and it is not a particular problem of Commons or the ASF: I want to update from [foo] version 2 to the current version 5. How do I know what's changed and what I need to do to migrate/upgrade? The first thing I do is l

Re: [maven build] Jira report?

On Tue, Oct 22, 2013 at 12:04 PM, Benedikt Ritter wrote: > 2013/10/22 sebb > > > On 22 October 2013 19:40, Henri Yandell wrote: > > > Anyone know what the point of the JIRA report is? > > > > > > It seems to be much like the changes report, but with less active > > > authorship and a confusing i

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

On Wed, Oct 23, 2013 at 3:14 PM, Sean Owen wrote: > EigenDecomposition resembles QR in this respect, as far as they are > implemented here. This argues for them to treat arguments similarly. > Actually not. It is quite reasonable for the EigenDecomposition to stop when singularity is reached.

Re: [compress] Strong Crypto in Tests

On 2013-10-23, Gary Gregory wrote: > Consider using JUnit's Assume to skip testing, this will allow IDEs and > tools to know a test has been skipped. Unfortunately the test like many of Compress' tests is in JUnit 3.x land - something to change if we ever get 2.x off the ground. Stefan

Re: [compress] Strong Crypto in Tests

On 2013-10-23, Mark Fortner wrote: > As you're probably aware, aes is export restricted. Commons Compress already has a crypto notice, see also 7z uses 256bit AES when encrypting so if we want to provide code that can read encrypted archives there is lit

Re: [compress] Strong Crypto in Tests

Consider using JUnit's Assume to skip testing, this will allow IDEs and tools to know a test has been skipped. If you use a conditional in the test code, there is no possible feedback. Gary On Wed, Oct 23, 2013 at 5:15 AM, Stefan Bodewig wrote: > On 2013-10-23, Emmanuel Bourg wrote: > > > The

Re: [compress] Strong Crypto in Tests

On 2013-10-23, Paul Benedict wrote: > In my own research on strong crypto, I found out that US law allows > strong crypto to be exported for open source software. That was some > provision recently carved out in the last 10 years. I think there are > some limitations and procedures wrapped around

Re: [lang] ImmutablePair is final

On Wed, Oct 23, 2013 at 9:09 AM, Paul Benedict wrote: > The safest approach is composition. It's the only way for the immutability > contract to be honored across development teams (Commons + end user). > Thank you all for your feedback. Gary > > > On Wed, Oct 23, 2013 at 1:00 AM, Duncan Jone

Re: [compress] Strong Crypto in Tests

In my own research on strong crypto, I found out that US law allows strong crypto to be exported for open source software. That was some provision recently carved out in the last 10 years. I think there are some limitations and procedures wrapped around it -- like submitting the URL to the source c

Re: [compress] Strong Crypto in Tests

As you're probably aware, aes is export restricted. So it might be better to simply check for the availability of a particular encryption algorithm before running a test and avoid making restricted libraries generally available. Mark On Oct 23, 2013 6:10 AM, "Stefan Bodewig" wrote: > On 2013-10-

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

Yeah it's a tricky one. I agree with the functionality, because the QR decomposition can happily operate on a singular matrix. R will be singular if A is, AFAIK. So the singularity threshold business belongs more in the bit that uses R, yes. The same could be said of the SVD. But it provides no si

Re: [compress] Strong Crypto in Tests

On 2013-10-23, Bear Giles wrote: > Should that be PKCS7Padding? Or would that be worse - I don't recall > if it's one of the "must have" paddings in the spec. 7z uses "AES/CBC/NoPadding" and that's what I use during the check inside the unit tests as well now. Stefan ---

Re: [lang] ImmutablePair is final

The safest approach is composition. It's the only way for the immutability contract to be honored across development teams (Commons + end user). On Wed, Oct 23, 2013 at 1:00 AM, Duncan Jones wrote: > On 23 Oct 2013 01:26, "Gary Gregory" wrote: > > > > On Tue, Oct 22, 2013 at 4:53 PM, Duncan Jo

Re: [compress] Strong Crypto in Tests

Should that be PKCS7Padding? Or would that be worse - I don't recall if it's one of the "must have" paddings in the spec. http://crypto.stackexchange.com/questions/9043/what-is-the-difference-between-pkcs5-padding-and-pkcs7-padding In practice it's unlikely that a software-based crypto provider w

Re: [lang] ImmutablePair is final

On 23 Oct 2013 01:26, "Gary Gregory" wrote: > > On Tue, Oct 22, 2013 at 4:53 PM, Duncan Jones wrote: > > > On 22 October 2013 21:07, Gary Gregory wrote: > > > On Tue, Oct 22, 2013 at 3:59 PM, Matt Benson > > wrote: > > > > > >> So what is having a non-generic runtime class accomplishing for you

Re: [MATH] Repurposing a deprecated constructor in EigenDecomposition

Hi Sean, while looking at the QRDecomposition, it is interesting that the threshold value provided to the constructor of QRDecomposition is only used to pass it on the the Solver created by getSolver(). Imho, it would be more logical to chose the singularity threshold when calling getSolver() for

Re: Commons functor

Hi Mats! >Hi, are there any plans for releasing this project? Yes, I'm already using [functor] in some experiments with fuzzy logic and Jenkins plug-ins, and having fun with JDK 8 lambdas. We still have two open issues before a release though. >The "Function" I need is a "PredicatedProcedure"

[MATH] Repurposing a deprecated constructor in EigenDecomposition

In MATH-1045 (https://issues.apache.org/jira/browse/MATH-1045) we have discussed adding a zero threshold tolerance to EigenDecomposition just like QRDecomposition has. This involves adding a new constructor with a new double parameter. Just one problem: there's already such a constructor: /**

Re: [compress] Strong Crypto in Tests

On 2013-10-23, Jörg Schaible wrote: > boolean supportedKeyLength(int keyLen) throws NoSuchAlgorithmException > { >if (Cipher.getMaxAllowedKeyLength("AES/ECB/PKCS5Padding") < keyLen) { > System.err.println("WARNING: " + getName() >+ " not executed, environment does not support "

Re: [compress] Strong Crypto in Tests

Stefan Bodewig wrote: > On 2013-10-23, Emmanuel Bourg wrote: > >> The test coverage is much better, thank you Stefan. > > Thank you for making me find a serious bug by pointing out the low > coverage :-) > >> test7zDecryptUnarchive failed on Linux using the Java 6 JDK (not >> OpenJDK6) due to t

[compress] Strong Crypto in Tests

On 2013-10-23, Emmanuel Bourg wrote: > The test coverage is much better, thank you Stefan. Thank you for making me find a serious bug by pointing out the low coverage :-) > test7zDecryptUnarchive failed on Linux using the Java 6 JDK (not > OpenJDK6) due to the lack of the strong crypto policy. T

Re: [VOTE] Release Compress 1.6 based on RC3

+1 The test coverage is much better, thank you Stefan. test7zDecryptUnarchive failed on Linux using the Java 6 JDK (not OpenJDK6) due to the lack of the strong crypto policy. That's easily fixed by installing the missing files [1], but as a convenience I would suggest skipping this test when the