Hi Sean, while looking at the QRDecomposition, it is interesting that the threshold value provided to the constructor of QRDecomposition is only used to pass it on the the Solver created by getSolver().
Imho, it would be more logical to chose the singularity threshold when calling getSolver() for the respective decomposition, that way we could also add it to the EigenDecomposition class. Thomas On Wed, Oct 23, 2013 at 1:23 PM, Sean Owen <sro...@gmail.com> wrote: > In MATH-1045 (https://issues.apache.org/jira/browse/MATH-1045) we have > discussed adding a zero threshold tolerance to EigenDecomposition just > like QRDecomposition has. This involves adding a new constructor with > a new double parameter. > > Just one problem: there's already such a constructor: > > /** > * Calculates the eigen decomposition of the given real matrix. > * > * @param matrix Matrix to decompose. > * @param splitTolerance Dummy parameter (present for backward > * compatibility only). > * @throws MathArithmeticException if the decomposition of a general > matrix > * results in a matrix with zero norm > * @throws MaxCountExceededException if the algorithm fails to > converge. > * @deprecated in 3.1 (to be removed in 4.0) due to unused parameter > */ > @Deprecated > public EigenDecomposition(final RealMatrix matrix, > final double splitTolerance) > throws MathArithmeticException { > this(matrix); > } > > Reusing this constructor would introduce a functionally incompatible > change, as the previous meaning of this value was different. > > What are people's thoughts on proceeding anyway for a minor point > release like 3.3? > Or, best saved for 4.x? > > Sean > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
