Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@nvazquez great work.
However, there is a catch there that I think you might have overlooked.
This problem is caused by the method extraction I suggested.
If you take a
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1948
Great, nice work.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1957
@Ashadeepa thanks for the information.
As a tip, try to avoid opening duplicated PRs, it gets hard for reviewers
to track changes and discussions.
As @ustcweizhou
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@nvazquez was the static declaration there before?! I am so sorry I missed
it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102486318
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102322603
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102487341
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102323551
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102534985
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102535697
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102536773
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1907
@swill LGTM for the changes.
The changes introduced now are different from the last ones, right? Now it
is basically the addition of a log and the skipping of a processing
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1907
Ok, great.
Thanks for the explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1957
Actually, my concerns are not regarding the response. Reading the name of
the method one can for sure understand what it returns. My concern is that
reading the parameter name
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@serg38 I did, the code is great as always. However, I have a concern about
that `rollBackState` variable being static there. Because the
`DomainManagerImpl ` is a singleton, using
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@milamberspace @rhtyd do you know why the entry "label.host.alerts" was
removed from some languages?
---
If your project is set up for it, you can reply to this email and
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1896
Got it, thanks for the explanation. I saw that, and I was wondering if it
could have been a bug or something else.
LGTM then.
---
If your project is set up for it, you can
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1974
@dmabry what about using `git cherry-pick` to introduce the changes that
were already merged into master in 4.9? Then, we can maintain the same commit
hash. This would facilitate
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1973
@dmabry as I posted on the other PR, I only suggested `git cherry-pick`
because I thought it would preserve the commit hash. It was a misunderstanding
from me. The git hash is
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1987
@niteshsarda I suggest you adding line 2281 from "managementService" to
"domainMgr". The only difference between those two methods is this line.
Assuming that yo
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1987
@niteshsarda thank you very much :)
The less duplicated or useless code around the better.
The method 'updateDomain' is huge and you just changed a single line th
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1278
@anshul1886 sorry, but I still do not understand you.
Your changes affect `NetworkHelperImpl.java` class. Do we agree on that?
You changed lines 334 and 512. You
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1278
First, I would like to apologize for being so stubborn, but if I do not
understand something I like to ask questions. I hope you do not mind.
Before we proceed with the
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r104769967
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r104770076
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCopyFileInVmCommandWrapper.java
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r104769820
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r104768693
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +602,25
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/669
@anshul1886 you asked to show you how it can be done.
I opened a PR https://github.com/anshul1886/cloudstack-1/pull/1 for the
branch you are using in this PR. Can you take a look
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r105259838
--- Diff:
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
@Parameter(name
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@nvazquez I am assuming the change needed to fix the bug is line 135 at
PrimaryDataStoreHelper.java?
The other changes are regarding code conformity
---
If your project is set
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@jayakarteek I did not understand your doubt.
I see by your SS that the reservation field contains the speed configured
in your service offering. From what I understood so far
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1278
Great @anshul1886, we seem to start converging.
So, what you call setting context, is the execution of
âorg.apache.cloudstack.context.CallContext.getCallingAccount()â
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105488722
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105488183
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105489528
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -409,15 +460,13 @@ public
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105679910
--- Diff:
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
---
@@ -216,6 +216,20 @@ public void
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105677642
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2072,6 +2121,17 @@ protected
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105676576
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105678507
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1928,6 +1929,54 @@ protected
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@jayakarteek thanks for the explanation
I thought that ACS would configure those parameters automatically. The way
you described it feels like ACS is not limiting the use of CPU
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105723986
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
public void
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105723252
--- Diff: api/src/com/cloud/resource/ResourceService.java ---
@@ -50,7 +52,7 @@
Host cancelMaintenance(CancelMaintenanceCmd cmd
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105723444
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java ---
@@ -100,17 +103,18 @@ public Long getInstanceId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105724153
--- Diff:
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
---
@@ -512,7 +512,11 @@ public void
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105723834
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -986,33 +986,28 @@ public Answer easySend(final Long
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105725769
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@nitin-maharana I was looking at the PR.
Do you need to split everything thing there in a different commit?
I think that we still do not have a clear understanding when and how
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1918
This seems to be a great idea @nvazquez.
What do you think @jayakarteek ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@jayakarteek from what I understood so far, there will always be a mismatch.
For instance, the way it is implemented so far, if a VM uses a service
offering that provides 1000
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105942978
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
public void
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105952120
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105959827
--- Diff:
engine/schema/test/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105959436
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105959564
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105992559
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105993059
--- Diff:
engine/schema/test/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImplTest.java
---
@@ -0,0 +1,151
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1278
@anshul1886 what method that is called in multiple places are you talking
about?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1918
Awesome! This seems a good approach to deal with the issue.
@jayakarteek and @nvazquez thanks for the effort.
@jayakarteek sorry for all of the stubbornness ;)
You
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r106185108
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java ---
@@ -100,17 +103,18 @@ public Long getInstanceId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r106185631
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
public void
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r106186279
--- Diff:
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
---
@@ -512,7 +512,11 @@ public void
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r106188366
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106001103
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106306374
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106313430
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r106670299
--- Diff:
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
@Parameter(name
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1918#discussion_r108463719
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -196,6 +196,7 @@ public UserVmResponse newUserVmResponse
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r108469206
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Folks, what about a middle ground here?
I was checking the commits. For instance, all of the commits
"Added/implemented XXX ." could be all squashed by the same aut
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1278
@anshul1886, this pointing finger thing is not good.
I do not know why people did not do the work as it should have been done
before. I was probably not around when that was
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102538324
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -109,6 +112,20 @@
@Inject
MessageBus _messageBus
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r103529869
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,69 @@ public void testFindDomainByIdOrPathValidId
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r103529571
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +284,145 @@ public boolean deleteDomain(long domainId, Boolean
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@nvazquez now everything seems to be ok
LGTM.
Great job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/2036
[CLOUDSTACK-9858] Retirement of midonet plugin (build disabling)
Recently there have been two threads asking and discussing the
âmidonetâ integration with Apache CloudStack (ACS
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/2036
I tried to access the Jenkins details to see the checking problems, but I
am getting a 404.
Am I missing something?
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164417605
Hi @nitin-maharana I agree with @DaanHoogland, we should maintain backward
compatibility. I almost liked you code, I would just suggest you extracting it
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164471811
@Wilderrodrigues, @borisroman I agree with you that we cannot merge PRs
without two(2) LGTMs and integration tests to check if nothing was broken
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164482127
@nitin-maharana I do not agree with you. Take a look at the size of the
method âallocVolumeâ, there are more than 100 lines, that is terrible to
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-166032637
@cristofolini could you please remove the @Local annotation from
CitrixResourceBase ?
---
If your project is set up for it, you can reply to this email
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1258#issuecomment-166114305
@nitin-maharana shouldn't we use the "recursive" parameter set to "true"
too?
---
If your project is set up for it, you can rep
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166304851
LGTM,
Looking at that database upgrade checker that does not just check but also
upgrade the ACS schema, I got me thinking that there has to be a
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166305826
I understand you; I will have a look at that, to see how other projects
deal with that kind of problem. If I find something interesting I will bring
that
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-166987980
@nitin-maharana, thanks for the update, I will just call your attention to
a few points:
First of all, why did you open a new PR? I know you
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1258#issuecomment-167539882
@nitin-maharana thanks for checking.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-167540899
@nitin-maharana I did not notice that the other PR was to 4.6, I thought it
was to master.
I would just ask you to use a Javadoc block over
â
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1296#issuecomment-167672958
@remibergsma the code looks ok, would you mind to squash your commits?
---
If your project is set up for it, you can reply to this email and have your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-167760979
@nitin-maharana now almost everything is ok.
There is only one problem. the
"org.apache.commons.lang.StringUtils.isBlank" also returns t
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-167768433
@nitin-maharana now the code is perfect.
I can give a LGTM now.
Sorry if I bothered you with a lot of changes.
---
If your project is set
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1296#issuecomment-168351379
@remibergsma got it ;), no problem.
What was the reason to split the PR into two commits? It seems a pretty
simple change.
---
If your project is
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49101315
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-169753995
Would you mind changing the comments over attributes âdetailsâ and
âisDynamicâ to proper java doc style? Additionally, what about changing
them
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49103580
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49183061
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49316008
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170620697
@DaanHoogland the problem seems to be related to something else.
It seemed more like a DNS problem to resolve the google.com address
---
If your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1337#issuecomment-171373038
Hi @nitin-maharana,
What about a little change in your code?
The complexity of that if/else structure that you are working on is too big
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1338#issuecomment-171379436
@nitin-maharana, if you create the function I suggested you to create in PR
#1337, you could re-use it here. The code block 3637-3650 is the same as the
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49713222
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -821,9 +819,9 @@ protected boolean
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1278#issuecomment-171619337
@anshul1886 I did not understand what you wanted to express presenting
those commits, would you care to explain? I noticed the commits you pointed
out
1 - 100 of 626 matches
Mail list logo
