Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r105723834
  
    --- Diff: 
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
    @@ -986,33 +986,28 @@ public Answer easySend(final Long hostId, final 
Command cmd) {
         }
     
         @Override
    -    public boolean reconnect(final long hostId) {
    +    public void reconnect(final long hostId) throws CloudRuntimeException, 
AgentUnavailableException{
    --- End diff --
    
    You added `AgentUnavailableException` to the method signature, but I did 
not see you throwing this exception anywhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to