Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1918
  
    @jayakarteek thanks for the explanation
    I thought that ACS would configure those parameters automatically. The way 
you described it feels like ACS is not limiting the use of CPU for VMs created 
in VMware systems. 
    
    I was checking the code, and there is this piece here: 
`com.cloud.hypervisor.vmware.util.VmwareHelper.setBasicVmConfig(VirtualMachineConfigSpec,
 int, int, int, int, int, String, boolean)`. At line 634 ACS is setting the CPU 
limit if CPU cap is enabled. Isn't that information available to be retrieved 
later (when we get the stats of a VM)? I know, this will only work with CPU 
cap. However, we could retrieve that CPU limit configuration, if it is '-1', we 
could then retrieve the CPU speed of the host (and use it to calculate the 
percentage of usage), is it possible? Or do you think it brings much trouble 
for the code?
    
    @nvazquez could you also provide some feedback here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to