Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1957
@Ashadeepa thanks for the information.
As a tip, try to avoid opening duplicated PRs, it gets hard for reviewers
to track changes and discussions.
As @ustcweizhou suggested, you could have used a push force to push the new
changes to the old PR branch.
I think @syed has asked you before; what is this `keyword` parameter? The
docs are not clear about it; it just says âList by keywordâ. This property
comes from `org.apache.cloudstack.api.BaseListCmd`. This parameter was not been
used before here; so I am assuming you are repurposing it, or at least giving a
use to a property that was already there.
Looking at the code, I am I see that you use the keyword value to list any
username that matches it. My question is the following: is there a way to
document this use case? Otherwise, only a hand full of people will know its
use. I have to tell you, reading the docs
(https://cloudstack.apache.org/api/apidocs-4.9/apis/listVpnUsers.html), I would
never try to use the `keyword` parameter as a filter to list all users that may
match a given string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
