Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105942978
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
public void pullAgentOutMaintenance(long hostId);
- boolean reconnect(long hostId);
+ void reconnect(long hostId) throws CloudRuntimeException,
AgentUnavailableException;
--- End diff --
@bvbharatk I got your intentions here. However, donât you think we can
work out the places where people are login runtime exceptions, instead of
bubbling them up? I believe that instead of creating constraints in the code,
we should spot when people are introducing these things, and educate them. For
the code that is already doing the things you mentioned, well, we can work to
fix them bit by bit.
It feels a little unusual (at least for me) to declare runtime exceptions.
At the end of the day, you may make it more visible, but just because you
declare a runtime exception, it does not mean people will be forced to catch it
(they will not be forced to catch it).
BTW: I never had a good expression to talk about the re-throw of
exceptions. Thanks for the âbubble exception upâ.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
