Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903296
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -358,19 +441,22 @@ private String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903426
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java
---
@@ -19,37 +19,66 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903493
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java
---
@@ -19,37 +19,66 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903522
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java
---
@@ -19,37 +19,66 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903696
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903745
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903815
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903824
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904007
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904125
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904211
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904637
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,53 +226,181 @@ public NuageVspDeviceVO
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904829
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904843
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39904914
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905120
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905171
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905503
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905738
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905769
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905792
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905801
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39905894
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906015
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906178
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906333
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906365
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906437
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906532
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906542
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906665
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906674
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +507,341 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906769
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -348,6 +851,7 @@ public String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906994
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -262,15 +260,19 @@ public String getName
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39906971
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -262,15 +260,19 @@ public String getName
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907093
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -441,6 +456,44 @@ private Answer
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907061
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -441,6 +456,44 @@ private Answer
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907080
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -441,6 +456,44 @@ private Answer
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907150
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -464,4 +517,10 @@ protected void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907305
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,86 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907517
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,86 @@
package
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907673
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java
---
@@ -23,8 +23,8 @@
public void login
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907736
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java
---
@@ -24,12 +24,17 @@
public
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907761
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java
---
@@ -21,23 +21,21 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907773
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java
---
@@ -0,0 +1,41 @@
+//
+// Licensed to
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-141592925
Is there a test plan/procedure for verifying the operation of his plugin?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-142621231
Thanks @nlivens. I will review your comment and the updates later today or
early tomorrow (24 Sept 2015).
---
If your project is set up for it, you can reply to
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-143282229
@Pradeepgjain can you please provide information about how members of the
community can independently test the plugin's functionality?
---
If your project i
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62754671
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62754742
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62754845
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62754948
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62755020
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62755100
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62756570
--- Diff:
api/src/org/apache/cloudstack/api/command/user/vpc/CreateVPCCmd.java ---
@@ -143,7 +149,17 @@ public Boolean getDisplayVpc
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62757226
--- Diff:
api/test/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigCmdTest.java
---
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62757346
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -485,6 +485,10 @@ updateVPCOffering=1
deleteVPCOffering=1
listVPCOfferings=15
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62757726
--- Diff: core/src/com/cloud/agent/api/routing/QuaggaConfigCommand.java ---
@@ -0,0 +1,86 @@
+//
+// Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62762933
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62763000
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62763147
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62763200
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62763274
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62763423
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62763676
--- Diff: engine/components-api/src/com/cloud/network/vpc/VpcManager.java
---
@@ -161,8 +161,9 @@
* @param gateway
* @param
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62764156
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1445,28 +1466,31 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62764350
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1445,28 +1466,31 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62779198
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1445,28 +1466,31 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62779378
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1476,22 +1500,22 @@ public void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62779835
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2024,8 +2047,25 @@ public Network
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780074
--- Diff: engine/schema/src/com/cloud/dc/DataCenterVO.java ---
@@ -365,6 +366,18 @@ public void setLocalStorageEnabled(boolean enabled
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780203
--- Diff:
engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java
---
@@ -308,15 +331,21 @@ public void setEnabledServices(List
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780405
--- Diff:
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java ---
@@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780467
--- Diff:
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java ---
@@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780557
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -138,7 +138,8 @@ public
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780906
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -2111,8 +2098,9 @@ public Network updateGuestNetwork(final long
networkId, String
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781171
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -482,8 +474,8 @@ public boolean applyIps(final Network network
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781348
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -1048,4 +1052,33 @@ protected String getGuestDhcpRange(final NicProfile
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781459
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -198,14 +199,26 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781596
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781651
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781709
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781813
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782035
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782148
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -501,7 +517,7 @@ private void
validateConnectivtyServiceCapabilities(final Set
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782162
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -529,14 +545,14 @@ private boolean findCapabilityForService(final Map
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782392
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782438
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782496
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782579
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782681
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782819
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782870
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782933
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783039
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long
vpcOffId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783052
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long
vpcOffId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783380
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -1236,18 +1218,34 @@ public void
doInTransactionWithoutResult
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783468
--- Diff:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
---
@@ -212,4 +214,20 @@ public boolean visit(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783518
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785317
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under
601 - 700 of 1884 matches
Mail list logo
