Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907736
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java
---
@@ -24,12 +24,17 @@
public interface NuageVspElementClient {
- public void applyStaticNats(String networkDomainUuid, String
vpcOrSubnetUuid, boolean isL3Network, List<Map<String, Object>>
staticNatDetails) throws Exception;
+ public boolean implement(long networkId, String networkDomainUuid,
String networkUuid, String networkName, String vpcOrSubnetUuid, boolean
isL2Network, boolean isL3Network,
+ boolean isVpc, boolean isShared, String
domainTemplateName, boolean isFirewallServiceSupported, List<String>
dnsServers, List<Map<String, Object>> ingressFirewallRules,
+ List<Map<String, Object>>
egressFirewallRules, List<String> acsFipUuid, boolean egressDefaultPolicy)
throws Exception;
- public void applyAclRules(String networkUuid, String
networkDomainUuid, String vpcOrSubnetUuid, boolean isL3Network,
List<Map<String, Object>> aclRules, boolean isVpc, long networkId)
- throws Exception;
+ public void applyStaticNats(String networkDomainUuid, String
networkUuid, String vpcOrSubnetUuid, boolean isL3Network, boolean isVpc,
+ List<Map<String, Object>>
staticNatDetails) throws Exception;
- public void shutDownVpc(String domainUuid, String vpcUuid) throws
Exception;
+ public void applyAclRules(boolean isNetworkAcl, String networkUuid,
String networkDomainUuid, String vpcOrSubnetUuid, String networkName, boolean
isL2Network,
+ List<Map<String, Object>> rules, long
networkId, boolean egressDefaultPolicy, Boolean isAcsIngressAcl, boolean
networkReset, String domainTemplateName) throws Exception;
+
+ public void shutdownVpc(String domainUuid, String vpcUuid, String
domainTemplateName) throws Exception;
--- End diff --
Why is Exception declared in the throws instead of the list of expected
checked exceptions on all of these methods?
Also, ``public`` modifiers on ``public interface`` declarations are
extraneous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
