Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62780074
--- Diff: engine/schema/src/com/cloud/dc/DataCenterVO.java ---
@@ -365,6 +366,18 @@ public void setLocalStorageEnabled(boolean enabled) {
}
@Override
+ public boolean isDynamicRoutingEnabled() {
+ String dynr = getDetail(OSPFZoneConfig.Params.ENABLED.name());
--- End diff --
There is a common pattern across this patch where ``getDetail`` is called
and then the returned value is checked. If the return value is ``null``, a
default value is returned. Please consider adding a ``getOptionalDetail(key,
defaultValue)`` method that encapsulates this logic. If this method is added,
please add a unit test to verify its behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
