Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781171
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -482,8 +474,8 @@ public boolean applyIps(final Network network, final
List<? extends PublicIpAddr
if (canHandle) {
final List<DomainRouterVO> routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
- s_logger.debug(getName() + " element doesn't need to
associate ip addresses on the backend; VPC virtual " + "router doesn't exist in
the network "
- + network.getId());
+ s_logger.debug(
+ getName() + " element doesn't need to associate ip
addresses on the backend; VPC virtual " + "router doesn't exist in the network
" + network.getId());
--- End diff --
While this change is the result of a reformat, would it be possible to wrap
this logging statement in a ``s_logger.isDebugEnabled()`` check to avoid
unnecessary string concatenation when ``DEBUG`` logging is not enabled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
