Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39907761
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java
---
@@ -21,23 +21,21 @@
import java.util.Collection;
import java.util.List;
-import java.util.Map;
public interface NuageVspGuruClient {
public void implement(String networkDomainName, String
networkDomainPath, String networkDomainUuid, String networkAccountName, String
networkAccountUuid, String networkName,
- String networkCidr, String networkGateway, String networkUuid,
boolean isL3Network, String vpcName, String vpcUuid, boolean
defaultEgressPolicy,
- Collection<String> ipAddressRange) throws Exception;
+ String networkCidr, String networkGateway, Long
networkAclId, List<String> dnsServers, List<String> gatewaySystemIds, boolean
isL3Network, boolean isVpc, boolean isSharedNetwork,
+ String networkUuid, String vpcName, String
vpcUuid, boolean defaultEgressPolicy, Collection<String[]> ipAddressRange,
String domainTemplateName) throws Exception;
- public List<Map<String, String>> reserve(String nicUuid, String
nicMacAddress, String networkUuid, boolean isL3Network, String vpcUuid, String
networkDomainUuid,
- String networksAccountUuid, boolean isDomainRouter, String
domainRouterIp, String vmInstanceName, String vmUuid) throws Exception;
+ public void reserve(String nicUuid, String nicMacAddress, String
networkUuid, boolean isL3Network, boolean isSharedNetwork, String vpcUuid,
String networkDomainUuid,
+ String networksAccountUuid,
boolean isDomainRouter, String domainRouterIp, String vmInstanceName, String
vmUuid, boolean useStaticIp, String staticIp, String staticNatIpUuid,
+ String staticNatIpAddress,
boolean isStaticNatIpAllocated, boolean isOneToOneNat, String
staticNatVlanUuid, String staticNatVlanGateway, String staticNatVlanNetmask)
throws Exception;
- public void release(String networkUuid, String vmUuid, String
vmInstanceName) throws Exception;
+ public void deallocate(String networkUuid, String nicFrmDdUuid, String
nicMacAddress, String nicIp4Address, boolean isL3Network, boolean
isSharedNetwork,
+ String vpcUuid, String networksDomainUuid,
String vmInstanceName, String vmUuid, boolean isExpungingState) throws
Exception;
- public void deallocate(String networkUuid, String nicFrmDdUuid, String
nicMacAddress, String nicIp4Address, boolean isL3Network, String vpcUuid,
String networksDomainUuid,
- String vmInstanceName, String vmUuid) throws Exception;
-
- public void trash(String domainUuid, String networkUuid, boolean
isL3Network, String vpcUuid) throws Exception;
+ public void trash(String domainUuid, String networkUuid, boolean
isL3Network, boolean isSharedNetwork, String vpcUuid, String
domainTemplateName) throws Exception;
public void setNuageVspApiClient(NuageVspApiClient nuageVspApiClient);
--- End diff --
Why is Exception declared in the throws instead of the list of expected
checked exceptions on all of these methods?
Also, ``public`` modifiers on ``public interface`` declarations are
extraneous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
