Re: mido client

2013-09-18 Thread Dave Cahill
Good to hear! On Wed, Sep 18, 2013 at 6:10 PM, Daan Hoogland wrote: > Thanks Dave, > > I still had the google docs in the proxy and it has the same id, now > both the new and the old are in our cache. > > regards, > Daan > > On Tue, Sep 17, 2013 at 3:21 AM, D

Re: mido client

2013-09-16 Thread Dave Cahill
hanks, Dave. On Mon, Sep 16, 2013 at 10:23 PM, Daan Hoogland wrote: > http://cs-maven.midokura.com/releases/ is the right location, right? I > get a blank page there (no pom or jar) or is it somewhere else? > > On Mon, Sep 16, 2013 at 3:17 PM, Dave Cahill wrote: > > Copying part

Re: Handling Public network traffic in a plugin

2013-09-16 Thread Dave Cahill
to be a problem? It works for me and I > don't see any objections to it. > > regards, > Daan > > On Fri, Sep 6, 2013 at 12:30 PM, Daan Hoogland > wrote: > > H Dave, > > > > I actually didn't give 'guest' to much thought. I had to change the &g

Re: mido client

2013-09-16 Thread Dave Cahill
Copying part of the IM conversation just now in case anyone else has the same question. As Prasanna mentioned in this thread [1]: "If you are using a nexus proxy in the way of your build, you'll have to add a 3rd party repo and the jars will be automatically indexed and downloaded." Thanks, Dave.

Re: Release Criteria

2013-09-11 Thread Dave Cahill
> > > A broken master also slows down other devs. I can't remember the number > of times I've been debugging master for hours to find out something broke > it. > > > so how do we enforce this ? IMO, Gerrit can be used to enforce a saner workflow, see previous discussion at [1]. Having a workflow

Re: [ANNOUNCE] New PMC member: Ilya Musayev

2013-09-05 Thread Dave Cahill
Great stuff, congrats Ilya. :) On Thu, Sep 5, 2013 at 4:13 PM, Sateesh Chodapuneedi < sateesh.chodapune...@citrix.com> wrote: > Congrats Ilya! Well deserved :-) > > Regards, > Sateesh > > > -Original Message- > > From: sebgoa [mailto:run...@gmail.com] > > Sent: 05 September 2013 12:23 >

Re: Handling Public network traffic in a plugin

2013-09-04 Thread Dave Cahill
> > I will have to write more doc and any specific questions would help. > > mobile biligual spell checker used > Op 4 sep. 2013 11:45 schreef "Dave Cahill" het > volgende: > > > Hi Daan, > > > > My take on things is to add a network offerin

Re: Handling Public network traffic in a plugin

2013-09-04 Thread Dave Cahill
nd you > with public ones. > > In general the extensibility of net-implementations does need some > work. replacing the guru does not seem like the way to go to me. I'd > say that the offer is what drives what guru/element to use. > > regards, > Daan > > On Tue, Sep 3, 2013

Re: Review Request 13934: CLOUDSTACK-4347 provisioning of a nicira based vpc router

2013-09-04 Thread Dave Cahill
avoid the high ratio of whitespace changes? This one is about 99% whitespace changes, which makes it extremely hard to see what has actually changed. - Dave Cahill On Sept. 2, 2013, 2:53 p.m., daan Hoogland wrote: > > --- > T

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-09-03 Thread Dave Cahill
Port Forwarding. Thanks, Dave Cahill

Handling Public network traffic in a plugin

2013-09-03 Thread Dave Cahill
Hi, A few months back I mailed the list to explain how (and why) the MidoNet plugin handles Public traffic as well as Guest traffic - see [1] for details. Essentially, we plug the System VMs into the virtual network the same way we plug in guest VMs, and the virtual network takes care of all routi

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-29 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13771/#review25724 --- Ship it! LGTM. - Dave Cahill On Aug. 28, 2013, 2:37 p.m., daan

Re: [VOTE] Apache Cloudstack 4.2.0

2013-08-27 Thread Dave Cahill
nd it would be better if you use git-format-patch to generate patch. > > Thanks! > > --Sheng > > > On Mon, Aug 26, 2013 at 5:00 PM, Dave Cahill wrote: > > > Hi Sheng, > > > > Thanks for reviewing. > > > > The name change is also necessary

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Dave Cahill
.java 9023c6e Diff: https://reviews.apache.org/r/13759/diff/ Testing --- Removed Maven cache (rm -rf ~/.m2/repository) and built successfully, tests passed. Spun up several networks and VMs, tested ping to outside, ping VM to VM, DHCP, Source NAT, Static NAT, Port Forwarding. Thanks, Dave Cahill

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Dave Cahill
d e-mail. To reply, visit: https://reviews.apache.org/r/13759/#review25630 ------- On Aug. 23, 2013, 11:31 a.m., Dave Cahill wrote: > > --- > This is an automatically g

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-27 Thread Dave Cahill
confusing. This 200 line patch was significantly easier to review than the previous 10k line version. :) - Dave Cahill On Aug. 27, 2013, 11:36 a.m., daan Hoogland wrote: > > --

Re: [VOTE] Apache Cloudstack 4.2.0

2013-08-26 Thread Dave Cahill
gt; I've taken a look at the patch. The dhcp capability fix is pretty simple, > but the name changing part involved much more modifications. Can the name > change done after 4.2? It should reduce the patch size a lot. > > --Sheng > > > On Mon, Aug 26, 2013 at 4:24 PM,

Re: [VOTE] Apache Cloudstack 4.2.0

2013-08-26 Thread Dave Cahill
Hi, I reported CLOUDSTACK-4466 4 days ago and submitted a patch. It's restricted to plugin code, so should be a simple and isolated change to grab. Although my vote would be non-binding, I would be -1 without the change, as it fixes DHCP functionality which was broken by a recent commit in core c

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-26 Thread Dave Cahill
Get well soon! On Mon, Aug 26, 2013 at 3:48 PM, Daan Hoogland wrote: > You are right, I incorporated Alex' auto format for eclipse. Sorry for > that. Being sick at home today, I will try to submit an update without it > tomorrow. > > regards, > > > > On Mon, Aug

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-25 Thread Dave Cahill
rg/r/13771/ >> Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Hugo >> Trippaers, and Sheng Yang. >> By daan Hoogland. >> *Bugs: * CLOUDSTACK-4346 >> *Repository: * cloudstack-git >> Description >> >> After global search and replace all cal

Re: [VOTE] Apache Cloudstack 4.2.0

2013-08-23 Thread Dave Cahill
IIRC, our bylaws don't state any problems with the 72-hour voting window being on a weekend. However, doesn't this window essentially leave one business day for people to test the RC?

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-23 Thread Dave Cahill
s and VMs, tested ping to outside, ping VM to VM, DHCP, Source NAT, Static NAT, Port Forwarding. Thanks, Dave Cahill

Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-22 Thread Dave Cahill
ource NAT, Static NAT, Port Forwarding. Thanks, Dave Cahill

Re: Source NAT not applied on network startup (See Jira CLOUDSTACK-234)

2013-08-22 Thread Dave Cahill
Sounds great Murali, thanks for the quick response! On Thu, Aug 22, 2013 at 10:42 PM, Murali Reddy wrote: > > I made a commit in 4.2-forward, will wait for BVT to run before raising a > pull request to 4.2. > > On 22/08/13 12:12 PM, "Dave Cahill" wrote: > > >

Re: Source NAT not applied on network startup (See Jira CLOUDSTACK-234)

2013-08-21 Thread Dave Cahill
Adding Chiradeep for guidance, as Murali seems to be away at the moment. Prasanna kindly verified that this is an issue with Virtual Router as well as MidoNet, so I have filed a bug against 4.2: https://issues.apache.org/jira/browse/CLOUDSTACK-4442 On Thu, Aug 22, 2013 at 12:10 PM, Dave Cahill

Re: Source NAT not applied on network startup (See Jira CLOUDSTACK-234)

2013-08-21 Thread Dave Cahill
Also, I tried to find the code review for this change, but couldn't track it down - could someone point me to it? On Thu, Aug 22, 2013 at 10:26 AM, Dave Cahill wrote: > Hi Murali, > > After this change [1], how do Source NAT IPs get applied to a network on > network startup

Source NAT not applied on network startup (See Jira CLOUDSTACK-234)

2013-08-21 Thread Dave Cahill
Hi Murali, After this change [1], how do Source NAT IPs get applied to a network on network startup / first VM launch? Previously, applyIpAssociations would get called as part of reprogramNetworkRules, but this change introduces what it calls "a lazy approach". From what I can see, this means tha

Re: cs-maven.midokura.com is down ?

2013-08-21 Thread Dave Cahill
pointers on the publication process? Thanks, Dave. 2013年8月21日水曜日 Chip Childers chip.child...@sungard.com: > Dave, > > Any chance you can get the midokura jars published to maven central? > > On Wed, Aug 21, 2013 at 06:13:11PM +0900, Dave Cahill wrote: > > Hi, > > >

Re: cs-maven.midokura.com is down ?

2013-08-21 Thread Dave Cahill
ery complex and time consuming. Thanks, Dave. On Wed, Aug 21, 2013 at 5:40 PM, Dave Cahill wrote: > Hi, > > Looks like I'm receiving cloudstack-dev mails delayed; thanks for the > heads-up Prasanna. > > cs-maven.midokura.com seems to be up and working from here - I've cleare

Re: cs-maven.midokura.com is down ?

2013-08-21 Thread Dave Cahill
Hi, Looks like I'm receiving cloudstack-dev mails delayed; thanks for the heads-up Prasanna. cs-maven.midokura.com seems to be up and working from here - I've cleared my local cache and am rebuilding 4.2 to make sure. Rayees, what error are you getting exactly? Thanks, Dave. On Wed, Aug 21,

Re: [ANNOUNCE] New Committer: Toshiaki Hatano

2013-08-19 Thread Dave Cahill
Congratulations Toshiaki! On Tue, Aug 20, 2013 at 7:56 AM, Marcus Sorensen wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Toshiaki Hatano to become a committer and we are pleased > to announce that he has accepted. > > Being a committer enables easier contribut

Re: Build failure in 4.2 with Midokura Midonet

2013-08-14 Thread Dave Cahill
t; >> > > >> > mvn install > >> > > >> > then I ran > >> > > >> > mvn clean install > >> > > >> > and that fixed it. > >> > > >> > > >> > On Tue, Aug 13, 2013 at 2:40 PM, Wei ZHOU &

Re: Build failure in 4.2 with Midokura Midonet

2013-08-12 Thread Dave Cahill
Hi Mike, I'm not seeing any failures with the latest 4.2. It sounds like the failure you were seeing was intermittent, so if it crops up again, just paste in some more logs and I'll take a look. Thanks, Dave. On Tue, Aug 13, 2013 at 8:15 AM, Dave Cahill wrote: > Hi Mike, >

Re: Build failure in 4.2 with Midokura Midonet

2013-08-12 Thread Dave Cahill
Hi Mike, If you get a failure like this, Maven should also print out more details on the cause - could you paste those? 4.2 was building fine for me yesterday, but I'll take a look and see if something has changed since. Thanks for the heads up, Dave. 2013年8月13日火曜日 Mike Tutkowski mike.tutkow...

Re: Review Request 13491: Fix specifying db passwd in cloud-install-sys-tmplt

2013-08-12 Thread Dave Cahill
On August 12th, 2013, 8:59 a.m. UTC, *Hugo Trippaers* wrote: > > Ship It! > > master 062eab8df44ba76dad28800599d87ef131bb0bec > 4.2 9d053d04ecd08ca3ae7cbf6d6530cf96c3007687 > > > - Hugo > > On August 12th, 2013, 7:14 a.m. UTC, Dave Cahill wrote: > Review reques

Review Request 13491: Fix specifying db passwd in cloud-install-sys-tmplt

2013-08-12 Thread Dave Cahill
--- Tested installing System VM template using the script and specifying db username / pass before change (didn't work) and after (worked). Thanks, Dave Cahill

Re: Master build failure

2013-08-08 Thread Dave Cahill
ssing. Thanks for reverting. Will > fix. > > > > I still don't understand why we have problems with Gerrit. It would > have prevented exactly this type of problems. I know a lot of people are > busy on 4.2. Will bring it up post 4.2 again. > > > > --Alex >

Re: Master build failure

2013-08-08 Thread Dave Cahill
g to fix this and it looks to be intertwined in a > > few commits. Large swaths of code has moved around. I'll revert to > > last known state from Jenkins if we can't figure out a simple fix so > > Dave can proceed. > > > > On Thu, Aug 08, 2013 at 04:11:36

Re: Review Request 13426: Update Maven repo location for MidoNet dependencies

2013-08-08 Thread Dave Cahill
--- On Aug. 8, 2013, 10:05 a.m., Dave Cahill wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13426/ > -

Review Request 13426: Update Maven repo location for MidoNet dependencies

2013-08-08 Thread Dave Cahill
--- Nuked local Maven cache with: rm -rf ~/.m2/repository Ran full build, successful: mvn clean install -P developer,systemvm -DskipTests Thanks, Dave Cahill

Review Request 13425: Update Maven repo location for MidoNet dependencies

2013-08-08 Thread Dave Cahill
cache with: rm -rf ~/.m2/repository Ran full build, successful: mvn clean install -P developer,systemvm -DskipTests Thanks, Dave Cahill

Re: Master build failure

2013-08-08 Thread Dave Cahill
:4.3.0-SNAPSHOT: Could not find artifact org.apache.cloudstack:cloud-framework-config:jar:4.3.0-SNAPSHOT in Nexus (http://repository.apache.org/snapshots) Thanks, Dave. On Thu, Aug 8, 2013 at 3:53 PM, Dave Cahill wrote: > Hi, > > I'm seeing a build failure with master - I'v

Master build failure

2013-08-07 Thread Dave Cahill
Hi, I'm seeing a build failure with master - I've checked the usual gotchas, but this seems to be something else. Possibly related to the 4.2.0 to 4.3.0 update? The missing dependency is cloud-engine-compute. It's listed as a dependency in engine/service/pom.xml with no "type" specified, which AF

Re: Review Board messages

2013-08-07 Thread Dave Cahill
line, > > > > the mail being archived at markmail is still the incubator list > > > > On Thu, Aug 8, 2013 at 3:14 AM, Dave Cahill > wrote: > > > Hi, > > > > > > I noticed that Review Board messages are still going to > > &

Review Board messages

2013-08-07 Thread Dave Cahill
Hi, I noticed that Review Board messages are still going to cloudstack-...@incubator.apache.org. Should we switch that to dev@cloudstack.apache.org ? If so, who has the access to do so? Thanks, Dave.

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-07 Thread Dave Cahill
this should be "of broadcasttype lswitch". api/test/com/cloud/network/NetworksTest.java <https://reviews.apache.org/r/12849/#comment48906> Not important, but I think this should be "of broadcasttype mido". - Dave Cahill On Aug. 7

Re: Help needed with Cloudstack Setup

2013-08-07 Thread Dave Cahill
> | > | > http://download.cloud.com/templates/4.2/systemvmtemplate-2013-06-12-master-kvm.qcow2.bz2| > | http://download.cloud.com/templates/4.2/systemvmtemplate-4.2-vh7.ova > | > > On Wed, Aug 07, 2013 at 04:17:26PM +0900, Dave Cahill wrote: > > Hi Marcus, > >

Re: Help needed with Cloudstack Setup

2013-08-07 Thread Dave Cahill
Hi Marcus, I wonder could we take the most recent Jenkins-built System VM template and get it hosted somewhere, then let people know the URL? We could then replace the old acton systemvm URL [1] with the new URL wherever it appears in docs etc. I'd imagine the template doesn't change all that much

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill
/ > ------- > > (Updated Aug. 6, 2013, 2:25 p.m.) > > > Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, > and Sheng Yang. > > > Repository: cloudstack-git > > > Descriptio

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill
As for the check, this was also added in the July 19 commit - it causes Exceptions on valid input (colons in the value param are valid), which is why I'm proposing we remove it. Hope that explains it - feel free to grab me on IRC for more details if needed. - Dave Cahill On Aug. 6,

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill
3b8d9be958190;hb=2d4464d2badc9aff842fd180bafc4c384a83a91d i.e. return new URI(scheme + "://" + value); Not this: return new URI(value.toString()); - Dave Cahill On Aug. 6, 2013, 10:41 a.m., daan Hoogland wrote: > > --- > This is an

Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill
tps://reviews.apache.org/r/12849/#comment48820> Commenting as discussed on list - I think we should remove the check for contains(":") at this line. We weren't doing it before July 20, it's invalid as per the URI spec, and it breaks existing callers. - Dave Cahill On Aug. 6, 2013, 9:16

Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-08-06 Thread Dave Cahill
Hi, Adding Daan's reply - I sent to the wrong dev@ first time around, so the reply went astray: > On Tue, Aug 6, 2013 at 10:30 AM, Dave Cahill wrote: > > I'm pretty sure the current scheme check is invalid given the URI spec, but > > definitely > > shout if I&#

Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-08-06 Thread Dave Cahill
Hi Daan / Alex, Sorry I missed this change at the time, but it looks problematic to me. The code is trying to check for a scheme part in the incoming value, and doesn't add a scheme if value already has one. Therefore, if the scheme check has a false positive (it thinks the value has a scheme, bu

Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-02 Thread Dave Cahill
Now that we've bumped the version number, do we need to create Upgrade420to430 and add it to engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java ? I ran "mvn -P developer -pl developer,tools/devcloud -Ddeploydb" (from [1]) on a fresh checkout of master and got: [ERROR] Failed to execu

Re: MidoNetElementTest Issue

2013-05-20 Thread Dave Cahill
Hi, Mike - thanks for the heads up! I did an mvn clean install test and couldn't see the warning, but your change certainly makes sense. Pranav - I made the change and submitted to ReviewBoard with you marked as a reviewer:* *https://reviews.apache.org/r/11232/ Thanks, Dave. On Sat, May 18, 20

Review Request: Add package declaration to MidoNetElementTest

2013-05-20 Thread Dave Cahill
essage/s2z42w5tfl5x7h6c Diffs - plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java baf99b9 Diff: https://reviews.apache.org/r/11232/diff/ Testing --- Change affects only a test file; ran test suite before and after. Thanks, Dave Cahill

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-05-06 Thread Dave Cahill
Like > > Setting Name. The same comment applies > > throughout the doc here. > > Dave Cahill wrote: > Wouldn't Publican fail to build on DTD errors? > > Running this command successfully builds the doc for me: > publican build --config=publican-plu

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-04-30 Thread Dave Cahill
Like > > Setting Name. The same comment applies > > throughout the doc here. > > Dave Cahill wrote: > Wouldn't Publican fail to build on DTD errors? > > Running this command successfully builds the doc for me: > publican build --config=publican-plug

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-04-30 Thread Dave Cahill
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10136/#review19943 ------- On April 30, 2013, 5:22 a.m., Dave Cahill wrote: > >

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-04-29 Thread Dave Cahill
/r/10136/diff/ Testing --- Built docs. Thanks, Dave Cahill

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-04-29 Thread Dave Cahill
-CREATION docs/publican-plugin-midonet.cfg PRE-CREATION Diff: https://reviews.apache.org/r/10136/diff/ Testing --- Built docs. Thanks, Dave Cahill

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-04-23 Thread Dave Cahill
Hi, Pinging this review to avoid it getting lost - I think all comments have been addressed. Thanks, Dave. On Fri, Apr 19, 2013 at 5:35 PM, Dave Cahill wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10136/ > Review re

Re: New PMC Member: Prasanna Santhanam

2013-04-22 Thread Dave Cahill
Congrats Prasanna, much deserved. :) Dave. On Tue, Apr 23, 2013 at 2:23 PM, Devdeep Singh wrote: > Congrats Prasanna. > > Regards, > Devdeep > > > -Original Message- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Monday, April 22, 2013 9:21 PM > > To: dev@cloudstac

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-04-19 Thread Dave Cahill
ATION docs/publican-plugin-midonet.cfg PRE-CREATION Diff: https://reviews.apache.org/r/10136/diff/ Testing --- Built docs. Thanks, Dave Cahill

CloudStack Chef Cookbooks

2013-04-10 Thread Dave Cahill
Hi all, There was a conversation on the mailing list back in February which touched on Chef cookbooks for CloudStack [1], but I think the links given were mainly for Knife plugins to use CloudStack APIs. Does anyone know of Chef cookbooks for installing CloudStack? Thanks, Dave. [1] http://mark

Re: Master - jetty run failure

2013-04-03 Thread Dave Cahill
Hi, Apologies for not responding more quickly; I'm a non-committer, so I was actually offline when the patch hit master. I think the behavior Likitha observed would happen if a developer updated to latest master, and started the management server, but didn't redeploy the management server databas

Re: RAT test failing in master

2013-04-03 Thread Dave Cahill
Date: Wed Apr 3 20:33:25 2013 +0100 > > Correcting missing license headers in two MidoNet plugin files > > Signed-off-by: Chip Childers > > > > > > > > > $ git log > plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetwor

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-04-02 Thread Dave Cahill
guessing you're the only one actively looking at this at the moment. On Fri, Mar 29, 2013 at 11:37 PM, Dave Cahill wrote: > Sounds great, thanks Hugo! > > > On Fri, Mar 29, 2013 at 8:47 PM, Hugo Trippaers < > htrippa...@schubergphilis.com> wrote: > >> Hey Dave

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-29 Thread Dave Cahill
t; Cheers, > > Hugo > > Sent from my iPhone > > On 29 mrt. 2013, at 02:17, "Dave Cahill" wrote: > > Hi all, > > I think all review comments have been addressed on this, but review > progress seems to have stalled - anything I should be doing to keep things

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-28 Thread Dave Cahill
Hi all, I think all review comments have been addressed on this, but review progress seems to have stalled - anything I should be doing to keep things moving? Thanks, Dave. On Wed, Mar 27, 2013 at 3:33 PM, Dave Cahill wrote: >This is an automatically generated e-mail. To reply, vi

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread Dave Cahill
d server/src/com/cloud/network/NetworkManagerImpl.java b1236cc ui/scripts/system.js c0a5d14 Diff: https://reviews.apache.org/r/9898/diff/ Testing --- Built and deployed, spun up Advanced Isolated network with two VMs, verified internal and external connectivity via MidoNet. Thanks, Dave Cahill

Re: Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-03-26 Thread Dave Cahill
/en-US/plugin-midonet-usage.xml PRE-CREATION docs/publican-plugin-midonet.cfg PRE-CREATION Diff: https://reviews.apache.org/r/10136/diff/ Testing --- Built docs. Thanks, Dave Cahill

Review Request: Add docs for MidoNet networking plugin [CLOUDSTACK-996]

2013-03-26 Thread Dave Cahill
/ Testing --- Built docs. Thanks, Dave Cahill

Re: New committer: Hiroaki Kawai

2013-03-25 Thread Dave Cahill
Congrats Kawai-san! On Tue, Mar 26, 2013 at 3:37 AM, Ahmad Emneina wrote: > Congratulations Kawai-san! > > > On Mon, Mar 25, 2013 at 9:54 AM, Alena Prokharchyk < > alena.prokharc...@citrix.com> wrote: > > > Kawai-san, congratulations! > > > > On 3/25/13 6:39 AM, "David Nalley" wrote: > > > > >

Review Request: Fix for CLOUDSTACK-1797 - System VMs and VRs don't display in master

2013-03-25 Thread Dave Cahill
/10116/diff/ Testing --- Tested on a deployment with 2 system VMs and 1 VR . Showed blank before fix, showed as expected after fix. Thanks, Dave Cahill

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-24 Thread Dave Cahill
Isolated network with two VMs, verified internal and external connectivity via MidoNet. Thanks, Dave Cahill