Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2007-12-06 Thread Jack Vogel
On Dec 6, 2007 5:06 PM, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-12-07 01:06:42 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/em if_em.c if_em.h > Log: > MFC of a few important fixes done in RELENG_7 to 6 > - WITNE

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2007-11-06 Thread Jack Vogel
On 11/6/07, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-11-07 01:33:29 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/em if_em.c if_em.h > Log: > This delta addresses some users experiencing watchdogs under load with > t

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2007-09-18 Thread Giorgos Keramidas
On 2007-09-10 21:50, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-09-10 21:50:40 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c if_em.h > Log: > A number of small fixes: > - duplicate #define in header, thanks to Kevin Lo for pointing o

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-11-10 Thread Jack Vogel
On 11/10/06, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: Jack, On Fri, Nov 10, 2006 at 09:30:27AM +, Jack F Vogel wrote: J> jfv 2006-11-10 09:30:27 UTC J> J> FreeBSD src repository J> J> Modified files:(Branch: RELENG_6) J> sys/dev/em if_em.c if_em.h J> Log

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-11-10 Thread Gleb Smirnoff
Jack, On Fri, Nov 10, 2006 at 09:30:27AM +, Jack F Vogel wrote: J> jfv 2006-11-10 09:30:27 UTC J> J> FreeBSD src repository J> J> Modified files:(Branch: RELENG_6) J> sys/dev/em if_em.c if_em.h J> Log: J> This patch redesigns the watchdog timer. The o

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Gleb Smirnoff
On Sat, Oct 28, 2006 at 10:06:21AM -0700, Jack Vogel wrote: J> >J> jfv 2006-10-28 00:47:55 UTC J> >J> J> >J> FreeBSD src repository J> >J> J> >J> Modified files: J> >J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J> >J> if_em_osdep.h J> >J>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Jack Vogel
On 10/28/06, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: On Sat, Oct 28, 2006 at 12:47:55AM +, Jack F Vogel wrote: J> jfv 2006-10-28 00:47:55 UTC J> J> FreeBSD src repository J> J> Modified files: J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Gleb Smirnoff
On Sat, Oct 28, 2006 at 12:47:55AM +, Jack F Vogel wrote: J> jfv 2006-10-28 00:47:55 UTC J> J> FreeBSD src repository J> J> Modified files: J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J> if_em_osdep.h J> Log: J> This is the merg

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Jack Vogel
On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: "Jack Vogel" <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: jf> > Jack F Vogel <[EMAIL PROTECTED]> wrote jf> > in <[EMAIL PROTECTED]>: jf> > jf> > jf> jfv 2006-10-28 01:37:1

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Hiroki Sato
"Jack Vogel" <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: jf> > Jack F Vogel <[EMAIL PROTECTED]> wrote jf> > in <[EMAIL PROTECTED]>: jf> > jf> > jf> jfv 2006-10-28 01:37:14 UTC jf> > jf> jf> > jf> FreeBSD src repository jf>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Jack Vogel
On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: Jack F Vogel <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> jfv 2006-10-28 01:37:14 UTC jf> jf> FreeBSD src repository jf> jf> Modified files:(Branch: RELENG_6) jf> sys/dev/em if_em.c if_em.h if_em_hw.

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Hiroki Sato
Jack F Vogel <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> jfv 2006-10-28 01:37:14 UTC jf> jf> FreeBSD src repository jf> jf> Modified files:(Branch: RELENG_6) jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h jf> if_em_osdep.

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-09-09 Thread Prafulla Deuskar
Max Laier [EMAIL PROTECTED] wrote: > On Saturday 09 September 2006 08:19, Prafulla Deuskar wrote: > > pdeuskar2006-09-09 06:19:20 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Add support for TSO. Thanks to Andre for

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-09-09 Thread Max Laier
On Saturday 09 September 2006 08:19, Prafulla Deuskar wrote: > pdeuskar2006-09-09 06:19:20 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c if_em.h > Log: > Add support for TSO. Thanks to Andre for adding support in the stack > and Jack Vogel for d

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-24 Thread Matt Reimer
On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: yongari 2006-08-14 01:50:54 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Overhaul Rx path to recover from mbuf cluster allocation failure. o Create one more spare DMA map for Rx hand

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-15 Thread Matt Reimer
On 8/15/06, John Baldwin <[EMAIL PROTECTED]> wrote: On Tuesday 15 August 2006 02:49, Pyun YongHyeon wrote: > On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > > >yongari 2006-08-14 01:50:54 UTC > > > > > > FreeBSD src

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-15 Thread John Baldwin
On Tuesday 15 August 2006 02:49, Pyun YongHyeon wrote: > On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > > >yongari 2006-08-14 01:50:54 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > >s

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-14 Thread Pyun YongHyeon
On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > >yongari 2006-08-14 01:50:54 UTC > > > > FreeBSD src repository > > > > Modified files: > >sys/dev/em if_em.c if_em.h > > Log: > > Overhaul Rx path t

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-14 Thread John Baldwin
On Monday 14 August 2006 16:30, Matt Reimer wrote: > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > > yongari 2006-08-14 01:50:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Overhaul Rx path to recover fro

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-14 Thread Matt Reimer
On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: yongari 2006-08-14 01:50:54 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Overhaul Rx path to recover from mbuf cluster allocation failure. o Create one more spare DMA map for Rx hand

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-08 Thread Yar Tikhiy
On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote: > > P> Is there a report on what coverty found with if_em_hw.c? > > Coverity complains that the return value of em_read_phy_reg() is > somtimes checked and sometimes is not. Can you please tell, whether > this is important report or c

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-07 Thread Gleb Smirnoff
On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote: T> On Fri, Aug 04, 2006 at 04:21:49PM +, Prafulla Deuskar wrote: T> P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon? T> P> T> P> Jack Vogel is doing the merge - I will send it out to you for review. T> P> So let

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-07 Thread Gleb Smirnoff
Prafulla, On Fri, Aug 04, 2006 at 04:21:49PM +, Prafulla Deuskar wrote: P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon? P> P> Jack Vogel is doing the merge - I will send it out to you for review. P> So let us plan on committing early next week? The merge is very simple

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Prafulla Deuskar
Andre Oppermann [EMAIL PROTECTED] wrote: > Prafulla Deuskar wrote: > >Gleb Smirnoff [EMAIL PROTECTED] wrote: > >> Prafulla, > >> > >>On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: > >>P> pdeuskar2006-08-03 19:05:05 UTC > >>P> > >>P> FreeBSD src repository > >>P> > >>P>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Prafulla Deuskar
Gleb Smirnoff [EMAIL PROTECTED] wrote: > On Fri, Aug 04, 2006 at 02:38:25PM +, Prafulla Deuskar wrote: > P> > P> Revert back changes to made in rev 1.109 of if_em.c which were > unnecessary. > P> > P> This makes it easier for us to get the changes into -current and to > -stable quickly. >

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Warner Losh
From: Gleb Smirnoff <[EMAIL PROTECTED]> Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 4 Aug 2006 13:54:14 +0400 > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: > P> pdeuskar2006-08-03 19:05:05 UTC > P> &g

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Warner Losh
From: Colin Percival <[EMAIL PROTECTED]> Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 04 Aug 2006 01:14:54 -0700 > Yar Tikhiy wrote: > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > > FWIW, the following files in 6.1-

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Andre Oppermann
Prafulla Deuskar wrote: Gleb Smirnoff [EMAIL PROTECTED] wrote: Prafulla, On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: P> pdeuskar2006-08-03 19:05:05 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c if_em.h P> Log: P>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread John Baldwin
On Friday 04 August 2006 03:46, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual co

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Gleb Smirnoff
On Fri, Aug 04, 2006 at 02:38:25PM +, Prafulla Deuskar wrote: P> > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. P> > P> This makes it easier for us to get the changes into -current and to -stable quickly. P> > P> > Can you please confirm that this was a

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Wilko Bulte
On Fri, Aug 04, 2006 at 12:49:09AM -0700, Colin Percival wrote.. > Yar Tikhiy wrote: > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > With md5(1), you can only 99.94579% verify it. :-)

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Prafulla Deuskar
Gleb Smirnoff [EMAIL PROTECTED] wrote: > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: > P> pdeuskar2006-08-03 19:05:05 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c if_em.h > P> Log: > P> Rev

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Gleb Smirnoff
Prafulla, On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: P> pdeuskar2006-08-03 19:05:05 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c if_em.h P> Log: P> Revert back changes to made in rev 1.109 of if_em.c which were u

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Stefan Farfeleder
On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Colin Percival
Yar Tikhiy wrote: > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. FWIW, the following files in 6.1-RELEASE/i386 contain build timestamps: /boot/GENERIC/hptmv.ko /boot/GENERIC/kernel /boot/SMP/hptmv.ko /boot/SMP/kernel /boot/loader /boot/pxeboot /etc/mail/freebsd.cf /etc/mail

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 12:49:09AM -0700, Colin Percival wrote: > Yar Tikhiy wrote: > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > With md5(1), you can only 99.94579% verify it. :-)

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 09:52:31AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > > > As a general rem

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Colin Percival
Yar Tikhiy wrote: > Changing style(9) shouldn't alter the binary code produced, and > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). With md5(1), you can only 99.94579% verify it. :-) Colin Percival ___ cvs-all@fr

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > As a general remark, it is a very good idea to keep large style(9) > > sweeps separate from actual code changes even if they are tiny. > > Changing style(9) shou

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Stefan Farfeleder
On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > As a general remark, it is a very good idea to keep large style(9) > sweeps separate from actual code changes even if they are tiny. > Changing style(9) shouldn't alter the binary code produced, and > this can be 100% verified using c

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 01:25:14AM +, John Birrell wrote: > On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > > Prafulla Deuskar wrote: > > > Modified files: > > > sys/dev/em if_em.c if_em.h > > > Log: > > > Revert back changes to made in rev 1.109 of if_em.

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-03 Thread John Birrell
On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > Prafulla Deuskar wrote: > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Revert back changes to made in rev 1.109 of if_em.c which were > > unnecessary. > > This makes it easier for us to get th

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-03 Thread Colin Percival
Prafulla Deuskar wrote: > Modified files: > sys/dev/em if_em.c if_em.h > Log: > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > This makes it easier for us to get the changes into -current and to -stable > quickly. I assume you've discussed thi

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Scott Long
Nate Lawson wrote: Scott Long wrote: Andrew Gallatin wrote: Scott Long writes: > However, taskqueues are really just a proof of concept for what I really > want, which is to allow drivers to register both a fast handler and an > ithread handler. For drivers doing this, the ithread would

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Andrew Gallatin
Nate Lawson writes: > Scott Long wrote: > > Andrew Gallatin wrote: > > > >> Scott Long writes: > >> > However, taskqueues are really just a proof of concept for what I > >> really > >> > want, which is to allow drivers to register both a fast handler and an > >> > ithread handler. Fo

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Nate Lawson
Scott Long wrote: Andrew Gallatin wrote: Scott Long writes: > However, taskqueues are really just a proof of concept for what I really > want, which is to allow drivers to register both a fast handler and an > ithread handler. For drivers doing this, the ithread would be private Ah, the

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Scott Long
Andrew Gallatin wrote: Scott Long writes: > > Touching the APIC is tricky. First, you have to pay the cost of a > spinlock. Then you have to may the cost of at least one read and write > across the FSB. Even though the APIC registers are memory mapped, they > are still uncached. It's

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Andrew Gallatin
Scott Long writes: > > Touching the APIC is tricky. First, you have to pay the cost of a > spinlock. Then you have to may the cost of at least one read and write > across the FSB. Even though the APIC registers are memory mapped, they > are still uncached. It's not terribly expensive,

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Scott Long
Andrew Gallatin wrote: Scott Long [EMAIL PROTECTED] wrote: scottl 2006-01-11 00:30:25 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Significant performance improvements for the if_em driver: Very cool. - If possible, use a fast inter

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-01-12 Thread Andrew Gallatin
Scott Long [EMAIL PROTECTED] wrote: > scottl 2006-01-11 00:30:25 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c if_em.h > Log: > Significant performance improvements for the if_em driver: Very cool. > - If possible, use a fast interupt hand