On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote:
Jack F Vogel <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>:jf> jfv 2006-10-28 01:37:14 UTC jf> jf> FreeBSD src repository jf> jf> Modified files: (Branch: RELENG_6) jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h jf> if_em_osdep.h jf> Log: jf> Merge of Intel 6.2.9 em driver code. jf> Approved by: re, scottl, jhb, pdeuskar jf> jf> Revision Changes Path jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h Just wanted to make sure, but is the following change in if_em.c really intentional? This means that the new version no longer supports 82542... Index: if_em.c @@ -116,8 +117,6 @@ { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, - { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0},
Yes that was intentional, its an ID that the Intel source has not had for some time. When I put it back in our source a while back due to a merge our test group came to me and said these adapters dont even work with the driver, so clearly no one is using them :) I asked about dropping the ID to a set of developers and got the OK to drop it. If someone actually speaks up about having hardware that was working and now is broken I'll take it all back and we can put the ID back in, is that good enough? :) Cheers, Jack _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
