From: Gleb Smirnoff <[EMAIL PROTECTED]> Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 4 Aug 2006 13:54:14 +0400
> Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: > P> pdeuskar 2006-08-03 19:05:05 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c if_em.h > P> Log: > P> Revert back changes to made in rev 1.109 of if_em.c which were > unnecessary. > P> This makes it easier for us to get the changes into -current and to > -stable quickly. > > Can you please confirm that this was a mechanical substitution like this: > > s/sc/adapter/g > s/em_softc/adapter/g > > and no more additional changes? If this is true, then I hope that we > (FreeBSD and Intel) have finally came to a common codebase. This is good. :) > I can stand the long unusual name for driver softc with no problems. That's what my eyeball of the patch showed. > I'm only a bit disappointed by the fact, that I haven't received a single > email about these plans. You were in the void for a long time, and > then began your work with a commit, w/o informing people who were > maintaining driver while the vendor maintanance was on a hiatus. You can blame that last part. Prafulla had sent several versions of the patch to me for review. I had gotten the mistaken impression that you were not longer interested in em (which appears to be in error), so I didn't have him bounce them off of you first. Please accept my appologies for not suggesting you be in the loop more. I gave him my signoff on the patch a few hours after you commited to em, but I didn't notice this until after he'd committed (gotta love qwest, nuf said). I soon realized my mistake, and would like to offer a public appology for it. Warner _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
