Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2007-12-06 Thread Jack Vogel
On Dec 6, 2007 5:06 PM, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-12-07 01:06:42 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/em if_em.c if_em.h > Log: > MFC of a few important fixes done in RELENG_7 to 6 > - WITNE

Re: cvs commit: src/sys/dev/em if_em.c

2007-11-28 Thread Olivier Houchard
On Wed, Nov 28, 2007 at 11:04:12PM +, Jack F Vogel wrote: > jfv 2007-11-28 23:04:12 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Add COHERENT to descriptor mem allocation for the > benefit of ARM (request from Olivier Houcha

Re: cvs commit: src/sys/dev/em if_em.c

2007-11-26 Thread Attilio Rao
2007/11/26, Jack F Vogel <[EMAIL PROTECTED]>: > jfv 2007-11-26 19:47:03 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Fix for a reported panic in certain circumstances. When > calling em_stop() now make sure the TX lock is held as >

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2007-11-06 Thread Jack Vogel
On 11/6/07, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-11-07 01:33:29 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/em if_em.c if_em.h > Log: > This delta addresses some users experiencing watchdogs under load with > t

Re: cvs commit: src/sys/dev/em if_em.c

2007-10-06 Thread Jack Vogel
On 10/6/07, Mike Tancsa <[EMAIL PROTECTED]> wrote: > At 03:36 PM 10/6/2007, Jack F Vogel wrote: > >jfv 2007-10-06 19:36:35 UTC > > > > FreeBSD src repository > > > > Modified files:(Branch: RELENG_6) > > sys/dev/em if_em.c > > Log: > > Couple corrections on the

Re: cvs commit: src/sys/dev/em if_em.c

2007-10-06 Thread Mike Tancsa
At 03:36 PM 10/6/2007, Jack F Vogel wrote: jfv 2007-10-06 19:36:35 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/dev/em if_em.c Log: Couple corrections on the MFC, first POLLING had a 7.0 interface left in, thanks to those that caught t

Re: cvs commit: src/sys/dev/em if_em.c

2007-10-06 Thread Jack Vogel
On 10/6/07, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-10-06 19:36:35 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/em if_em.c > Log: > Couple corrections on the MFC, first POLLING had a 7.0 > interface left in, thanks

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2007-09-18 Thread Giorgos Keramidas
On 2007-09-10 21:50, Jack F Vogel <[EMAIL PROTECTED]> wrote: > jfv 2007-09-10 21:50:40 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c if_em.h > Log: > A number of small fixes: > - duplicate #define in header, thanks to Kevin Lo for pointing o

Re: cvs commit: src/sys/dev/em if_em.c

2007-05-24 Thread Pyun YongHyeon
On Thu, May 24, 2007 at 06:11:11PM +, Jack F Vogel wrote: > jfv 2007-05-24 18:11:11 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Fix for PR 112937, thanks to Ruslan Ermilov. I am still > a bit confused how the 'link

Re: cvs commit: src/sys/dev/em if_em.c src/sys/net ethernet.h if_ethersubr.c

2007-03-01 Thread Bruce M. Simpson
Christian S.J. Peron wrote: Log: MFC ether_vlan_mtap and modifications to em(4) which remove the promisc mode hack while vlan hardware tag processing is enabled. This is lovely jubflakes. Thank you. However, I have been seeing mbuf corruption with the 802.1p patches, which would benef

Re: cvs commit: src/sys/dev/em if_em.c

2007-02-28 Thread Ruslan Ermilov
On Wed, Feb 28, 2007 at 05:48:08PM +0100, Paolo Pisati wrote: > On Wed, Feb 28, 2007 at 07:57:27AM -0700, Scott Long wrote: > [snip] > > Guys, > > i made a mess with the commit at first so the consequent confusion was > understandable: i've already sent a patch to ru@ (who's mdoc police > BTW) w

Re: cvs commit: src/sys/dev/em if_em.c

2007-02-28 Thread Paolo Pisati
On Wed, Feb 28, 2007 at 07:57:27AM -0700, Scott Long wrote: [snip] Guys, i made a mess with the commit at first so the consequent confusion was understandable: i've already sent a patch to ru@ (who's mdoc police BTW) with an updated bus_setup_intr() man page, he replied and we cleared the situat

Re: cvs commit: src/sys/dev/em if_em.c

2007-02-28 Thread Scott Long
Ruslan, If you were surprised or confused by Paolo's change, then you weren't reading any FreeBSD mail for the last 6 months. Lay off him, he did an excellent job with a very hard task, and he went out of his way to make sure that everyone knew what was going on. He also has been very respons

Re: cvs commit: src/sys/dev/em if_em.c

2007-02-28 Thread Ruslan Ermilov
Paolo, Sorry about that, I've reverted this wrong commit and took back a pointy hat ;), but you'd still better document the API change in the bus_setup_intr(9) manpage, to prevent a possible confusion (I was confused). On Wed, Feb 28, 2007 at 05:29:23AM +, Ruslan Ermilov wrote: > ru

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-11-10 Thread Jack Vogel
On 11/10/06, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: Jack, On Fri, Nov 10, 2006 at 09:30:27AM +, Jack F Vogel wrote: J> jfv 2006-11-10 09:30:27 UTC J> J> FreeBSD src repository J> J> Modified files:(Branch: RELENG_6) J> sys/dev/em if_em.c if_em.h J> Log

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-11-10 Thread Gleb Smirnoff
Jack, On Fri, Nov 10, 2006 at 09:30:27AM +, Jack F Vogel wrote: J> jfv 2006-11-10 09:30:27 UTC J> J> FreeBSD src repository J> J> Modified files:(Branch: RELENG_6) J> sys/dev/em if_em.c if_em.h J> Log: J> This patch redesigns the watchdog timer. The o

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-07 Thread Dag-Erling Smørgrav
Wilko Bulte <[EMAIL PROTECTED]> writes: > On Wed, Nov 01, 2006 at 03:18:54PM -0600, Matthew D. Fuller wrote.. > > "Those responsible for sacking the people who have just been > > sacked, have been sacked." 8-} > fortune file fodder! It's actually a quote from the opening credits of Monty Python a

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-01 Thread Wilko Bulte
On Wed, Nov 01, 2006 at 03:18:54PM -0600, Matthew D. Fuller wrote.. > On Wed, Nov 01, 2006 at 06:24:13PM + I heard the voice of > John Baldwin, and lo! it spake thus: > > > > Log: > > Fix compile botch in the last panic botch fix. :( > > "Those responsible for sacking the people who have j

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-01 Thread Matthew D. Fuller
On Wed, Nov 01, 2006 at 06:24:13PM + I heard the voice of John Baldwin, and lo! it spake thus: > > Log: > Fix compile botch in the last panic botch fix. :( "Those responsible for sacking the people who have just been sacked, have been sacked."8-} -- Matthew Fuller (MF4839) |

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-01 Thread John Baldwin
On Wednesday 01 November 2006 05:46, Gleb Smirnoff wrote: > On Wed, Nov 01, 2006 at 01:19:28PM +0300, Gleb Smirnoff wrote: > T> On Wed, Nov 01, 2006 at 11:05:24AM +0100, Pawel Worach wrote: > T> P> On 10/31/06, John Baldwin <[EMAIL PROTECTED]> wrote: > T> P> >jhb 2006-10-31 17:21:15 UTC > T

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-01 Thread Gleb Smirnoff
On Wed, Nov 01, 2006 at 01:19:28PM +0300, Gleb Smirnoff wrote: T> On Wed, Nov 01, 2006 at 11:05:24AM +0100, Pawel Worach wrote: T> P> On 10/31/06, John Baldwin <[EMAIL PROTECTED]> wrote: T> P> >jhb 2006-10-31 17:21:15 UTC T> P> > T> P> > FreeBSD src repository T> P> > T> P> > Modified fil

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-01 Thread Gleb Smirnoff
On Wed, Nov 01, 2006 at 11:05:24AM +0100, Pawel Worach wrote: P> On 10/31/06, John Baldwin <[EMAIL PROTECTED]> wrote: P> >jhb 2006-10-31 17:21:15 UTC P> > P> > FreeBSD src repository P> > P> > Modified files: P> >sys/dev/em if_em.c P> > Log: P> > Allocate receive and trans

Re: cvs commit: src/sys/dev/em if_em.c

2006-11-01 Thread Pawel Worach
On 10/31/06, John Baldwin <[EMAIL PROTECTED]> wrote: jhb 2006-10-31 17:21:15 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Allocate receive and transmit data structures during attach() and free them Could this be related? em0: port 0x2540-0

Re: cvs commit: src/sys/dev/em if_em.c

2006-10-29 Thread Hiroki Sato
Jack F Vogel <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> jfv 2006-10-29 03:42:39 UTC jf> jf> FreeBSD src repository jf> jf> Modified files:(Branch: RELENG_6) jf> sys/dev/em if_em.c jf> Log: jf> Replace the 82542 device id by popular demand. jf> A

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Gleb Smirnoff
On Sat, Oct 28, 2006 at 10:06:21AM -0700, Jack Vogel wrote: J> >J> jfv 2006-10-28 00:47:55 UTC J> >J> J> >J> FreeBSD src repository J> >J> J> >J> Modified files: J> >J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J> >J> if_em_osdep.h J> >J>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Jack Vogel
On 10/28/06, Gleb Smirnoff <[EMAIL PROTECTED]> wrote: On Sat, Oct 28, 2006 at 12:47:55AM +, Jack F Vogel wrote: J> jfv 2006-10-28 00:47:55 UTC J> J> FreeBSD src repository J> J> Modified files: J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Gleb Smirnoff
On Sat, Oct 28, 2006 at 12:47:55AM +, Jack F Vogel wrote: J> jfv 2006-10-28 00:47:55 UTC J> J> FreeBSD src repository J> J> Modified files: J> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h J> if_em_osdep.h J> Log: J> This is the merg

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Jack Vogel
On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: "Jack Vogel" <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: jf> > Jack F Vogel <[EMAIL PROTECTED]> wrote jf> > in <[EMAIL PROTECTED]>: jf> > jf> > jf> jfv 2006-10-28 01:37:1

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Hiroki Sato
"Jack Vogel" <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: jf> > Jack F Vogel <[EMAIL PROTECTED]> wrote jf> > in <[EMAIL PROTECTED]>: jf> > jf> > jf> jfv 2006-10-28 01:37:14 UTC jf> > jf> jf> > jf> FreeBSD src repository jf>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Jack Vogel
On 10/28/06, Hiroki Sato <[EMAIL PROTECTED]> wrote: Jack F Vogel <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> jfv 2006-10-28 01:37:14 UTC jf> jf> FreeBSD src repository jf> jf> Modified files:(Branch: RELENG_6) jf> sys/dev/em if_em.c if_em.h if_em_hw.

Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h

2006-10-28 Thread Hiroki Sato
Jack F Vogel <[EMAIL PROTECTED]> wrote in <[EMAIL PROTECTED]>: jf> jfv 2006-10-28 01:37:14 UTC jf> jf> FreeBSD src repository jf> jf> Modified files:(Branch: RELENG_6) jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h jf> if_em_osdep.

Re: cvs commit: src/sys/dev/em if_em.c

2006-09-29 Thread John Baldwin
On Friday 29 September 2006 09:47, Andre Oppermann wrote: > andre 2006-09-29 13:47:39 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Remove manual vlan header insertion in em_encap(). It is unnecessary as the > generic vlan_start(

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-09-09 Thread Prafulla Deuskar
Max Laier [EMAIL PROTECTED] wrote: > On Saturday 09 September 2006 08:19, Prafulla Deuskar wrote: > > pdeuskar2006-09-09 06:19:20 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Add support for TSO. Thanks to Andre for

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-09-09 Thread Max Laier
On Saturday 09 September 2006 08:19, Prafulla Deuskar wrote: > pdeuskar2006-09-09 06:19:20 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c if_em.h > Log: > Add support for TSO. Thanks to Andre for adding support in the stack > and Jack Vogel for d

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-24 Thread Matt Reimer
On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: yongari 2006-08-14 01:50:54 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Overhaul Rx path to recover from mbuf cluster allocation failure. o Create one more spare DMA map for Rx hand

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-23 Thread Pyun YongHyeon
On Wed, Aug 23, 2006 at 03:09:11PM +0200, Stefan Bethke wrote: > Am 22.08.2006 um 21:02 schrieb Patrick M. Hausen: > > >em interface, FTPing a large file while putting disk and cpu/memory > >load on the box -> occasional but easily reproducable complete hangs > >of network communication (ssh,

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-23 Thread Stefan Bethke
Am 22.08.2006 um 21:02 schrieb Patrick M. Hausen: em interface, FTPing a large file while putting disk and cpu/memory load on the box -> occasional but easily reproducable complete hangs of network communication (ssh, ping - no reaction). Every time a em0: Missing Tx completion interrupt! is l

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-23 Thread Remko Lodder
Eric Anderson wrote: On 08/23/06 05:10, Gleb Smirnoff wrote: On Tue, Aug 22, 2006 at 01:58:48PM -0500, Eric Anderson wrote: E> Ok. Well, I just recalled that on a separate system (my workstation E> actually), I went from 6.1-R to 6-STABLE as of about 8 days ago, and it E> now exhibits the pro

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-23 Thread Eric Anderson
On 08/23/06 05:10, Gleb Smirnoff wrote: On Tue, Aug 22, 2006 at 01:58:48PM -0500, Eric Anderson wrote: E> Ok. Well, I just recalled that on a separate system (my workstation E> actually), I went from 6.1-R to 6-STABLE as of about 8 days ago, and it E> now exhibits the problem too, which hasn't

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-23 Thread Gleb Smirnoff
On Tue, Aug 22, 2006 at 01:58:48PM -0500, Eric Anderson wrote: E> Ok. Well, I just recalled that on a separate system (my workstation E> actually), I went from 6.1-R to 6-STABLE as of about 8 days ago, and it E> now exhibits the problem too, which hasn't happened before. Can you please show the

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Scott Long
John Polstra wrote: On 23-Aug-2006 Pyun YongHyeon wrote: On Tue, Aug 22, 2006 at 07:23:33PM +0400, Gleb Smirnoff wrote: I think that problem is different one. That problem happens when interrupt is shared with other devices. In these configuration em(4) misses lots of Tx completion interrupts

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread John Polstra
On 23-Aug-2006 Pyun YongHyeon wrote: > On Tue, Aug 22, 2006 at 07:23:33PM +0400, Gleb Smirnoff wrote: > I think that problem is different one. That problem happens when > interrupt is shared with other devices. In these configuration > em(4) misses lots of Tx completion interrupts and devices that

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Pyun YongHyeon
On Tue, Aug 22, 2006 at 07:23:33PM +0400, Gleb Smirnoff wrote: > On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: > P> yongari 2006-08-22 02:32:48 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c > P> Log: > P>

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread John Baldwin
On Tuesday 22 August 2006 16:36, M. Warner Losh wrote: > In message: <[EMAIL PROTECTED]> > Ruslan Ermilov <[EMAIL PROTECTED]> writes: > : It's still a watchdog event. We can make it a separate counter, > : like watchdog_tx_event, and not add it to oerrors, but still show > : it in em_p

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Ruslan Ermilov <[EMAIL PROTECTED]> writes: : It's still a watchdog event. We can make it a separate counter, : like watchdog_tx_event, and not add it to oerrors, but still show : it in em_print_hw_stats(). It'd be useful to have this statistics : availa

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Pav Lucistnik
Eric Anderson píše v út 22. 08. 2006 v 13:58 -0500: > On 08/22/06 13:53, Gleb Smirnoff wrote: > > On Tue, Aug 22, 2006 at 10:35:19AM -0500, Eric Anderson wrote: > > E> >E> >P> yongari 2006-08-22 02:32:48 UTC > > E> >E> >P> > > E> >E> >P> FreeBSD src repository > > E> >E> >P> > > E> >E> >P>

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Patrick M. Hausen
Hi, all! On Tue, Aug 22, 2006 at 10:53:13PM +0400, Gleb Smirnoff wrote: > In 5-STABLE the interface up/down events were not logged, either. OK. But what could be a possible explanation for this: em interface, FTPing a large file while putting disk and cpu/memory load on the box -> occasional bu

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Eric Anderson
On 08/22/06 13:53, Gleb Smirnoff wrote: On Tue, Aug 22, 2006 at 10:35:19AM -0500, Eric Anderson wrote: E> >E> >P> yongari 2006-08-22 02:32:48 UTC E> >E> >P> E> >E> >P> FreeBSD src repository E> >E> >P> E> >E> >P> Modified files: E> >E> >P> sys/dev/em if_em.c E> >E> >P>

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Gleb Smirnoff
On Tue, Aug 22, 2006 at 10:35:19AM -0500, Eric Anderson wrote: E> >E> >P> yongari 2006-08-22 02:32:48 UTC E> >E> >P> E> >E> >P> FreeBSD src repository E> >E> >P> E> >E> >P> Modified files: E> >E> >P> sys/dev/em if_em.c E> >E> >P> Log: E> >E> >P> It seems that em(4) miss

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Eric Anderson
On 08/22/06 10:32, Gleb Smirnoff wrote: On Tue, Aug 22, 2006 at 10:26:02AM -0500, Eric Anderson wrote: E> On 08/22/06 10:23, Gleb Smirnoff wrote: E> >On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: E> >P> yongari 2006-08-22 02:32:48 UTC E> >P> E> >P> FreeBSD src repository

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Gleb Smirnoff
On Tue, Aug 22, 2006 at 10:26:02AM -0500, Eric Anderson wrote: E> On 08/22/06 10:23, Gleb Smirnoff wrote: E> >On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: E> >P> yongari 2006-08-22 02:32:48 UTC E> >P> E> >P> FreeBSD src repository E> >P> E> >P> Modified files: E> >P>

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Eric Anderson
On 08/22/06 10:23, Gleb Smirnoff wrote: On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: P> yongari 2006-08-22 02:32:48 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c P> Log: P> It seems that em(4) misses Tx completion int

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Gleb Smirnoff
On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: P> yongari 2006-08-22 02:32:48 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c P> Log: P> It seems that em(4) misses Tx completion interrupts under certain P> conditions. The

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Ruslan Ermilov
On Tue, Aug 22, 2006 at 06:44:52PM +0900, Pyun YongHyeon wrote: > On Tue, Aug 22, 2006 at 12:22:37PM +0400, Ruslan Ermilov wrote: > > I agree this is a less painful way to recover, but it's still a > > watchdog and it slows down the performance when it happens. After > > this commit, if there's

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Pyun YongHyeon
On Tue, Aug 22, 2006 at 12:22:37PM +0400, Ruslan Ermilov wrote: > Hi Pyun, > > On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: > > yongari 2006-08-22 02:32:48 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c > >

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-22 Thread Ruslan Ermilov
Hi Pyun, On Tue, Aug 22, 2006 at 02:32:48AM +, Pyun YongHyeon wrote: > yongari 2006-08-22 02:32:48 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > It seems that em(4) misses Tx completion interrupts under certain > conditions. The

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-15 Thread Matt Reimer
On 8/15/06, John Baldwin <[EMAIL PROTECTED]> wrote: On Tuesday 15 August 2006 02:49, Pyun YongHyeon wrote: > On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > > >yongari 2006-08-14 01:50:54 UTC > > > > > > FreeBSD src

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-15 Thread John Baldwin
On Tuesday 15 August 2006 02:49, Pyun YongHyeon wrote: > On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > > >yongari 2006-08-14 01:50:54 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > >s

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-14 Thread Pyun YongHyeon
On Mon, Aug 14, 2006 at 01:30:37PM -0700, Matt Reimer wrote: > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > >yongari 2006-08-14 01:50:54 UTC > > > > FreeBSD src repository > > > > Modified files: > >sys/dev/em if_em.c if_em.h > > Log: > > Overhaul Rx path t

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-14 Thread John Baldwin
On Monday 14 August 2006 16:30, Matt Reimer wrote: > On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: > > yongari 2006-08-14 01:50:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Overhaul Rx path to recover fro

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-14 Thread Matt Reimer
On 8/13/06, Pyun YongHyeon <[EMAIL PROTECTED]> wrote: yongari 2006-08-14 01:50:54 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c if_em.h Log: Overhaul Rx path to recover from mbuf cluster allocation failure. o Create one more spare DMA map for Rx hand

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-14 Thread Pyun YongHyeon
On Mon, Aug 14, 2006 at 12:50:14PM +0400, Gleb Smirnoff wrote: > Pyun, > > On Mon, Aug 14, 2006 at 02:21:26AM +, Pyun YongHyeon wrote: > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c > P> Log: > P> Make em(4) handle too many fragme

Re: cvs commit: src/sys/dev/em if_em.c

2006-08-14 Thread Gleb Smirnoff
Pyun, On Mon, Aug 14, 2006 at 02:21:26AM +, Pyun YongHyeon wrote: P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c P> Log: P> Make em(4) handle too many fragmented frame with m_defrag(9). P> Previously em(4) requeued the failed mbuf chains from P>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-08 Thread Yar Tikhiy
On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote: > > P> Is there a report on what coverty found with if_em_hw.c? > > Coverity complains that the return value of em_read_phy_reg() is > somtimes checked and sometimes is not. Can you please tell, whether > this is important report or c

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-07 Thread Gleb Smirnoff
On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote: T> On Fri, Aug 04, 2006 at 04:21:49PM +, Prafulla Deuskar wrote: T> P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon? T> P> T> P> Jack Vogel is doing the merge - I will send it out to you for review. T> P> So let

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-07 Thread Gleb Smirnoff
Prafulla, On Fri, Aug 04, 2006 at 04:21:49PM +, Prafulla Deuskar wrote: P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon? P> P> Jack Vogel is doing the merge - I will send it out to you for review. P> So let us plan on committing early next week? The merge is very simple

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Prafulla Deuskar
Andre Oppermann [EMAIL PROTECTED] wrote: > Prafulla Deuskar wrote: > >Gleb Smirnoff [EMAIL PROTECTED] wrote: > >> Prafulla, > >> > >>On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: > >>P> pdeuskar2006-08-03 19:05:05 UTC > >>P> > >>P> FreeBSD src repository > >>P> > >>P>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Prafulla Deuskar
Gleb Smirnoff [EMAIL PROTECTED] wrote: > On Fri, Aug 04, 2006 at 02:38:25PM +, Prafulla Deuskar wrote: > P> > P> Revert back changes to made in rev 1.109 of if_em.c which were > unnecessary. > P> > P> This makes it easier for us to get the changes into -current and to > -stable quickly. >

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Warner Losh
From: Gleb Smirnoff <[EMAIL PROTECTED]> Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 4 Aug 2006 13:54:14 +0400 > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: > P> pdeuskar2006-08-03 19:05:05 UTC > P> &g

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Warner Losh
From: Colin Percival <[EMAIL PROTECTED]> Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 04 Aug 2006 01:14:54 -0700 > Yar Tikhiy wrote: > > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. > > FWIW, the following files in 6.1-

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Andre Oppermann
Prafulla Deuskar wrote: Gleb Smirnoff [EMAIL PROTECTED] wrote: Prafulla, On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: P> pdeuskar2006-08-03 19:05:05 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c if_em.h P> Log: P>

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread John Baldwin
On Friday 04 August 2006 03:46, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from actual co

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Gleb Smirnoff
On Fri, Aug 04, 2006 at 02:38:25PM +, Prafulla Deuskar wrote: P> > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. P> > P> This makes it easier for us to get the changes into -current and to -stable quickly. P> > P> > Can you please confirm that this was a

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Wilko Bulte
On Fri, Aug 04, 2006 at 12:49:09AM -0700, Colin Percival wrote.. > Yar Tikhiy wrote: > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > With md5(1), you can only 99.94579% verify it. :-)

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Prafulla Deuskar
Gleb Smirnoff [EMAIL PROTECTED] wrote: > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: > P> pdeuskar2006-08-03 19:05:05 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c if_em.h > P> Log: > P> Rev

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Gleb Smirnoff
Prafulla, On Thu, Aug 03, 2006 at 07:05:05PM +, Prafulla Deuskar wrote: P> pdeuskar2006-08-03 19:05:05 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c if_em.h P> Log: P> Revert back changes to made in rev 1.109 of if_em.c which were u

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Stefan Farfeleder
On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > As a general remark, it is a very good idea to keep large style(9) > > > sweeps separate from

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Colin Percival
Yar Tikhiy wrote: > Yeah, it's a thing to watch out for. As are __TIME__ and __DATE__. FWIW, the following files in 6.1-RELEASE/i386 contain build timestamps: /boot/GENERIC/hptmv.ko /boot/GENERIC/kernel /boot/SMP/hptmv.ko /boot/SMP/kernel /boot/loader /boot/pxeboot /etc/mail/freebsd.cf /etc/mail

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 12:49:09AM -0700, Colin Percival wrote: > Yar Tikhiy wrote: > > Changing style(9) shouldn't alter the binary code produced, and > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). > > With md5(1), you can only 99.94579% verify it. :-)

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 09:52:31AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote: > > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > > > > > As a general rem

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Colin Percival
Yar Tikhiy wrote: > Changing style(9) shouldn't alter the binary code produced, and > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). With md5(1), you can only 99.94579% verify it. :-) Colin Percival ___ cvs-all@fr

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote: > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > > > As a general remark, it is a very good idea to keep large style(9) > > sweeps separate from actual code changes even if they are tiny. > > Changing style(9) shou

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Stefan Farfeleder
On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote: > > As a general remark, it is a very good idea to keep large style(9) > sweeps separate from actual code changes even if they are tiny. > Changing style(9) shouldn't alter the binary code produced, and > this can be 100% verified using c

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-04 Thread Yar Tikhiy
On Fri, Aug 04, 2006 at 01:25:14AM +, John Birrell wrote: > On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > > Prafulla Deuskar wrote: > > > Modified files: > > > sys/dev/em if_em.c if_em.h > > > Log: > > > Revert back changes to made in rev 1.109 of if_em.

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-03 Thread John Birrell
On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > Prafulla Deuskar wrote: > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Revert back changes to made in rev 1.109 of if_em.c which were > > unnecessary. > > This makes it easier for us to get th

Re: cvs commit: src/sys/dev/em if_em.c if_em.h

2006-08-03 Thread Colin Percival
Prafulla Deuskar wrote: > Modified files: > sys/dev/em if_em.c if_em.h > Log: > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > This makes it easier for us to get the changes into -current and to -stable > quickly. I assume you've discussed thi

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-31 Thread Pyun YongHyeon
On Mon, Jul 31, 2006 at 11:43:11PM +0400, Gleb Smirnoff wrote: > On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: > R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: > R> > R> >On Thu, Jul 20, 2006 at 03:57:58AM +, Pyun YongHyeon wrote: > R> >P> yongari 2006-07-20 03:57:58 UT

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-31 Thread Gleb Smirnoff
On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: R> R> >On Thu, Jul 20, 2006 at 03:57:58AM +, Pyun YongHyeon wrote: R> >P> yongari 2006-07-20 03:57:58 UTC R> >P> R> >P> FreeBSD src repository R> >P> R> >P> Modified files: R> >P

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-31 Thread Robert Watson
On Mon, 31 Jul 2006, Gleb Smirnoff wrote: On Thu, Jul 20, 2006 at 03:57:58AM +, Pyun YongHyeon wrote: P> yongari 2006-07-20 03:57:58 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c P> Log: P> Honor IFF_DRV_OACTIVE in em_start_locked().

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-31 Thread Gleb Smirnoff
On Thu, Jul 20, 2006 at 03:57:58AM +, Pyun YongHyeon wrote: P> yongari 2006-07-20 03:57:58 UTC P> P> FreeBSD src repository P> P> Modified files: P> sys/dev/em if_em.c P> Log: P> Honor IFF_DRV_OACTIVE in em_start_locked(). Isn't it better to shift this change to th

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-31 Thread Yar Tikhiy
On Mon, Jul 31, 2006 at 11:43:54AM +0900, Pyun YongHyeon wrote: > On Sun, Jul 30, 2006 at 01:50:55PM +0400, Yar Tikhiy wrote: > > On Sun, Jul 30, 2006 at 03:48:07PM +0900, Pyun YongHyeon wrote: > > > On Sat, Jul 29, 2006 at 08:50:09PM +, Yar Tikhiy wrote: > > > > On Thu, Jul 27, 2006 at 12:

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-30 Thread Pyun YongHyeon
On Sun, Jul 30, 2006 at 01:50:55PM +0400, Yar Tikhiy wrote: > On Sun, Jul 30, 2006 at 03:48:07PM +0900, Pyun YongHyeon wrote: > > On Sat, Jul 29, 2006 at 08:50:09PM +, Yar Tikhiy wrote: > > > On Thu, Jul 27, 2006 at 12:43:34AM +, Pyun YongHyeon wrote: > > > > yongari 2006-07-27 00

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-30 Thread Yar Tikhiy
On Sun, Jul 30, 2006 at 03:48:07PM +0900, Pyun YongHyeon wrote: > On Sat, Jul 29, 2006 at 08:50:09PM +, Yar Tikhiy wrote: > > On Thu, Jul 27, 2006 at 12:43:34AM +, Pyun YongHyeon wrote: > > > yongari 2006-07-27 00:43:34 UTC > > > > > > FreeBSD src repository > > > > > > Modi

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-30 Thread John Birrell
On Sun, Jul 30, 2006 at 03:48:58PM +0900, Pyun YongHyeon wrote: > That's odd. Do you use VLAN with hardware tagging and the interface > is in promiscuous mode? No. > Would you should me the diagnostics trace again? That will have to wait until another problem with sun4v is solved. -- John Birre

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-29 Thread Pyun YongHyeon
On Sat, Jul 29, 2006 at 10:01:54PM +, John Birrell wrote: > On Thu, Jul 27, 2006 at 12:43:34AM +, Pyun YongHyeon wrote: > > yongari 2006-07-27 00:43:34 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c > > Log: > > Prepen

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-29 Thread Pyun YongHyeon
On Sat, Jul 29, 2006 at 08:50:09PM +, Yar Tikhiy wrote: > On Thu, Jul 27, 2006 at 12:43:34AM +, Pyun YongHyeon wrote: > > yongari 2006-07-27 00:43:34 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/em if_em.c > > Log: > > Prependi

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-29 Thread John Birrell
On Thu, Jul 27, 2006 at 12:43:34AM +, Pyun YongHyeon wrote: > yongari 2006-07-27 00:43:34 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Prepending an mbuf after loading a DMA map results in unexpected > result. So, modify mbuf ch

Re: cvs commit: src/sys/dev/em if_em.c

2006-07-29 Thread Yar Tikhiy
On Thu, Jul 27, 2006 at 12:43:34AM +, Pyun YongHyeon wrote: > yongari 2006-07-27 00:43:34 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Prepending an mbuf after loading a DMA map results in unexpected > result. So, modify mbuf ch

Re: cvs commit: src/sys/dev/em if_em.c

2006-05-18 Thread Wilko Bulte
On Fri, May 19, 2006 at 12:19:57AM +, Pyun YongHyeon wrote.. > yongari 2006-05-19 00:19:57 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/em if_em.c > Log: > MFC if_em.c, 1.92 to RELENG_6: >Add jumbo frame support for arch

Re: cvs commit: src/sys/dev/em if_em.c

2006-02-21 Thread John-Mark Gurney
Gleb Smirnoff wrote this message on Tue, Feb 21, 2006 at 15:09 +0300: > On Tue, Feb 21, 2006 at 10:01:43AM +0100, Morten Rodal wrote: > M> This change breaks the network interfaces in vmware 5.5 on amd64. I > M> also attempted to build a module with NO_EM_FASTINTR defined, but that > M> did not he

  1   2   >