Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v13]

2024-05-23 Thread Joe Wang
perties. > > Updated on 5/18/2024 > > Withdraw changes to jaxp.properties. The original idea was to match > jaxp-strict.properties with regard to the properties. However, that change > impact the configuration process, resulting in tests that verify the process > to fail. Jo

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v12]

2024-05-23 Thread Joe Wang
On Wed, 22 May 2024 08:52:42 GMT, Magnus Ihse Bursie wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a note to module-info > > make/modules/java.xml/Copy.gmk line 35: > &g

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v13]

2024-05-23 Thread Joe Wang
On Fri, 24 May 2024 05:26:40 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]

2024-05-24 Thread Joe Wang
t; > Updated on 5/23/2024 > > Provide a template `jaxp-strict.template` instead of a properties file. This > template can be used to create custom configuration files. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: rename the

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]

2024-05-24 Thread Joe Wang
On Fri, 24 May 2024 16:36:32 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v15]

2024-05-28 Thread Joe Wang
t; > Updated on 5/23/2024 > > Provide a template `jaxp-strict.template` instead of a properties file. This > template can be used to create custom configuration files. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: u

Re: RFR: 8330542: Template for Creating Strict JAXP Configuration File [v14]

2024-05-28 Thread Joe Wang
On Fri, 24 May 2024 16:36:32 GMT, Joe Wang wrote: >> Add two sample configuration files: >> >> jaxp-strict.properties: used to set strict configuration, stricter than >> jaxp.properties in previous versions such as JDK 22 >> >>> jaxp-compat.proper

Integrated: 8330542: Template for Creating Strict JAXP Configuration File

2024-05-28 Thread Joe Wang
On Wed, 17 Apr 2024 23:24:06 GMT, Joe Wang wrote: > Add two sample configuration files: > > jaxp-strict.properties: used to set strict configuration, stricter than > jaxp.properties in previous versions such as JDK 22 > >> jaxp-compat.properties: used to regain compat

Re: RFR: 8332161: Test restoring echo in the Console implementation (java.base) [v6]

2024-05-28 Thread Joe Wang
On Tue, 28 May 2024 16:56:18 GMT, Naoto Sato wrote: >> This test intends to verify the behavior of JdkConsole for the java.base >> module, wrt restoring the echo. The test assumes the internal methods that >> sets/gets the echo status of the platform. > > Naoto Sato has updated the pull request

RFR: 8332750: Broken link in CatalogFeatures.html

2024-06-04 Thread Joe Wang
Fix a broken link. - Commit messages: - 8332750: Broken link in CatalogFeatures.html Changes: https://git.openjdk.org/jdk/pull/19551/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19551&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332750 Stats: 2 lines in 1 fil

Re: RFR: 8332750: Broken link in CatalogFeatures.html

2024-06-04 Thread Joe Wang
On Tue, 4 Jun 2024 21:17:43 GMT, Joe Wang wrote: > Fix a broken link. Thanks all! - PR Comment: https://git.openjdk.org/jdk/pull/19551#issuecomment-2148759156

Integrated: 8332750: Broken link in CatalogFeatures.html

2024-06-04 Thread Joe Wang
On Tue, 4 Jun 2024 21:17:43 GMT, Joe Wang wrote: > Fix a broken link. This pull request has now been integrated. Changeset: 9db7c950 Author: Joe Wang URL: https://git.openjdk.org/jdk/commit/9db7c950190853513f4c2afa0efa9a4ff72b60d7 Stats: 2 lines in 1 file changed: 0 ins; 0

Re: RFR: 8332161: Test restoring echo in the Console implementation (java.base) [v9]

2024-06-05 Thread Joe Wang
On Wed, 5 Jun 2024 17:48:25 GMT, Naoto Sato wrote: >> This test intends to verify the behavior of JdkConsole for the java.base >> module, wrt restoring the echo. The test assumes the internal methods that >> sets/gets the echo status of the platform. > > Naoto Sato has updated the pull request

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Joe Wang
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translati

RFR: 8336021: Doccheck: valign not allowed for HTML5 in java.xml

2024-07-10 Thread Joe Wang
Remove valign Attribute from the javadoc for org.w3c.dom.Attr. The table looks good with the default setting. - Commit messages: - 8336021: Doccheck: valign not allowed for HTML5 in java.xml Changes: https://git.openjdk.org/jdk/pull/20117/files Webrev: https://webrevs.openjdk.org

Integrated: 8336021: Doccheck: valign not allowed for HTML5 in java.xml

2024-07-11 Thread Joe Wang
On Wed, 10 Jul 2024 16:24:01 GMT, Joe Wang wrote: > Remove valign Attribute from the javadoc for org.w3c.dom.Attr. The table > looks good with the default setting. This pull request has now been integrated. Changeset: 58c98420 Author: Joe Wang URL: https://git.openjdk.o

Re: RFR: 8336300: DateFormatSymbols#getInstanceRef returns non-cached instance [v2]

2024-07-16 Thread Joe Wang
On Tue, 16 Jul 2024 16:54:09 GMT, Naoto Sato wrote: >> Removing a redundant private method, which has the same implementation with >> the public sibling and obsolete method description. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8338690: CompactNumberInstance.format incorrectly formats some numbers (few vs many)

2024-08-23 Thread Joe Wang
On Thu, 22 Aug 2024 16:14:08 GMT, Naoto Sato wrote: > Fixing an issue wrt wrong plural suffix with compact format for some locales. > It was retrieving the suffix based on the value before the rounding, which > ended up in wrong plural expression. Marked as reviewed by joehw (Reviewer). -

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-30 Thread Joe Wang
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

2022-10-05 Thread Joe Wang
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote: > Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 41: > 39: /* > 40: * @test > 41: * @bug 8289510 s/

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

2022-10-05 Thread Joe Wang
On Wed, 5 Oct 2022 17:28:08 GMT, Bill Huang wrote: >> Added test cases for xpath Axis: >> 1. descendant >> 2. descendant-or-self >> 3. following >> 4. following-sibling > > test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 65: > >> 63: >> {"/Customers/Cust

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v3]

2022-10-11 Thread Joe Wang
On Tue, 11 Oct 2022 11:31:53 GMT, Mahendra Chhipa wrote: >> Added test cases for xpath Axis: >> 1. descendant >> 2. descendant-or-self >> 3. following >> 4. following-sibling > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8295372: CompactNumberFormat handling of number one with decimal part

2022-10-18 Thread Joe Wang
On Tue, 18 Oct 2022 17:44:45 GMT, Naoto Sato wrote: > Plurals were determined only by looking at the integer part of the compact > number. Changed to consider the fraction digits as well. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10748

Re: RFR: 8295564: Norwegian Nynorsk Locale is missing formatting

2022-10-19 Thread Joe Wang
On Wed, 19 Oct 2022 19:04:57 GMT, Naoto Sato wrote: > This is a regression caused by upgrading CLDR to version 39 (JDK-8258794), in > which CLDR changed the locale inheritance for Norwegian. Some locale data > (including number elements) that were in `nn` locale was moved to `no`. There > was

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Joe Wang
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Joe Wang
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-27 Thread Joe Wang
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-28 Thread Joe Wang
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism defin

Re: RFR: 8284842: Update Unicode Data Files to Version 15.0.0

2022-10-31 Thread Joe Wang
On Mon, 24 Oct 2022 18:50:24 GMT, Naoto Sato wrote: > Updates the JDK to use the latest Unicode 15, which also updates the ICU4J > along with it (8284844: Update ICU4J to Version 72.1). The corresponding CSR > has already been approved. LGTM. Sorry for the delay. - Marked as revi

Re: RFR: JDK-8288232: Address typos in jar man page

2022-11-02 Thread Joe Wang
On Wed, 2 Nov 2022 14:04:45 GMT, Lance Andersen wrote: > Hi > > Please review this update to the jar man page which removes the "=" for the > non GNU style options > > Best > Lance Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10947

RFR: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names

2022-11-02 Thread Joe Wang
Fixed an issue where the condition check for limit=0 was missed. - Commit messages: - 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names Changes: https://git.openjdk.org/jdk/pull/10958/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1095

Re: RFR: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names [v2]

2022-11-02 Thread Joe Wang
> Fixed an issue where the condition check for limit=0 was missed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: source changes - Changes: - all: https://git.openjdk.org/jdk/pull/10958/files - new: ht

Re: RFR: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names [v2]

2022-11-03 Thread Joe Wang
On Wed, 2 Nov 2022 20:00:55 GMT, Joe Wang wrote: >> Fixed an issue where the condition check for limit=0 was missed. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > source changes Thanks Lance, Naot

Integrated: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names

2022-11-03 Thread Joe Wang
On Wed, 2 Nov 2022 19:32:47 GMT, Joe Wang wrote: > Fixed an issue where the condition check for limit=0 was missed. This pull request has now been integrated. Changeset: 2ff9d3af Author: Joe Wang URL: https://git.openjdk.org/jdk/commit/2ff9d3af815c0f6ff2643d8fc562cec20ef6c324 St

Re: RFR: 8296715: CLDR v42 update for tzdata 2022f

2022-11-09 Thread Joe Wang
On Wed, 9 Nov 2022 18:58:30 GMT, Naoto Sato wrote: > Pick up the fix in the upstream CLDR v42 maintenance branch for their > tzdata2022f changes. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11066

Re: RFR: 8297152: Add a @sealedGraph tag to ZoneId

2022-11-16 Thread Joe Wang
On Wed, 16 Nov 2022 19:07:48 GMT, Naoto Sato wrote: > Adding a `@sealedGraph` tag to `ZoneId` class. Get a nice graph! - Marked as reviewed by joehw (Reviewer). PR: https://git.openjdk.org/jdk/pull/11195

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-11-23 Thread Joe Wang
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote: >> Please review a "somewhat automated" change to insert `@spec` tags into doc >> comments, as appropriate, to leverage the recent new javadoc feature to >> generate a new page listing the references to all external specifications >> li

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-11-23 Thread Joe Wang
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote: >> Please review a "somewhat automated" change to insert `@spec` tags into doc >> comments, as appropriate, to leverage the recent new javadoc feature to >> generate a new page listing the references to all external specifications >> li

Re: RFR: 8298808: Check `script` code on detecting the base locales [v2]

2022-12-15 Thread Joe Wang
On Wed, 14 Dec 2022 23:47:43 GMT, Naoto Sato wrote: >> Fixing `CLDRConverter` build tool to not regard [new >> locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731) >> introduced in CLDR 43 as one of the base locales.

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Joe Wang
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well The changes in the java.xml area look good to me. ---

Re: RFR: 8299292: Missing elements in aliased String array [v2]

2023-01-04 Thread Joe Wang
On Wed, 4 Jan 2023 21:04:08 GMT, Naoto Sato wrote: >> This is a pre-requisite fix for upgrading CLDR to v43. The upcoming CLDR >> changed the inheritance mechanism a bit with this change: >> https://unicode-org.atlassian.net/browse/CLDR-15054 where they removed the >> duplication of data. This

Re: RFR: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs

2023-01-06 Thread Joe Wang
On Fri, 6 Jan 2023 19:56:20 GMT, Justin Lu wrote: >> Removed constructors of primitive wrapper classes (deprecated for removal) >> in _javax.xml.stream.XMLOutputFactory_ >> >> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE > > src/java.xml/share/classes/javax/xml/stream/XM

Re: RFR: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs [v2]

2023-01-06 Thread Joe Wang
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote: >> Removed constructors of primitive wrapper classes (deprecated for removal) >> in _javax.xml.stream.XMLOutputFactory_ >> >> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE > > Justin Lu has updated the pull request increme

Re: RFR: 8299571: ZoneRulesProvider.registerProvider() can leave inconsistent state on failure

2023-01-10 Thread Joe Wang
On Tue, 10 Jan 2023 17:17:41 GMT, Naoto Sato wrote: > Fixing the subject method to recover gracefully on a failed > `ZoneRulesProvider` registration. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11928

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Joe Wang
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revisi

RFR: 8301269: Update Commons BCEL to Version 6.7.0

2023-02-07 Thread Joe Wang
Update Commons BCEL in the JDK from 6.5.0 to 6.7.0. 1. Improvement Code modernization (using relatively more modern language features), normalization (such as naming), javadocs, cleanup and minor improvements made up most of the changes. These changes do not change how BCEL works for the XSL

Re: RFR: 8301269: Update Commons BCEL to Version 6.7.0 [v2]

2023-02-10 Thread Joe Wang
already been addressed in the > upstream source as the result of item 1, thus lessoned the needs to reapply > the warning patches. Fixed the rest of warnings as they showed up during > build. > > 4. Note that JRocket specific patches are not in the current code base. > > 5.

Integrated: 8301269: Update Commons BCEL to Version 6.7.0

2023-02-11 Thread Joe Wang
On Wed, 8 Feb 2023 00:15:27 GMT, Joe Wang wrote: > Update Commons BCEL in the JDK from 6.5.0 to 6.7.0. > > 1. Improvement >Code modernization (using relatively more modern language features), > normalization (such as naming), javadocs, cleanup and minor improvements made &

Re: RFR: 8303039: Utilize `coverageLevels.txt` [v2]

2023-03-02 Thread Joe Wang
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote: >> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` >> locales with `common` locales >> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order >> to have the same coverage level of locales, CLDRC

RFR: 8303530: Add system property for custom JAXP configuration file

2023-03-10 Thread Joe Wang
Add a system property, jdk.xml.config.file, to return the path to a custom JAXP configuration file. The current configuration file, jaxp.properties, that the JDK supports will become the default configuration file. CSR: https://bugs.openjdk.org/browse/JDK-8303531 Tests: XML SQE and JCK tests pa

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-10 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: clean up tests; fix copy&paste error. - Changes: - all: https://git.openjdk.org/jdk/pull/12985/files - new: https://git.openjdk

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 09:58:51 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/XML

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 10:01:21 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/cat

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 10:03:52 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/cat

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 11:28:15 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/javax/xml/st

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-13 Thread Joe Wang
On Mon, 13 Mar 2023 11:34:50 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up tests; fix copy&paste error. > > src/java.xml/share/classes/module-info.j

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v3]

2023-03-14 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update config file description; add a general scope and order section; move value definition for external properties to class description -

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v4]

2023-03-29 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: change prefix from jdk to java; rm zip file that accidentally checked in - Changes: - all: https://git.openjdk.org/jdk/pull/12985

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v5]

2023-03-29 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: change prefix from jdk to java - Changes: - all: https://git.openjdk.org/jdk/pull/12985/files - new: https://git.openjdk.org

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v6]

2023-03-31 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: continue support stax.properties at the impl level, though dropped from the spec - Changes: - all: https://git.openjdk.org/jdk/pul

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v7]

2023-04-04 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update javadoc as discussed in the review meeting; add a sample configuration file jaxp.properties; update impl and tests accordingly. --

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v8]

2023-04-06 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Update based on the review meeting on 4/5. Added (duplicated) definitions in jaxp.properties; Rewrote Property Precedence with s

Re: RFR: 8296248: Update CLDR to Version 43.0 [v2]

2023-04-14 Thread Joe Wang
On Thu, 13 Apr 2023 23:45:45 GMT, Naoto Sato wrote: >> Upgrading the CLDR to [version >> 43](https://cldr.unicode.org/index/downloads/cldr-43). This semi-annual >> release is their `limited-submission` release so I would not expect >> regressions caused by formatting changes as we had in JDK20

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v2]

2023-04-19 Thread Joe Wang
On Wed, 19 Apr 2023 17:32:49 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > closed file handlers. Looks good overall tes

Re: RFR: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.

2023-04-26 Thread Joe Wang
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote: > Updating the collation rules for Swedish to the modern one, which is aligned > with the CLDR's default collation rules. Since it is changing the existing > behavior, a release note has also been drafted: > https://bugs.openjdk.org/browse/JD

Re: RFR: 8306927: Collator treats "v" and "w" as the same letter for Swedish language locale.

2023-04-27 Thread Joe Wang
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote: > Updating the collation rules for Swedish to the modern one, which is aligned > with the CLDR's default collation rules. Since it is changing the existing > behavior, a release note has also been drafted: > https://bugs.openjdk.org/browse/JD

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-04-27 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: -

RFR: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler

2023-04-28 Thread Joe Wang
Fix a copy n paste error in XMLSchemaValidator. When the patch was applied while updating to Xerces 2.12.2, the original code was not removed, resulting in reporting validation error twice. - Commit messages: - 8298087: XML Schema Validation reports an required attribute twice via

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

2023-04-28 Thread Joe Wang
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments. Looks ok. Pr

Re: RFR: 8307088: Allow the jdbc.drivers system property to be searchable

2023-04-28 Thread Joe Wang
On Fri, 28 Apr 2023 17:28:47 GMT, Lance Andersen wrote: > Hi all, > > Please review this trivial change which allows the` jdbc.drivers` system > property to be searchable. > > Best. > Lance Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/137

Re: RFR: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler [v2]

2023-04-28 Thread Joe Wang
On Sat, 29 Apr 2023 00:09:55 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removing the line that changed locale. It's not necessary as the concern >> was the numb

Re: RFR: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler [v2]

2023-04-28 Thread Joe Wang
> Fix a copy n paste error in XMLSchemaValidator. When the patch was applied > while updating to Xerces 2.12.2, the original code was not removed, resulting > in reporting validation error twice. Joe Wang has updated the pull request incrementally with one additional commit since

Integrated: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler

2023-05-01 Thread Joe Wang
On Fri, 28 Apr 2023 17:08:10 GMT, Joe Wang wrote: > Fix a copy n paste error in XMLSchemaValidator. When the patch was applied > while updating to Xerces 2.12.2, the original code was not removed, resulting > in reporting validation error twice. This pull request has now been i

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v10]

2023-05-02 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update to address review comments - Changes: - all: https://git.openjdk.org/jdk/pull/12985/files - new: https://git.openjdk.org

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:53:06 GMT, Alan Bateman wrote: >> src/java.xml/share/classes/module-info.java line 33: >> >>> 31: * JAXP supports the use of a configuration file for the >>> 32: * Factory Lookup Mechanism and >>> 33: * setting properties that have defined corresponding system propertie

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:27:12 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Mon, 1 May 2023 18:25:13 GMT, Naoto Sato wrote: > Regarding the new unit tests, it looks like there are a lot of boilerplate > codes. Can they be shared? Multiple tests per a processor, and separate test per each processor, if that's what you meant, they unfortunately can not be run within

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:40:22 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v11]

2023-05-02 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: address review comments - Changes: - all: https://git.openjdk.org/jdk/pull/12985/files - new: https://git.openjdk.org/jdk/pull

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v9]

2023-05-02 Thread Joe Wang
On Sun, 30 Apr 2023 07:37:07 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten

Re: RFR: 8303530: Redefine JAXP Configuration File [v12]

2023-05-25 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision: -

Re: RFR: 8303530: Redefine JAXP Configuration File [v9]

2023-05-25 Thread Joe Wang
On Fri, 5 May 2023 08:12:01 GMT, Alan Bateman wrote: >> Changed the opening statement and also the naming of config file as above. > > I've looked through the updated proposal but I think the intro is going to > take a few iterations to get to something that is easy to read. I had hoped > the i

Re: RFR: 8303530: Redefine JAXP Configuration File [v11]

2023-05-25 Thread Joe Wang
On Fri, 5 May 2023 08:16:14 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address review comments > > src/java.xml/share/conf/j

Re: RFR: 8303530: Redefine JAXP Configuration File [v13]

2023-05-25 Thread Joe Wang
> Tests: XML SQE and JCK tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Changes after many iterations in 3 weeks: added intro, streamlined sections leading to the Configuration File section with most of the text edite

RFR: 8288529: broken link in java.xml

2022-06-21 Thread Joe Wang
Some of the links cause redirection, iso.org in particular took 1-2 seconds, that looks like was longer than the wait time of the doccheck and docs link checker. Changed it to the current homepage to avoid redirection. Also changed other links within this package. I'm limiting the change to th

Re: RFR: 8287868: Localized names update in COMPAT locale provider [v3]

2022-06-21 Thread Joe Wang
On Mon, 13 Jun 2022 22:58:43 GMT, Naoto Sato wrote: >> As the name suggests, `COMPAT` locale provider keeps compatibility with >> JDK8's locale data (before CLDR). This is useful for legacy applications, >> but some of its data got obsolete for later locale data updates, such as the >> countr

Integrated: 8288529: broken link in java.xml

2022-06-21 Thread Joe Wang
On Tue, 21 Jun 2022 16:52:52 GMT, Joe Wang wrote: > Some of the links cause redirection, iso.org in particular took 1-2 seconds, > that looks like was longer than the wait time of the doccheck and docs link > checker. Changed it to the current homepage to avoid redirection. Also

RFR: 8287076: Document.normalizeDocument() produces different results

2022-06-22 Thread Joe Wang
Fix a regression in Document.normalizeDocument() caused by a change in JDK 10. Test: new test (as in the bug report) and Tier2 passed. - Commit messages: - 8287076: Document.normalizeDocument() produces different results Changes: https://git.openjdk.org/jdk19/pull/59/files Webrev:

Re: RFR: 8287076: Document.normalizeDocument() produces different results [v2]

2022-06-22 Thread Joe Wang
> Fix a regression in Document.normalizeDocument() caused by a change in JDK 10. > > Test: new test (as in the bug report) and Tier2 passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Remove initialization size, use defaul

Re: RFR: 8287076: Document.normalizeDocument() produces different results

2022-06-22 Thread Joe Wang
On Wed, 22 Jun 2022 20:01:58 GMT, Joe Wang wrote: > Fix a regression in Document.normalizeDocument() caused by a change in JDK 10. > > Test: new test (as in the bug report) and Tier2 passed. Thanks Lance. Updated the patch, also changed the corresponding nodes. -

Integrated: 8287076: Document.normalizeDocument() produces different results

2022-06-23 Thread Joe Wang
On Wed, 22 Jun 2022 20:01:58 GMT, Joe Wang wrote: > Fix a regression in Document.normalizeDocument() caused by a change in JDK 10. > > Test: new test (as in the bug report) and Tier2 passed. This pull request has now been integrated. Changeset: 1f9521e6 Author: Joe Wang URL:

Re: [jdk19] RFR: 8289252: Recommend Locale.of() method instead of the constructor

2022-06-28 Thread Joe Wang
On Tue, 28 Jun 2022 17:11:31 GMT, Naoto Sato wrote: > This is a leftover documentation fix to the deprecation of `Locale` > constructors. `Locale.Builder` class had some texts that suggested using one > of those constructors, which need to be replaced with a `Locale.of()` method. > A correspon

[jdk19] RFR: 8289486: Improve XSLT XPath operators count efficiency

2022-07-01 Thread Joe Wang
To improve efficiency, this patch moves the limit check to within the Lexer and reports any overlimit situation as soon as it happens. Test: java.xml tests passed. - Commit messages: - 8289486: Improve XSLT XPath operators count effiency Changes: https://git.openjdk.org/jdk19/pull

Re: [jdk19] RFR: 8289486: Improve XSLT XPath operators count efficiency

2022-07-01 Thread Joe Wang
On Fri, 1 Jul 2022 17:04:10 GMT, Joe Wang wrote: > To improve efficiency, this patch moves the limit check to within the Lexer > and reports any overlimit situation as soon as it happens. > > Note the change in XPathParser: diff (and also webrevs) showed the whole > error-r

[jdk19] Integrated: 8289486: Improve XSLT XPath operators count efficiency

2022-07-07 Thread Joe Wang
On Fri, 1 Jul 2022 17:04:10 GMT, Joe Wang wrote: > To improve efficiency, this patch moves the limit check to within the Lexer > and reports any overlimit situation as soon as it happens. > > Note the change in XPathParser: diff (and also webrevs) showed the whole > error-r

Re: [jdk19] RFR: 8289486: Improve XSLT XPath operators count efficiency [v2]

2022-07-08 Thread Joe Wang
acing the block > to within the isOverLimit statement. > > Test: java.xml tests passed. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add comments - Changes: - all: https://git.openjdk.org/jdk19/pull/

[jdk19] RFR: 8282071: Update java.xml module-info

2022-07-08 Thread Joe Wang
Update module-info - Commit messages: - 8282071: Update java.xml module-info Changes: https://git.openjdk.org/jdk19/pull/126/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=126&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282071 Stats: 6 lines in 1 file changed

[jdk19] Integrated: 8282071: Update java.xml module-info

2022-07-08 Thread Joe Wang
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote: > Update module-info This pull request has now been integrated. Changeset: c86c51cc Author: Joe Wang URL: https://git.openjdk.org/jdk19/commit/c86c51cc72e3457756434b9150b0c5ef2f5d496d Stats: 6 lines in 1 file changed: 2 ins; 0

[jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Joe Wang
Update dom.md, adding notice. - Commit messages: - 8290207: Missing notice in dom.md Changes: https://git.openjdk.org/jdk19/pull/138/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290207 Stats: 15 lines in 1 fil

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Joe Wang
On Wed, 13 Jul 2022 01:57:43 GMT, Naoto Sato wrote: >> Update dom.md, adding notice. > > src/java.xml/share/legal/dom.md line 4: > >> 2: >> 3: ### W3C Software Notice >> 4: > > Since this is a markdown, should this be three back-ticks "```" instead of > "pre" HTML tag? Iris can probably com

  1   2   3   4   5   >