On Mon, 1 May 2023 18:25:13 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Regarding the new unit tests, it looks like there are a lot of boilerplate
> codes. Can they be shared?
Multiple tests per a processor, and separate test per each processor, if that's
what you meant, they unfortunately can not be run within one test since the
config file is defined to be loaded once only.
> src/java.xml/share/classes/jdk/xml/internal/SecuritySupport.java line 234:
>
>> 232: }
>> 233: firstTimeCustom = false;
>> 234: }
>
> Is it possible if `firstTime` and `firstTimeCustom` differ? Would it be
> possible to get rid of `firstTimeCustom` and move this piece into `firstTime`
> block?
Removed firstTimeCustom and related code. Also reversed the order of stax and
jaxp.properties as we're making jaxp.properties the preferred one.
> src/java.xml/share/classes/jdk/xml/internal/SecuritySupport.java line 253:
>
>> 251: return true;
>> 252: } catch (IOException e) {
>> 253: // ignore file not found error
>
> How could "file not found" occur assuming `SecuritySupport.doesFileExist(f)`
> returns true?
Changed the comment. Yeah, it's not possible, a try block was needed only
because a method called required it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12985#issuecomment-1532038269
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1182972527
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1182973569
