On Sun, 30 Apr 2023 07:27:12 GMT, Alan Bateman <[email protected]> wrote:
>> Joe Wang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains ten additional commits
>> since the last revision:
>>
>> - Merge branch 'master' into JDK-8303530
>> - Update based on the review meeting on 4/5. Added (duplicated) definitions
>> in jaxp.properties; Rewrote Property Precedence with samples; Other updates.
>> - update javadoc as discussed in the review meeting; add a sample
>> configuration file jaxp.properties; update impl and tests accordingly.
>> - continue support stax.properties at the impl level, though dropped from
>> the spec
>> - change prefix from jdk to java
>> - change prefix from jdk to java; rm zip file that accidentally checked in
>> - update config file description; add a general scope and order section;
>> move value definition for external properties to class description
>> - clean up tests; fix copy&paste error.
>> - 8303530: Add system property for custom JAXP configuration file
>
> src/java.xml/share/classes/module-info.java line 61:
>
>> 59: * By default, the <a href="#Factories">JAXP Factories</a> will look for
>> a
>> 60: * configuration file called {@code jaxp.properties} in the {@code conf}
>> directory
>> 61: * of the Java installation and use the entries if any to customize the
>> behavior
>
> "of the Java installation" should probably say the run-time image, or maybe
> just change this to use ${java.home}/conf as it is used in other API docs.
changed to ${java.home}/conf
> src/java.xml/share/classes/module-info.java line 74:
>
>> 72: * <h3 id="CF_SP">User-defined Configuration File</h3>
>> 73: * A user-defined configuration file can be set outside of the JDK by
>> using the
>> 74: * system property {@code java.xml.config.file}.
>
> "can be set out of the JDK" needs to be re-phrased. Maybe this sentence can
> be restructured to say that a system property can be set on the command line
> to specify the location of a configuration file on the file system. Adding
> "command line" would be helpful because "system property" is too overloaded
> in these docs.
Updated. Note it can also be set through the System API.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1182965219
PR Review Comment: https://git.openjdk.org/jdk/pull/12985#discussion_r1182965936
