On Wed, 22 May 2024 08:52:42 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a note to module-info > > make/modules/java.xml/Copy.gmk line 35: > >> 33: $(eval $(call SetupCopyFiles, COPY_XML_MODULE_CONF, \ >> 34: DEST := $(CONF_DST_DIR), \ >> 35: FILES := $(wildcard >> $(TOPDIR)/src/java.xml/share/conf/jaxp*.properties*), \ > > I don't think you need, nor should have, the asterisk after the extension. > You are only copying `.properties` files. > > Suggestion: > > FILES := $(wildcard $(TOPDIR)/src/java.xml/share/conf/jaxp*.properties), \ Thanks Magnus! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18831#discussion_r1612802098
