On Mon, 13 Mar 2023 11:28:15 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up tests; fix copy&paste error.
>
> src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java line 139:
>
>> 137: * Use the value of the property {@code factoryId} set in the
>> 138: * <a
>> href="../../../module-summary.html#ConfigurationFile">configuration file</a>,
>> 139: * stax.properties or jaxp.properties by default. If the file exists
>> and
>
> Is it time to drop all references to stax.properties from the API docs?
Will drop it.
> src/java.xml/share/classes/module-info.java line 31:
>
>> 29: *
>> 30: * <h2 id="ConfigurationFile">Configuration File</h2>
>> 31: * The java.xml (JAXP) Configuration File is used for configuring
>> factories in the
>
> The first sentence of the module description defines "JAXP" as the
> abbreviation for "Java API for XML Processing" so the usage looks a bit
> strange. Maybe the introduction to this section should say that the XML
> processing APIs in this module allow a configuration file the XML processors.
Sounds good, will update that. I was trying to assign the configuration file a
unique name so that it can be referenced clearly.
-------------
PR: https://git.openjdk.org/jdk/pull/12985
