On Wed, 20 Nov 2024 23:34:22 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8344659: System.getProperty("sun.jnu.encoding") ->
>> StaticProperty.jnuEncoding()
>
> src/java.base/share/classes/s
On Tue, 19 Nov 2024 07:58:22 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this chang
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8344659: System.getProperty("sun.jnu.encoding") ->
StaticProperty.jnuEncoding()
-
In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
deprecation warning was written to stdout but all other warnings go to stderr.
Having the warning be on stdout causes interference with application o
On Wed, 20 Nov 2024 01:47:34 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
>> the English message "No Instance(s) Available." is output on localized
>> w
Unwrap calls using doPrivileged in jdk.unsupported sun.misc.Unsafe.
-
Commit messages:
- simplify declaration of INSTANCE
- 8344549: Cleanup AccessController in sun.misc.Unsafe
Changes: https://git.openjdk.org/jdk/pull/22242/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
indentation fixes
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Tue, 19 Nov 2024 09:40:25 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Further facelift
>> - Merge branch 'master' of https://github.com/openjdk/jdk into
>> docs/
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
>
> API Diff:
> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
> Javadoc:
> https://cr.openjdk.org/~liach/javadoc/cf-inst
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote:
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
LGTM
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22285#pullrequestreview-2449890758
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote:
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
Changes in `java.io.Console` and `sun.nio.cs.GB18030` look good.
src/java.base/share/classes/sun/nio/fs/Util.java line 40:
> 38:
> 39: private sta
On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Wed, 20 Nov 2024 23:14:30 GMT, Lance Andersen wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> LGTM
@LanceAndersen , @naotoj Thanks for the reviews. I'll fiix Util.java and hold
off integrating until tomorrow.
-
PR Comment: https
On Mon, 11 Nov 2024 17:28:34 GMT, Maurizio Cimadamore
wrote:
> > Maybe we should also check that padding layouts have natural alignment? The
> > alignment of padding layouts can affect the alignment of the enclosing
> > container.
>
> This makes sense, but I wonder if that would require a cha
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
Remove some occurrences of `GetPropertyAction` overlooked in #22219 and #22132.
-
Commit messages:
- 8344659: Some uses of GetPropertyAction were not removed from java.io and
java.nio
Changes: https://git.openjdk.org/jdk/pull/22285/files
Webrev: https://webrevs.openjdk.org/?repo=
On Wed, 20 Nov 2024 22:43:44 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> indentation
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Wed, 20 Nov 2024 04:22:48 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Wed, 20 Nov 2024 18:16:22 GMT, Severin Gehwolf wrote:
> Sorry about that. There weren't any major objections, so I moved forward as
> there was radio-silence for a while:
That's okay, my comment wasn't aimed at you, it was instead just observing that
there wasn't much feedback.
---
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this chang
On Wed, 20 Nov 2024 17:45:18 GMT, Alan Bateman wrote:
> I had hoped you would get more feedback on the proposal.
Sorry about that. There weren't any major objections, so I moved forward as
there was radio-silence for a while:
https://mail.openjdk.org/pipermail/core-libs-dev/2024-November/134623
On Wed, 20 Nov 2024 18:03:53 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fix indenta
On Wed, 20 Nov 2024 18:02:35 GMT, Alan Bateman wrote:
> > yeah,I tested it a few mins ago.It works well in the situation mentioned in
> > the issue and in the normal situation, also when a remote/target jdk is
> > set. But I have a doubt, when only using the local jdk, no
> > remote/targetjdk,
On Wed, 20 Nov 2024 02:58:45 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/Locale.java line 144:
>>
>>> 142: * each indicating its own semantics, these values should be ordered
>>> 143: * by importance, with most important first, separated by
>>> 144: * underscore('_').
Removed use of SecurityManager to check permissions.
Relaxed defensive copying of byte arrays (due to lack of SM)
Refresh of PR#22168 Including review comments made there.
-
Commit messages:
- Refactor package private method `codeSource` into Module where it is used.
- Review sugge
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
I agree with Daniel that LOGGERFINDER_PERMISSION and the speci
On Wed, 20 Nov 2024 21:30:32 GMT, Mikael Vidstedt wrote:
>> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
>> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
>> deprecation warning was written to stdout but all other warnings go to
>> stderr.
On Wed, 20 Nov 2024 21:18:01 GMT, David Holmes wrote:
> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
> deprecation warning was written to stdout but all other warnings go to
> stderr. Having
On Tue, 19 Nov 2024 09:21:08 GMT, Raffaello Giulietti
wrote:
> While you are at it, it would be useful to add one test for each of the paths
> in the new algorithm (including the exception cases) in the existing
> [SquareRootTests](https://github.com/openjdk/jdk/blob/master/test/jdk/java/math/
Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J
along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR
has already been approved.
-
Commit messages:
- icu.md changes
- Merge branch 'master' into JDK-8319993-Unicode-16
- Merge b
On Wed, 20 Nov 2024 19:39:58 GMT, Daniel Fuchs wrote:
> This PR remove usage of SecurityManager, doPrivileges, etc... from
> `java.logging` and `java.base/jdk.internal.logger`
>
> Only notable hack - Logger.checkPermission() no longer checks permissions,
> but has been renamed into `ensureLogM
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
Please review this simple patch which adds a new external system property
`jdk.patched` when the runtime has been patched with the `--patch-module`
switch. This is useful for two reasons: 1) it allows one to determine at
runtime whether or not `--patch-module` has been used (by querying the said
On Tue, 19 Nov 2024 12:43:48 GMT, Alan Bateman wrote:
>>> concat the URLs to the resource in the modules and the class path
>>
>> Did you mean "concat the URLs of the " ?
>
> "of" or "to" will work here.
Done - I've now updated this comment.
-
PR Review Comment: https://git.op
On Wed, 20 Nov 2024 14:26:27 GMT, Severin Gehwolf wrote:
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time
On Wed, 20 Nov 2024 07:20:32 GMT, Laurent Bourgès wrote:
> I will check today if any 'bad' pattern is remaining in the openjdk master
> source folder... to be sure.
>
> Maybe improving jni documentation would be great in another issue...
Thanks for checking @bourgesl. The JNI docs did in fact
On Wed, 25 Sep 2024 10:28:02 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which adds a micro benchmark exploring
> performance differences between reading entry data sequentially from a
> `ZipFile` and reading the same entries using `ZipInputStream` wrapping a
> `BufferedInputS
On Tue, 19 Nov 2024 19:33:18 GMT, kabutz wrote:
> See internal bug review 9077848
>
> This is a very small unimportant mistake in the naming of the documentation
> that does not match the code.
@kabutz
Your change (at version 2817981d67c561580f262c049384be6f7fe6520f) is now ready
to be spons
This PR remove usage of SecurityManager, doPrivileges, etc... from
`java.logging` and `java.base/jdk.internal.logger`
Only notable hack - Logger.checkPermission() no longer checks permissions, but
has been renamed into `ensureLogManagerInitialized()` in order to avoid
disturbing the initializat
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
The changes to SystemLogger looks OK to me. Maybe you could ge
On Wed, 20 Nov 2024 13:46:49 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in
On Tue, 19 Nov 2024 19:33:18 GMT, kabutz wrote:
> See internal bug review 9077848
>
> This is a very small unimportant mistake in the naming of the documentation
> that does not match the code.
This pull request has now been integrated.
Changeset: da2d7a09
Author:Dr Heinz M. Kabutz
Commi
On Tue, 19 Nov 2024 18:50:36 GMT, Roger Riggs wrote:
> With SM removal, there is a doPrivileged call in Cleaner.java. Should that be
> handled separately from this PR?
Since this is not related to the problem at hand, I'd prefer to keep it out of
this PR.
-
PR Comment: https://gi
On Tue, 19 Nov 2024 22:31:28 GMT, Alexey Semenyuk wrote:
> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
> in the tests. Replace them with stubs.
>
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
Looks good.
-
Marked as reviewe
On Tue, 19 Nov 2024 16:35:44 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/reflect/MethodHandleAccessorFactory.java
>> line 430:
>>
>>> 428: // Single parameter of declared type Object[]
>>> 429: Class[] parameters =
>>> reflectionFactory.getExecutableShare
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
Christian Stein has updated the pull
On Tue, 19 Nov 2024 20:33:35 GMT, Roger Riggs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> clarify factory location usages in NamingManager and jdk.naming.rmi
>> module-info
>
> src/java.naming/share/classes/
On Tue, 19 Nov 2024 20:38:02 GMT, Roger Riggs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> clarify factory location usages in NamingManager and jdk.naming.rmi
>> module-info
>
> src/java.naming/share/classes/
On Tue, 19 Nov 2024 00:53:22 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Marked as reviewed by lancea (Reviewer).
-
PR Revie
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
> This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
> JDK providers, and contains the following changes:
> - The following two properties are removed:
> - `com.sun.jndi.ldap.object.trustURLCodebase`
> - `com.sun.jndi.rmi.object.trustURLCodebase`
> - JNDIs object
Can I please get a review for this change which removes SecurityManager usages
from `jdk.jlink` module? This addresses
https://bugs.openjdk.org/browse/JDK-8344524.
The internal class `jdk.tools.jlink.internal.JlinkPermission` too has been
removed as part of this change.
No new tests have been
On Wed, 20 Nov 2024 08:11:34 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java
>> line 247:
>>
>>> 245: = U.objectFieldOffset(Thread.class, "threadLocals");
>>> 246: private static final long INHERITABLETHREADLOCALS
>>> 247:
On Tue, 19 Nov 2024 19:12:29 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 4082:
>>
>>> 4080: AccessController.doPrivileged(new PrivilegedAction<>() {
>>> 4081: public ForkJoinPool run() {
>>> 4082:
On Tue, 19 Nov 2024 19:33:18 GMT, kabutz wrote:
> See internal bug review 9077848
>
> This is a very small unimportant mistake in the naming of the documentation
> that does not match the code.
Thanks, this comment was missed in the loom repo when we did the last rename.
You'll need to adjust
On Tue, 19 Nov 2024 11:12:01 GMT, Christian Stein wrote:
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.com/openjdk/jdk/commit/5cb0d438231383d491b
On Wed, 20 Nov 2024 06:52:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
On Wed, 20 Nov 2024 06:52:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Wed, 20 Nov 2024 06:52:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
On Tue, 19 Nov 2024 10:32:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to remove
> SecurityManager related API usages from `URLClassLoader` and its related
> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>
> The `URLClassLo
On Wed, 20 Nov 2024 00:50:01 GMT, Brent Christian wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use RandomFactory in test
>
> src/java.base/share/classes/jdk/internal/ref/PhantomCleanable.java line 55:
>
>>
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
On Tue, 19 Nov 2024 18:44:51 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct remainder checking
>
> src/java.base/share/classes/java/math/BigDecimal.java line 2260:
>
>> 2258:
On Tue, 19 Nov 2024 08:09:38 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Wed, 20 Nov 2024 10:36:13 GMT, Viktor Klang wrote:
>> resetThreadLocals looks good although. A discussion point is whether reset
>> should be done for all FJP instances, not just the common pool but not this
>> PR.
>
> Thanks Alan. Yes, I think it should be considered to do it for all FJP
>
On Tue, 19 Nov 2024 16:57:05 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concu
On Sat, 29 Jun 2024 07:31:44 GMT, Alan Bateman wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It was
On Wed, 20 Nov 2024 14:04:54 GMT, jyxzwd wrote:
>> Use the built-in file system provider rather than the custom file system
>> provider.
>> Add "public static FileSystemProvider create" method in
>> DefaultFileSystemProvider which is from java8API to be compatible against
>> runtime.
>
> jyxzw
On Wed, 20 Nov 2024 13:06:57 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Wed, 20 Nov 2024 11:33:19 GMT, Daniel Fuchs wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 262:
>>
>>> 260: }
>>> 261:
>>> 262: worker = new Thread(this);
>>
>> Rataining a static factory for thread may use useful to be able to customize
>> t
On Tue, 19 Nov 2024 20:42:04 GMT, Roger Riggs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> clarify factory location usages in NamingManager and jdk.naming.rmi
>> module-info
>
> src/java.naming/share/classes/
On Wed, 20 Nov 2024 14:02:10 GMT, Amit Kumar wrote:
> Do similar change for:
>
> ```
> src/java.base/share/native/libjava/ub.h
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/JimageDiffGenerator.java
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/ResourcePo
> This PR prevents sequence layout with padding to be used with the Linker.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 36 additional co
On Tue, 19 Nov 2024 14:23:58 GMT, Francesco Nigro wrote:
>> When core reflection was migrated to be implemented by Method Handles,
>> somehow, the method handles are not used for native methods, which are
>> generally linkable by method handles. This causes significant performance
>> regressi
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
Do similar change for:
src/java.base/share/native/libjava/ub.h
src/jdk.jlink/share/classes/jdk/tools/jl
This PR adds missing Classpath exception in several files.
JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
-
Commit messages:
- Added classpath exception for some additional files
- Added missing classpath exception
Changes: https://git.openjdk.org/jdk/pull/2
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Wed, 20 Nov 2024 16:31:44 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change jdk.naming.rmi per Daniel's suggestion
>
> src/jdk.naming.rmi/share/classes/module-info.java line 64:
>
>> 62
On Wed, 20 Nov 2024 16:25:56 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Wed, 20 Nov 2024 16:25:56 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Wed, 20 Nov 2024 16:40:43 GMT, Aleksei Efimov wrote:
>> src/jdk.naming.rmi/share/classes/module-info.java line 64:
>>
>>> 62: * location} specified in the reference can be supported by a custom
>>> implementation of {@link
>>> 63: * javax.naming.spi.ObjectFactoryBuilder}. If a location is
> Use the built-in file system provider rather than the custom file system
> provider.
> Add "public static FileSystemProvider create" method in
> DefaultFileSystemProvider which is from java8API to be compatible against
> runtime.
jyxzwd has updated the pull request incrementally with two addi
On Wed, 20 Nov 2024 14:57:11 GMT, Jatin Bhateja wrote:
>> test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorConvChain.java
>> line 44:
>>
>>> 42: @Test
>>> 43: @IR(applyIfCPUFeatureAnd = {"avx512_fp16", "false", "avx512vl",
>>> "true"}, counts = {IRNode.VECTOR_CAST_HF2F, IRNod
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change.
>
> APIDiff:
> https://cr.openjdk.org/~jlu/8341923_a
On Wed, 20 Nov 2024 14:11:51 GMT, Alan Bateman wrote:
> I don't think we should be doing this. Did you try the direction of checking
> the defining class loader that I outlined in the previous comment?
yeah,I tested it a few mins ago.It works well in the situation mentioned in the
issue and in
On Thu, 13 Jun 2024 14:31:06 GMT, David M. Lloyd wrote:
> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
> support for functionality required to continue to support IIOP and custom
> serializers in light of additional module-based restrictions on reflection.
> It was ex
On Sun, 10 Nov 2024 17:04:12 GMT, Alan Bateman wrote:
>> If we load the custom DefaultFileSystemProvider by SystemClassLoader,then we
>> will step into the method
>> SystemModuleFinders$SystemModuleReader#findImageLocation again, and the var
>> imageReader will be null.But we can not define a
On Wed, 20 Nov 2024 11:38:35 GMT, Daniel Fuchs wrote:
>> src/java.naming/share/classes/com/sun/naming/internal/VersionHelper.java
>> line 163:
>>
>>> 161: InputStream getJavaHomeConfStream(String filename) {
>>> 162: try {
>>> 163: String javahome = System.getProperty("j
> Please review this fix to how patched modules are being handled when linking
> from the run-time image. During review of
> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out
> that module patching should be detected earlier and the link should get
> aborted in that
1 - 100 of 142 matches
Mail list logo
