On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this change. >> >> APIDiff: >> https://cr.openjdk.org/~jlu/8341923_apidiff/java.base/java/util/Locale.html >> Javadoc: https://cr.openjdk.org/~jlu/api/java.base/java/util/Locale.html > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > address Naoto's comments Thanks for the changes. A couple of minor comments src/java.base/share/classes/java/util/Locale.java line 1256: > 1254: > 1255: /** > 1256: * {@return an array of deployed locales} Since "deployed" is the term from ServiceLoader, it might mean only referring to SPI impls, so how about simply "available"? ------------- PR Review: https://git.openjdk.org/jdk/pull/22192#pullrequestreview-2449377299 PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1850787428
