On Tue, 19 Nov 2024 09:21:08 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
> While you are at it, it would be useful to add one test for each of the paths > in the new algorithm (including the exception cases) in the existing > [SquareRootTests](https://github.com/openjdk/jdk/blob/master/test/jdk/java/math/BigDecimal/SquareRootTests.java) > This helps to identify future regressions when the code is later modified > for any reason. I will add the path-based tests once the path tree has reached a stable version, in order to avoid changing tests if the path tree changes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21301#discussion_r1848773886
