On Wed, 20 Nov 2024 04:22:48 GMT, Taizo Kurashige <d...@openjdk.org> wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" >> executed with "chcp 437". This ensures that the English message "No >> Instance(s) Available." is output on localized windows platforms. >> >> I have referred to the following for how to use chcp: >> ・chcp | Microsoft Learn at >> https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp >> ・Code Page Identifiers - Win32 apps | Microsoft Learn at >> https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers >> >> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor >> or jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server >> 2019 (Japanese and English locales). I confirmed that they pass. >> >> Thanks > > Taizo Kurashige has updated the pull request incrementally with one > additional commit since the last revision: > > Fix about size of cmdline Marked as reviewed by asemenyuk (Reviewer). Thank you for working on this patch! ------------- PR Review: https://git.openjdk.org/jdk/pull/22142#pullrequestreview-2449371963 PR Comment: https://git.openjdk.org/jdk/pull/22142#issuecomment-2489257196
