On Mon, 18 Nov 2024 20:37:27 GMT, Chen Liang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address Chen's review; make other similar changes
>
> src/java.base/share/classes/java/util/Locale.java line 94:
>
>> 92:
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Tue, 19 Nov 2024 06:13:04 GMT, David Holmes wrote:
>> src/java.base/share/man/java.md line 3079:
>>
>>> 3077: For example `*.java` stays `*.java` and is not expanded to
>>> `Foo.java`,
>>> 3078: `Bar.java`, etc. like on some command line shell.
>>> 3079:
>>
>> This expansion now se
On Mon, 18 Nov 2024 15:45:22 GMT, Alexey Semenyuk wrote:
> jpackage man page update
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22209#pullrequestreview-2443917267
On Mon, 18 Nov 2024 13:41:49 GMT, Alexey Semenyuk wrote:
> Support using jpackage l10n keys instead of string values when examining
> jpackage error output.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22207#pullrequestrevie
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/2
On 18/11/2024 21:17, Chen Liang wrote:
Hi Eirik,
I think it might have been a legacy oversight; note that even
java.util.Arrays was just recently made final.
> If Runtime was made final it seems we could remove the CheckCSMs test.
I disagree; CheckCSMs test checks for missing CSM annotation
On Sun, 17 Nov 2024 19:01:24 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remov
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
On Mon, 18 Nov 2024 21:06:11 GMT, Sean Mullan wrote:
> Is this worthy of a release note?
There are hundreds of methods changed to no longer do permission checks,
remaining permission checks do nothing anyway. I would think the big release
note for JEP 486 will provide an overall summary of th
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Mon, 18 Nov 2024 15:22:59 GMT, Christian Stein wrote:
> Please review this improvement to the manual page covering the usage of
> wildcards in `java`'s argfiles.
No, that was an oversight. Good catch!
I will remove that sentence (second last bullet point) in favor of the
augmented one (thi
On Tue, 19 Nov 2024 06:12:21 GMT, David Holmes wrote:
>> Please review this improvement to the manual page covering the usage of
>> wildcards in `java`'s argfiles.
>
> src/java.base/share/man/java.md line 3079:
>
>> 3077: For example `*.java` stays `*.java` and is not expanded to
>> `Foo.j
On Mon, 18 Nov 2024 15:22:59 GMT, Christian Stein wrote:
> Please review this improvement to the manual page covering the usage of
> wildcards in `java`'s argfiles.
src/java.base/share/man/java.md line 3079:
> 3077: For example `*.java` stays `*.java` and is not expanded to
> `Foo.java`,
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remove `SecurityManager::checkPermission` calls in the `setLogW
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 15:46:04 GMT, Viktor Klang wrote:
> This change now halves each side of the split regardless, the old code would
> end up in a situation where it wouldn't decrement since unsigned shift right
> twice would lead to decrementing estimated size by 0.
>
> It's worth noting the
Expunge the use of the `SecurityManager`, `AccessController`, and the like from
the `java.io` package.
-
Commit messages:
- 8344077: Remove security manager dependency in java.io
Changes: https://git.openjdk.org/jdk/pull/22219/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&p
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
Preliminary testing: the `jdk_io` tests pass on Linux and Windows.
-
PR Comment: https://git.openjdk.org/jdk/pull/22
On Mon, 18 Nov 2024 20:27:20 GMT, Roger Riggs wrote:
> Yes, please cleanup the leftover mention, in CheckCSMs. of
> ObjectStreamField.getType(). And I'll re-review.
Thanks, see 0278c59. This leaves `UNSUPPORTED_VIRTUAL_METHODS` as an empty set.
Should I remove this field and the code using thi
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
What about `sun.misc.Unsafe`? There are a couple of
`AccessController.doPrivileged` calls.
Hi,
Tried to find an answer to this question in JBS, but found nothing:
Since java.lang.Runtime has a single private constructor, it seems
effectively final. Why is it not declared final?
If Runtime was made final it seems we could remove the CheckCSMs test.
Are there compatibility concerns her
On Mon, 18 Nov 2024 20:35:49 GMT, Sean Mullan wrote:
> What about `sun.misc.Unsafe`? There are a couple of
> `AccessController.doPrivileged` calls.
I'll look at that in a separate PR.
-
PR Comment: https://git.openjdk.org/jdk/pull/22158#issuecomment-2484111717
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
Looks good
src/java.base/share/classes/java/io/FilePermission.java line 184:
> 182: DefaultFileSystemProvider.theFileSys
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
`Console` changes look good to me, with a minor suggestion
src/java.base/share/classes/java/io/Console.java line 687:
> 685:
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
src/java.base/share/classes/java/io/Console.java line 660:
> 658: }
> 659:
> 660: @SuppressWarnings("removal")
This too
On Mon, 18 Nov 2024 15:55:56 GMT, Jan Lahoda wrote:
>> So, just to double-check: given the request is to make the helps consistent,
>> and dropping the extensions from the concise help is not what was meant,
>> I'll add the extensions both here and to the ordinary help. Correct?
>
> Done here:
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Marked as reviewed by mullan (Reviewer).
Is this worthy of a release note?
-
PR Review
Improve documentation for constant pool entries. This include some models for
those entries, symbolic descriptors, and some general guidance in package
summary.
APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
Javadoc: https://cr.openjdk.org/~liach/javadoc/cf-consts/
Please review the
On Mon, 18 Nov 2024 19:30:08 GMT, Roger Riggs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert caller-sensitive inlining of ReflectUtil.forName
>> - SerialJavaObject::getFields is no longer @CallerSensit
On Mon, 18 Nov 2024 21:07:59 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8
On Mon, Nov 18, 2024 at 10:17 PM Chen Liang wrote:
> Hi Eirik,
> I think it might have been a legacy oversight; note that even
> java.util.Arrays was just recently made final.
>
Thanks, filed https://bugs.openjdk.org/browse/JDK-8344460 to track this
enhancement.
> > If Runtime was made final i
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Mon, 18 Nov 2024 12:40:43 GMT, Per Minborg wrote:
> This PR proposes to use a static property already resolved instead of calling
> `System.getProperty()`.
This looks okay, makes it immune to crazy code that changes java.home.
-
Marked as reviewed by alanb (Reviewer).
PR Revie
On Mon, 18 Nov 2024 07:16:32 GMT, Alan Bateman wrote:
> I think Brent and/or Lance have been working on this already.
Happy to yield if Brent/Lance has something cooking. Otherwise, perhaps their
time is better spent as reviewers.
> If you are taking this, can you remove
> src/java.sql.rowset
On Fri, 15 Nov 2024 14:21:21 GMT, fabioromano1 wrote:
>> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
>> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>>
>> The main steps of the algorithm are as follows:
>> first argument reduce the value to an i
On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu wrote:
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change. A
On Mon, 18 Nov 2024 09:42:20 GMT, Alan Bateman wrote:
>> Change default value of the command line option
>> --sun-misc-unsafe-memory-access from "allow" to "warn".
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains si
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Mon, 18 Nov 2024 20:56:59 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 836: Address review comments
>> - 836: Remove security manager dependency from module jdk.sctp
>
> src/jav
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with two additional
commits since the last revision:
- 836: Address review comments
- 836: Remove security manager dep
On Mon, 18 Nov 2024 20:46:24 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 836: Address review comments
>> - 836: Remove security manager dependency from module jdk.sctp
>
> src/ja
On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu wrote:
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change. A
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Mon, 18 Nov 2024 18:05:12 GMT, Aleksei Efimov wrote:
>> src/java.rmi/share/classes/sun/rmi/server/MarshalInputStream.java line 69:
>>
>>> 67:
>>> 68: /** table to hold sun classes to which access is explicitly
>>> permitted */
>>> 69: protected static Map> permittedSunClasses
>>
>>
On Mon, 18 Nov 2024 17:39:44 GMT, Aleksei Efimov wrote:
>> First cut at removal of Security Manager stuff from RMI.
>>
>> This covers just about every SM-related case in RMI, except for a bit of
>> package checking in MarshalInputStream. This will be handled separately.
>> It's covered by [JDK
On Mon, 18 Nov 2024 18:49:57 GMT, Roger Riggs wrote:
>> First cut at removal of Security Manager stuff from RMI.
>>
>> This covers just about every SM-related case in RMI, except for a bit of
>> package checking in MarshalInputStream. This will be handled separately.
>> It's covered by [JDK-83
On Mon, 18 Nov 2024 21:20:02 GMT, Chen Liang wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove ObjectStreamField#getType from UNSUPPORTED_VIRTUAL_METHODS, a
>> leftover from JDK-8344034
>
> test/jdk/jdk/int
On Fri, 15 Nov 2024 23:23:39 GMT, Justin Lu wrote:
> Please review this PR which removes the lone `AccessController.doPrivileged`
> call from the _java.scripting_ module after JEP486 integration.
This pull request has now been integrated.
Changeset: 8d43e0d6
Author:Justin Lu
URL:
h
On Mon, 18 Nov 2024 13:21:25 GMT, Alexey Semenyuk wrote:
> Simple typo fix.
>
> Old view:
> https://github.com/openjdk/jdk/blob/dfddbcaab886b9baa731cd748bb7f547e1903b64/src/jdk.jpackage/share/man/jpackage.md
>
> New view:
> https://github.com/alexeysemenyukoracle/jdk/blob/JDK-8336087/src/jdk.
This PR proposes to use a static property already resolved instead of calling
`System.getProperty()`.
-
Commit messages:
- Use StaticProperty.javaHome()
Changes: https://git.openjdk.org/jdk/pull/22205/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22205&range=00
Issue:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
Support using jpackage l10n keys instead of string values when examining
jpackage error output.
-
Commit messages:
- Comment reworded
- Merge branch 'master' into JDK-8343876.JPackageErrorOutputVerify
- Remove redundant "method.setAccessible(true);" calls
- Fix finding in the rev
Simple typo fix.
Old view:
https://github.com/openjdk/jdk/blob/dfddbcaab886b9baa731cd748bb7f547e1903b64/src/jdk.jpackage/share/man/jpackage.md
New view:
https://github.com/alexeysemenyukoracle/jdk/blob/JDK-8336087/src/jdk.jpackage/share/man/jpackage.md
Navigate to "Group value of the RPM" text
On Mon, 18 Nov 2024 08:26:20 GMT, Matthias Baesken wrote:
>> On AIX we run into errors below, for example in test
>> tools/jlink/runtimeImage/AddOptionsTest.java , this happened with fastdebug
>> binaries, opt worked :
>>
>> jlink options: --output java-base-with-opts-jlink-tmp --add-modules
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not the `java` executable, but it is difficult find out a
On Thu, 30 May 2024 13:00:21 GMT, Magnus Ihse Bursie wrote:
> This patch contains a set of changes to improve static builds. They will pave
> the way for implementing a full static-only java launcher. The changes here
> will:
>
> 1) Make sure non-exported symbols are made local in the static l
This change now halves each side of the split regardless, the old code would
end up in a situation where it wouldn't decrement since unsigned shift right
twice would lead to decrementing estimated size by 0.
It's worth noting the probabilistic nature of skip lists and that their
spliterators ar
On Mon, 18 Nov 2024 13:57:29 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Sun, 17 Nov 2024 14:52:06 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which removes exceptional control flow in
> `Boolean::getBoolean`, `Integer::getInteger` and `Long::getLong`.
>
> These methods are catching `IllegalArgumentException` and
> `NullPointerException`, thrown by `Syste
On Tue, 12 Nov 2024 15:09:23 GMT, Roger Riggs wrote:
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected
On Mon, 18 Nov 2024 15:25:06 GMT, Eirik Bjørsnøs wrote:
> Drive by observation: In java.base, there are four similar instances in
> `ImageReaderFactory.JAVA_HOME`, `SystemImage::findHome`,
> `CDS::dumpSharedArchive` and `DomainName::getPubSuffixStream`.
Good find: Let's fix them under this iss
On Fri, 15 Nov 2024 01:12:34 GMT, Stuart Marks wrote:
> First cut at removal of Security Manager stuff from RMI.
>
> This covers just about every SM-related case in RMI, except for a bit of
> package checking in MarshalInputStream. This will be handled separately. It's
> covered by [JDK-834432
On Mon, 18 Nov 2024 08:37:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 13:41:49 GMT, Alexey Semenyuk wrote:
> Support using jpackage l10n keys instead of string values when examining
> jpackage error output.
@sashamatveev ptal
-
PR Comment: https://git.openjdk.org/jdk/pull/22207#issuecomment-2483240933
On Mon, 18 Nov 2024 08:11:03 GMT, Eirik Bjørsnøs wrote:
> Seems like a clean inline, how does this introduce a behavioural change?
Class.forName's behavior depends on the caller's defining class loader. I don't
know where Brent and/or Lance is on the changes for this module but if you are
taki
On Fri, 15 Nov 2024 22:43:13 GMT, Eirik Bjørsnøs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> src/java.base/share/classes/java/lang/System.java line 1336:
>
>> 1334: }
>> 1335:
>> 1336: private
jpackage man page update
-
Commit messages:
- Better wording
- 8342299: Document that jpackage includes (possibly old) VC Redistributable
MSVCP140.dll from JDK
Changes: https://git.openjdk.org/jdk/pull/22209/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22209&range=00
On Fri, 15 Nov 2024 19:26:15 GMT, Naoto Sato wrote:
> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
> after JEP486 integration.
This pull request has now been integrated.
Changeset: c59adf68
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/c59a
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Review suggestions applied:
Remove SecurityExceptions from LiveStac
On Fri, 15 Nov 2024 17:03:50 GMT, Aleksei Efimov wrote:
> This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
> JDK providers, and contains the following changes:
> - The following two properties are removed:
> - `com.sun.jndi.ldap.object.trustURLCodebase`
> - `
On Mon, 18 Nov 2024 14:11:43 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize sqrt branch for exact results
>
> src/java.base/share/classes/java/math/BigDecimal.java line 2248:
>
On Mon, 18 Nov 2024 08:37:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 12:40:43 GMT, Per Minborg wrote:
> This PR proposes to use a static property already resolved instead of calling
> `System.getProperty()`.
The CSR for this change has been approved. I plan to integrate this tomorrow
pending a final tier2 run.
-
PR Comment: htt
On Mon, 18 Nov 2024 08:23:20 GMT, Alan Bateman wrote:
> Class.forName's behavior depends on the caller's defining class loader. I
> don't know where Brent and/or Lance is on the changes for this module but if
> you are taking it then I would prefer if the changes to
> XmlReaderContentHandler w
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remove `SecurityManager::checkPermission` calls in the `setLogW
On Mon, 18 Nov 2024 15:50:49 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
CSR created, please review:
[JDK-8344423](https://bugs.openjdk.org/browse/JDK-8344423)
On Mon, 18 Nov 2024 12:40:43 GMT, Per Minborg wrote:
> This PR proposes to use a static property already resolved instead of calling
> `System.getProperty()`.
This pull request has now been integrated.
Changeset: 20783295
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/2
On Fri, 15 Nov 2024 01:12:34 GMT, Stuart Marks wrote:
> First cut at removal of Security Manager stuff from RMI.
>
> This covers just about every SM-related case in RMI, except for a bit of
> package checking in MarshalInputStream. This will be handled separately. It's
> covered by [JDK-834432
On Mon, 18 Nov 2024 17:55:31 GMT, Aleksei Efimov wrote:
>> First cut at removal of Security Manager stuff from RMI.
>>
>> This covers just about every SM-related case in RMI, except for a bit of
>> package checking in MarshalInputStream. This will be handled separately.
>> It's covered by [JDK
Please review this improvement to the manual page covering the usage of
wildcards in `java`'s argfiles.
-
Commit messages:
- 8293040: Argfile documentation for java launcher tool is confusing regarding
usage of wildcards
Changes: https://git.openjdk.org/jdk/pull/22208/files
Webr
On Mon, 18 Nov 2024 15:30:15 GMT, Roger Riggs wrote:
> Circumventing and duplicating the checks in System.getProperty isn't good
> coding technique and is not necessary for performance improvement or code
> size.
My understanding of JDK-8178966 is that the motivation was correctness rather
th
On Mon, 18 Nov 2024 00:16:00 GMT, Chen Liang wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> src/java.base/share/classes/java/lang/String.java line 691:
>
>> 689: System.getSecurityManager() !=
First cut at removal of Security Manager stuff from RMI.
This covers just about every SM-related case in RMI, except for a bit of
package checking in MarshalInputStream. This will be handled separately. It's
covered by [JDK-8344329](https://bugs.openjdk.org/browse/JDK-8344329).
Further simplifi
On Fri, 15 Nov 2024 01:12:34 GMT, Stuart Marks wrote:
> First cut at removal of Security Manager stuff from RMI.
>
> This covers just about every SM-related case in RMI, except for a bit of
> package checking in MarshalInputStream. This will be handled separately. It's
> covered by [JDK-834432
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Fri, 15 Nov 2024 20:17:59 GMT, Naoto Sato wrote:
>> Removing a `AccessController.doPrivileged()` call from jdk.charsets module
>> after JEP486 integration.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed import
Tha
We would like to propose an implementation of the HKDF algorithms for
SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
Derivation Function API
(Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
This implementation will be under the _Preview_ umbrella until the K
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Sat, 26 Oct 2024 14:06:37 GMT, Naman Nigam wrote:
> As the documentation of getCeilingEntry currently reads, the inference is
> misleading as follows:
>
> if no such entry exists, returns the entry for the least key greater than the
> specified key;
> if no such entry exists (i.e., the grea
Move child classes of "jdk.jpackage.test.Functional" class to
"jdk.jpackage.internal.util.function" package.
Split "jdk.jpackage.internal.IOUtils" class in "PathUtils", "FileUtils",
"XmlUtils" classes in "jdk.jpackage.internal.util" package.
Implmenetation didnt change except of `FileUtils.delet
On Mon, 18 Nov 2024 18:31:09 GMT, Alexey Semenyuk wrote:
> Move child classes of "jdk.jpackage.test.Functional" class to
> "jdk.jpackage.internal.util.function" package.
> Split "jdk.jpackage.internal.IOUtils" class in "PathUtils", "FileUtils",
> "XmlUtils" classes in "jdk.jpackage.internal.uti
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remove `SecurityManager::checkPermission` calls in the `setLogW
On Mon, 18 Nov 2024 19:47:25 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
Hi Eirik,
I think it might have been a legacy oversight; note that even java.util.Arrays
was just recently made final.
> If Runtime was made final it seems we could remove the CheckCSMs test.
I disagree; CheckCSMs test checks for missing CSM annotations when new caller
sensitive methods are add
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
1 - 100 of 151 matches
Mail list logo
