On Mon, 18 Nov 2024 19:30:08 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert caller-sensitive inlining of ReflectUtil.forName >> - SerialJavaObject::getFields is no longer @CallerSensitive, remove it from >> CheckCSM test > > Looks fine. Hey @RogerRiggs, I needed to merge with master to resolve a conflict after the integration of your PR #22041. Would you mind taking another look at the merge commit 3f1df59 and re-review this PR? While looking at your change in #22041, I noticed you removed `ObjectStreamField#getType` from `CheckCSM.KNOWN_NON_FINAL_CSMS`, but that it remains in `CheckCSM.UNSUPPORTED_VIRTUAL_METHODS`. CheckCSM runs fine with this method removed from `UNSUPPORTED_VIRTUAL_METHODS` which leads me to think it may have been a leftover? If it was, I'm happy to remove it while I'm visiting this code anyhow, or you could clean it up via some other PR. Thanks :-) ------------- PR Comment: https://git.openjdk.org/jdk/pull/22185#issuecomment-2484005783
