On Mon, 18 Nov 2024 17:55:31 GMT, Aleksei Efimov <aefi...@openjdk.org> wrote:
>> First cut at removal of Security Manager stuff from RMI. >> >> This covers just about every SM-related case in RMI, except for a bit of >> package checking in MarshalInputStream. This will be handled separately. >> It's covered by [JDK-8344329](https://bugs.openjdk.org/browse/JDK-8344329). >> >> Further simplifications could be done in RuntimeUtil and NewThreadAction. >> However, those changes started to become somewhat more intrusive than I'd >> like for this PR, which is focused on removing security-related stuff. > > src/java.rmi/share/classes/sun/rmi/server/MarshalInputStream.java line 69: > >> 67: >> 68: /** table to hold sun classes to which access is explicitly >> permitted */ >> 69: protected static Map<String, Class<?>> permittedSunClasses > > It looks like `permittedSunClasses` map can be removed alongside to > `checkSunClass(String, AccessControlException)` method, since it is only > called on [line > 198](https://github.com/openjdk/jdk/pull/22129/files#diff-491ee160d740152081c000fc513091e00181c41fd3c423c466fd30448a2a47e6R198): > > } catch (@SuppressWarnings("removal") AccessControlException e) { > return checkSunClass(className, e); Sorry, missed your comment in a PR description - ignore the comment above ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22129#discussion_r1847038115
