> Please review this PR which cleans up SecurityManager-related code in > `java.sql` and `java.sql.rowset` modules post JEP-486 > > There are quite a few changes to review, but all relatively straightforward: > > `DriverManager` > * Remove `SecurityManager::checkPermission` calls in the `setLogWriter`, > `setLogStream` and `deregisterDriver` methods > * Remove two now-unused package private SQLPermission constants > * `ensureDriversInitialized` is updated to remove > `AccessController::doPrivileged` when reading a system property and when > initializing drivers > > `CachedRowSetImpl` > * Remove `AccessController::doPrivileged` when getting a `SyncFactory` > instance > * `getObject` is update to remove a call to `ReflectUtil::checkPackageAccess` > > `CachedRowSetWriter` > * A call to `ReflectUtil::checkPackageAccess` is removed. > > `SerialJavaObject` > * `getFields` is updated to remove call to > `ReflectUtil::checkPackageAccess`. `@CallerSensitive` is no longer needed for > this method. > * The test `CheckCSMs.java` is updated to remove references to > `SerialJavaObject:getFields` > > `SyncFactory` > * `initMapIfNecessary` is updated to remove call to > `AccessController::doPrivileged` when reading system properties and when > reading properties from an input stream > * `getInstance` is updated to remove calls to > `ReflectUtil::checkPackageAccess` > * `setLogger` method is updated to remove call to > `SecurityManager::checkPermission` > * `setJNDIContext` methods are updated to remove call to > `SecurityManager::checkPermission` > > `RowsetProvider` > * Static initializer is updated to call `System::getProperty` directly > * `newFactory` is updated to call `System::getProperty` directly > * `newFactory` is updated to not call `ReflectUtil.checkPackageAccess` > * `getContextClassLoader` is updated to not call > `AccessController::doPrivileged` > * `getFactoryClass` is updated to not call `ReflectUtil.checkPackageAccess` > * `getSystemProperty` is removed > > > `SQLInputImpl` > * A call to `ReflectUtil::checkPackageAccess` is removed > > `TestPolicy.java` in `test/java/sql/testng/util` > * This is now unused and removed > > Ran `test/jdk/java/sql` and `test/jdk/javax/sql` tests locally. GHA results > pending.
Eirik Bjørsnøs has updated the pull request incrementally with two additional commits since the last revision: - Revert caller-sensitive inlining of ReflectUtil.forName - SerialJavaObject::getFields is no longer @CallerSensitive, remove it from CheckCSM test ------------- Changes: - all: https://git.openjdk.org/jdk/pull/22185/files - new: https://git.openjdk.org/jdk/pull/22185/files/d45c5ec0..d539a31a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=22185&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22185&range=00-01 Stats: 7 lines in 2 files changed: 0 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/22185.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22185/head:pull/22185 PR: https://git.openjdk.org/jdk/pull/22185
