On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 07:52:08 GMT, Adam Sotona wrote:
> Is there a way to pre-compile a test library and point related tests (or
> maybe all hotspot tests) to the library jar?
My initial thought was just to add the jar to the classpath, but maybe it is
better to use an explicit `@library` tag.
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Fri, 10 Jan 2025 15:39:20 GMT, Adam Sotona wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed jdk.internal package prefix from asm
>
> Thanks for the reviews. I'll update the copyright years and run again ti
On Fri, 10 Jan 2025 16:12:54 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Fri, 10 Jan 2025 15:39:20 GMT, Adam Sotona wrote:
> Jtreg seems to have no problems to use ASM as a declared library.
Whan you say "no problems", I guess you are referring to the pass rate of the
tests. But how does it affect the runtime spent doing testing?
I must insist that "just moving"
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Wed, 8 Jan 2025 07:21:36 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Wed, 8 Jan 2025 22:14:21 GMT, David Holmes wrote:
> Moving the ASM library requires modifying every single test that uses it.
Right, as without it there will be warnings due to jtreg launching tests to
export packages that aren't in java.base. There may also be a few tests that
use launch c
On Wed, 8 Jan 2025 06:52:10 GMT, Adam Sotona wrote:
> BTW: purpose of this PR is to seamlessly remove ASM from java.base and it is
> slightly turning into a massive synchronous refactoring of several hundreds
> of hotspot tests.
Moving the ASM library requires modifying every single test that
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
so you if add asm
On Wed, 8 Jan 2025 01:14:00 GMT, David Holmes wrote:
> It is not appropriate for anything outside the platform modules to claim to
> be part of `jdk.internal`. In fact I'm surprised we are even allowed to add
> to that from outside the module!
There's nothing to prohibit this, it's just surpri
On Wed, 8 Jan 2025 06:57:04 GMT, Alan Bateman wrote:
>
> you can revert the changes that we have in the jdk repo so it goes back to
> .org.objectweb.asm
that represents a refactoring with >1200 changes in >250 files across multiple
repositories
-
PR Comment: https://git.openjdk.
On Tue, 7 Jan 2025 22:19:22 GMT, Adam Sotona wrote:
> Despite the 265 modified files is this PR trying to be minimalistic.
> Repackaging of the library would be far more complex and would affect
> significantly more files, including the library itself. I would recommend to
> invest that effort
On Wed, 8 Jan 2025 01:45:48 GMT, Leonid Mesnik wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> I th
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
I think it is mak
On Tue, 7 Jan 2025 20:19:53 GMT, Alan Bateman wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Movin
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Test libraries be
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
I've decided to m
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Moving it to test
There are no more consumers of ASM library except for hotspot tests.
This patch moves ASM library from java.base module to the hotspot test
libraries location and fixes the tests.
Please review.
Thanks,
Adam
-
Commit messages:
- fixed TestMHUnloaded
- patching hotspot tests
- re
39 matches
Mail list logo
