On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed jdk.internal package prefix from asm
test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/shared/Util.java line 135:
> 133: */
> 134: public static void printClassFile(byte[] classFile) {
> 135: int flags = org.objectweb.asm.ClassReader.SKIP_DEBUG;
Nit. Pre-existing, buy may be worth to fix
Suggestion:
int flags = org.objectweb.asm.ClassReader.SKIP_DEBUG;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22946#discussion_r1909386706
