On Fri, 10 Jan 2025 16:12:54 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > updated copyright years Like @magicus I am also having some doubts about the ability of jtreg to manage this. In particular the test/hotspot/jtreg/runtime/SelectionResolution/ tests. The testcases in these tests do not use ASM themselves, ASM is used by the selectionresolution/classes library that is also used by the tests. I'm not even clear how the library directives are making this work. There is also the overhead as Magnus raised as we know jtreg does not handle compilation dependencies the way we would expect. That said I'm okay with looking at using an ASM binary jar as a follow-up to this, provided we do not get a lot of failures triggered by this change. To that end I would want to see full tiers 1-8 testing carried out before this gets integrated. Using an ASM jar could either be a downstream dependency as Magnus suggested, or we could pre-build into the test-image as part of Leonid's work in that area. ------------- PR Review: https://git.openjdk.org/jdk/pull/22946#pullrequestreview-2545705480
