On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> There are no more consumers of ASM library except for hotspot tests. > This patch moves ASM library from java.base module to the hotspot test > libraries location and fixes the tests. > > Please review. > > Thanks, > Adam Moving it to test/hotspot/jtreg is initially surprising, I assumed it would move to test/lib. Did you choose the hotspot tree as only tests in hotspot/jtreg use it and you didn't want to add or change the @library tag on these tests? The other thing is the package name, maybe it should move back to org.objectweb.asm as it won't be a JDK internal package. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22946#issuecomment-2576150512