Re: RFR: 8343040: Clean up references to JRE in the launcher code [v3]

2024-10-30 Thread Jaikiran Pai
On Wed, 30 Oct 2024 07:22:42 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v3]

2024-10-30 Thread Jaikiran Pai
On Wed, 30 Oct 2024 07:22:42 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v3]

2024-10-30 Thread Alan Bateman
On Wed, 30 Oct 2024 07:22:42 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v2]

2024-10-30 Thread Jaikiran Pai
On Wed, 30 Oct 2024 01:52:43 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v3]

2024-10-30 Thread Jaikiran Pai
> Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tier2 and > tier3 continue to pass in our CI against Linux

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v2]

2024-10-30 Thread Alan Bateman
On Wed, 30 Oct 2024 01:49:48 GMT, Jaikiran Pai wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's review - fix code comment about Microsoft C Runtime Library > > src/java.base/windows/native/libjli/java_md.c li

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v2]

2024-10-30 Thread Alan Bateman
On Wed, 30 Oct 2024 01:52:43 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v2]

2024-10-29 Thread Jaikiran Pai
On Tue, 29 Oct 2024 17:40:35 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's review - fix code comment about Microsoft C Runtime Library > > src/java.base/windows/native/libjli/java_md.c li

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v2]

2024-10-29 Thread Jaikiran Pai
On Wed, 30 Oct 2024 01:49:48 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier

Re: RFR: 8343040: Clean up references to JRE in the launcher code [v2]

2024-10-29 Thread Jaikiran Pai
> Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tier2 and > tier3 continue to pass in our CI against Linux

Re: RFR: 8343040: Clean up references to JRE in the launcher code

2024-10-29 Thread Alan Bateman
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tie

Re: RFR: 8343040: Clean up references to JRE in the launcher code

2024-10-25 Thread Joe Darcy
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tie

Re: RFR: 8343040: Clean up references to JRE in the launcher code

2024-10-25 Thread Jaikiran Pai
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tie

Re: RFR: 8343040: Clean up references to JRE in the launcher code

2024-10-24 Thread Jaikiran Pai
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tie

RFR: 8343040: Clean up references to JRE in the launcher code

2024-10-24 Thread Jaikiran Pai
Can I please get a review of this change which cleans up references to "JRE" from the launcher's code? No functional changes have been introduced in this change. No new tests have been introduced and existing tests in tier1, tier2 and tier3 continue to pass in our CI against Linux, macosx and W