On Tue, 29 Oct 2024 17:40:35 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Alan's review - fix code comment about Microsoft C Runtime Library > > src/java.base/windows/native/libjli/java_md.c line 227: > >> 225: /* >> 226: * The Microsoft C Runtime Library needs to be loaded first. A >> copy is >> 227: * assumed to be present in the JDK installation root directory. > > This comment isn't quite right, the C runtime library is in bin directory, > not the root directory. Hello Alan, I've now updated these 2 places where the code comments were explaining this library loading. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21704#discussion_r1821743648