On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tier2 and > tier3 continue to pass in our CI against Linux, macosx and Windows. src/java.base/windows/native/libjli/java_md.c line 227: > 225: /* > 226: * The Microsoft C Runtime Library needs to be loaded first. A > copy is > 227: * assumed to be present in the JDK installation root directory. This comment isn't quite right, the C runtime library is in bin directory, not the root directory. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21704#discussion_r1821290939
