On Wed, 30 Oct 2024 01:52:43 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which cleans up references to "JRE" >> from the launcher's code? >> >> No functional changes have been introduced in this change. >> >> No new tests have been introduced and existing tests in tier1, tier2 and >> tier3 continue to pass in our CI against Linux, macosx and Windows. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > Alan's review - fix code comment about Microsoft C Runtime Library Sorry Alan, I was just going over this change one final time and noticed a typo in error macro usage which was introduced by this change. I have now fixed it in a new commit. Requesting a re-review/approval for the updated PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21704#issuecomment-2446050949