On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this change which cleans up references to "JRE" > from the launcher's code? > > No functional changes have been introduced in this change. > > No new tests have been introduced and existing tests in tier1, tier2 and > tier3 continue to pass in our CI against Linux, macosx and Windows. src/java.base/share/native/libjli/emessages.h line 74: > 72: #define CLS_ERROR4 "Error: Main method not public\n" GEN_ERROR > 73: #define CLS_ERROR5 "Error: main-class: attribute exceeds system > limits of %d bytes\n" GEN_ERROR > 74: The macros which have been removed in this PR are unusued ones. I decided to clean them up since they weren't too many and I was anyway updating this current file in context of the current change. src/java.base/share/native/libjli/emessages.h line 87: > 85: #define LAUNCHER_ERROR3 "Error: Path length exceeds maximum length > (PATH_MAX)" > 86: #define LAUNCHER_ERROR4 "Error: trying to exec %s.\nCheck if file exists > and permissions are set correctly." > 87: #define LAUNCHER_ERROR5 "Error: String processing operation failed" While renaming these `JRE_ERROR` macros, I've renumbered them, since some of these `JRE_ERROR<N>` were unused. Relevant usages within the code of these macros have been updated accordingly to make sure they continue to emit the correct message. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21704#discussion_r1816099321 PR Review Comment: https://git.openjdk.org/jdk/pull/21704#discussion_r1816101967
