On Thu, 20 Mar 2025 12:38:37 GMT, Magnus Ihse Bursie wrote:
> Is there any gain then in changing away from -lpthread? That is clearly
> defined, link with libpthread, with no side effects. "If it ain't broke..."
True - what we have works and using `-pthread` might subtly change things.
---
On Thu, 3 Apr 2025 21:03:08 GMT, Stuart Marks wrote:
> Back out commit for
> [JDK-8349206](https://bugs.openjdk.org/browse/JDK-8349206) because of build
> failure.
>
> This reverts commit ebcb9a8b128cc6411610566c8368db63d25a5127.
LGTM Thanks Stuart!
-
Marked as reviewed by dholm
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote:
> In the JDK launcher, there is a codepath which would set/modify the
> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
> contains a li
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote:
> there was already a pragma but due to incorrect restrictions it did not apply
> to clang.
How does the `__GNUC__` check affect clang?? Isn't that just for gcc?
-
PR Comment: https://git.openjdk.org/jdk/pull/24357#issueco
Hi,
This change was already proposed (by myself):
https://bugs.openjdk.org/browse/JDK-8289253
but it cannot be done as it will break source compatibility.
We will just have to live with this historical oddity.
Cheers,
David
On 31/03/2025 12:46 pm, tison wrote:
On Mon, 31 Mar 2025 02:08:02 G
On Wed, 26 Mar 2025 19:28:24 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
On Tue, 25 Mar 2025 15:25:56 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
On Mon, 24 Mar 2025 20:22:55 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
On Tue, 18 Mar 2025 18:57:04 GMT, Jiangli Zhou wrote:
> Please review this PR that adds `@requires !jdk.static` to tests, thanks.
>
> - runtime/StackGap/TestStackGap.java
> - runtime/StackGuardPages/TestStackGuardPages.java
> - runtime/TLS/TestTLS.java
> - runtime/jni/daemonDestroy/TestDaemonDes
On Sat, 22 Mar 2025 03:46:38 GMT, Jiangli Zhou wrote:
> Please review following changes, thanks.
>
> - Add `static` to the vm_info for static JDK. The `-version` output now
> contains `static` on static JDK, e.g.:
>
>
> $ static-jdk/bin/java -version
> openjdk version "25-internal" 2025-09-16
On Thu, 20 Mar 2025 09:52:02 GMT, Aleksey Shipilev wrote:
> See the bug for rationale.
>
> This goal for this improvement is to be easily backportable, so we can catch
> up with update releases. As such, it does a few borderline-trivial changes,
> and _does not_ change the jspawnhelper protoc
On Tue, 18 Mar 2025 18:57:04 GMT, Jiangli Zhou wrote:
> Please review this PR that adds `@requires !jdk.static` to tests, thanks.
>
> - runtime/StackGap/TestStackGap.java
> - runtime/StackGuardPages/TestStackGuardPages.java
> - runtime/TLS/TestTLS.java
> - runtime/jni/daemonDestroy/TestDaemonDes
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote:
>>> What is the intended way of using this? Do you run make with
>>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the
>>> specific way of linking to pthread?
>>
>> This is in prep
On Fri, 14 Mar 2025 17:58:50 GMT, Magnus Ihse Bursie wrote:
>> This change copies `libjvm.so` _and_ sibling `.jsa` files, right?
>>
>> If so, then one thing is missing: regenerating CDS archives that have
>> opinions on `modules` filesizes/dates for fingerprinting their CDS archives.
>> My fra
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
On Sun, 2 Mar 2025 21:17:04 GMT, Sergey Chernyshev
wrote:
>> OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as
>> well.
>
>> OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as
>> well.
>
> Thanks for your review @jerboaa ! I cheched the
> te
On Thu, 6 Mar 2025 15:47:58 GMT, Magnus Ihse Bursie wrote:
>> What is the intended way of using this? Do you run make with
>> `LIBPTHREAD=-pthread` or do you apply a patch on `libraries.m4` for the
>> specific way of linking to pthread?
>
>> What is the intended way of using this? Do you run ma
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
On Fri, 28 Feb 2025 07:22:24 GMT, Alan Bateman wrote:
> In this case it's a JDK-specific module
Okay but is there a transitive dependency from the public module that has to be
present to the internal module?
That said ... we are building a minimal VM we are not building Compact
Profiles. I do
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
On Wed, 19 Feb 2025 20:30:34 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
ssibleObject/TrySetAccessibleTest.java
>
>Co-authored-by: David Holmes
> <62092539+dholmes-...@users.noreply.github.com>
> - Update
> test/jdk/java/lang/reflect/AccessibleObject/TrySetAccessibleTest.java
>
>Co-authored-by: David Holmes
> <62092539
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Mon, 10 Feb 2025 04:00:44 GMT, Jiangli Zhou wrote:
>> This is similar to https://github.com/openjdk/jdk/pull/23431 change. It
>> removes libjvm.so as a recorded dependency for libExplicitAttach.so by not
>> explicitly link libExplicitAttach.so with libjvm.so at build time. To do
>> that, it
On Thu, 6 Feb 2025 12:12:59 GMT, Coleen Phillimore wrote:
>> I am still missing what can actually set a PD here, sorry. ??
>
> Because the field is final, it has to be initialized in the constructor in
> Java code. My initial patch for modifiers chose to initialize to zero but
> that's not qui
On Wed, 5 Feb 2025 17:41:22 GMT, Coleen Phillimore wrote:
>> src/java.base/share/classes/java/lang/Class.java line 239:
>>
>>> 237: * generated.
>>> 238: */
>>> 239: private Class(ClassLoader loader, Class arrayComponentType,
>>> ProtectionDomain pd) {
>>
>> If this constructor i
On Wed, 5 Feb 2025 16:14:41 GMT, Viktor Klang wrote:
> This change is likely going to need some extra verbiage in the spec for
> mapConcurrent, and thus a CSR.
> This behavior aligns mapConcurrent with how parallel streams work in
> conjunction with interruptions of the caller thread.
src/java
On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote:
> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>
> JDK-8348190: Framework for tracing makefile inclusion and parsing
>
> The above issue caused problems in the Oracle closed builds and so needs to
> be bac
On Thu, 6 Feb 2025 02:48:21 GMT, Mikael Vidstedt wrote:
>> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>>
>> JDK-8348190: Framework for tracing makefile inclusion and parsing
>>
>> The above issue caused problems in the Oracle closed builds and so needs to
>> be backed out un
On Thu, 6 Feb 2025 02:01:47 GMT, Joe Darcy wrote:
>> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>>
>> JDK-8348190: Framework for tracing makefile inclusion and parsing
>>
>> The above issue caused problems in the Oracle closed builds and so needs to
>> be backed out until th
This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
JDK-8348190: Framework for tracing makefile inclusion and parsing
The above issue caused problems in the Oracle closed builds and so needs to be
backed out until that is addressed.
Thanks.
-
Commit messages:
- Revert "
On Mon, 3 Feb 2025 16:11:06 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incr
On Fri, 31 Jan 2025 22:18:32 GMT, Tom Rodriguez wrote:
>> Deoptimization with escape analysis can fail when trying to rematerialize
>> objects as described in JDK-8227309. In this test this can happen in Xcomp
>> mode in the framework of the test resulting in a test failure. Making the
>> nu
On Thu, 16 Jan 2025 18:37:36 GMT, Tom Rodriguez wrote:
>> Deoptimization with escape analysis can fail when trying to rematerialize
>> objects as described in JDK-8227309. In this test this can happen in Xcomp
>> mode in the framework of the test resulting in a test failure. Making the
>> nu
On Fri, 17 Jan 2025 18:50:22 GMT, Leonid Mesnik wrote:
>> Some VM flags might depend on the environment and it makes sense to log
>> final flags so it is possible to get their value when investigating failures.
>>
>> I added them to VMProps, so it is always dump final flags before running
>> t
On Fri, 17 Jan 2025 18:50:22 GMT, Leonid Mesnik wrote:
>> Some VM flags might depend on the environment and it makes sense to log
>> final flags so it is possible to get their value when investigating failures.
>>
>> I added them to VMProps, so it is always dump final flags before running
>> t
On Thu, 16 Jan 2025 17:53:48 GMT, Leonid Mesnik wrote:
>> test/lib/jdk/test/lib/hprof/parser/ReadBuffer.java line 46:
>>
>>> 44: public int getInt(long pos) throws IOException;
>>> 45: public long getLong(long pos) throws IOException;
>>> 46: public void close() throws IOExceptio
On Thu, 16 Jan 2025 18:18:15 GMT, Leonid Mesnik wrote:
>> There few compiler warning disabled in the testlibary build.
>> They should be fixed or localized and removed from build to prevent new
>> possible issues.
>>
>> The main goal is to avoid new such issues in the testlibrary.
>> Tested wi
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Wed, 15 Jan 2025 23:48:33 GMT, Leonid Mesnik wrote:
> There few compiler warning disabled in the testlibary build.
> They should be fixed or localized and removed from build to prevent new
> possible issues.
>
> The main goal is to avoid new such issues in the testlibrary.
> Tested with tie
On Tue, 14 Jan 2025 22:15:07 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Minor cl
On Wed, 15 Jan 2025 05:14:51 GMT, Henry Jen wrote:
> jimage use the same code to parse command line options, the resource bundle
> for jimage also need update.
LGTM. Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23123#pullrequestre
On Wed, 15 Jan 2025 04:57:03 GMT, Chen Liang wrote:
>> The new API specification for class file attributes link to non-SE modules
>> of jdk.compiler and jdk.jlink, which caused docs build failure for SE docs.
>> This patch removes those links and replace them with plain module name
>> referenc
On Wed, 15 Jan 2025 04:27:14 GMT, Chen Liang wrote:
> The new API specification for class file attributes link to non-SE modules of
> jdk.compiler and jdk.jlink, which caused docs build failure for SE docs. This
> patch removes those links and replace them with plain module name references.
Ch
On Mon, 13 Jan 2025 11:07:11 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Mon, 13 Jan 2025 11:07:11 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
Seems reasonable.
Thanks for fixing.
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23088#pullrequestreview-2548790485
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Thu, 9 Jan 2025 10:18:35 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
On Fri, 10 Jan 2025 16:12:54 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote:
> Test
> runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
> uses
> -Xbootclasspath/a: classpath
> (2 arguments)
>
> Such usage of options -Xbootclasspath/a: should be correctly processed by
> virtual thread factory suppor
On Wed, 8 Jan 2025 14:56:55 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
On Wed, 8 Jan 2025 15:23:23 GMT, Chen Liang wrote:
> Joe and David, can you look at this updated versioning that uses the core
> libraries since scheme?
Yep that looks fine. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/22934#issuecomment-2579111421
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström
wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these
On Wed, 8 Jan 2025 11:00:14 GMT, Joakim Nordström
wrote:
>> The test is skipped for SIGUSR2 on Linux and MacOS, and Windows skips all
>> signal testing. So I guess that leaves aix, which seems to use
>> signals_poxis.cpp... so perhaps the SIGUSR2 test should be skipped for aix
>> too?
>> But
On Wed, 8 Jan 2025 06:52:10 GMT, Adam Sotona wrote:
> BTW: purpose of this PR is to seamlessly remove ASM from java.base and it is
> slightly turning into a massive synchronous refactoring of several hundreds
> of hotspot tests.
Moving the ASM library requires modifying every single test that
On Tue, 7 Jan 2025 20:19:53 GMT, Alan Bateman wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Movin
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Test libraries be
On Mon, 6 Jan 2025 21:20:58 GMT, Chen Liang wrote:
>> `javax.lang.model.SourceVersion` has a series of comments describing the new
>> language features present in each source version. Similar comments for the
>> `ClassFileFormatVersion` would be helpful, so readers no longer need to
>> search
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Wed, 18 Dec 2024 09:12:55 GMT, Joakim Nordström
wrote:
> Could I get a review of this fix to refine the warnings printed by `libjsig`
> when using the deprecated `signal()`/`sigset()` functions?
>
> Currently the libjsig library supports chaining `signal()` and `sigset()`.
> With these fun
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Okay on addressing the error han
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Changes requested by dholmes (Re
On Mon, 16 Dec 2024 12:17:17 GMT, Alan Bateman wrote:
>> A jdk.VirtualPinnedEvent JFR event is recorded by Object::wait when a
>> virtual thread waits in Object.wait while pinned. The posting of the event
>> in ObjectMonitor::wait is done after waiting but it can block again in
>> enter/Reente
On Sat, 14 Dec 2024 16:27:19 GMT, Alan Bateman wrote:
>> A jdk.VirtualPinnedEvent JFR event is recorded by Object::wait when a
>> virtual thread waits in Object.wait while pinned. The posting of the event
>> in ObjectMonitor::wait is done after waiting but it can block again in
>> enter/Reente
On Mon, 9 Dec 2024 21:02:03 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On 9/12/2024 1:21 pm, David Alayachew wrote:
> If it's one
of the expected ones, things will proceed normally.
There are expected segfaults in libjvm?
Sorry, I am 100% ignorant about this subject. I just wanted to know if
that was the intended meaning.
Yes there is a deliberate segfault dur
On Wed, 4 Dec 2024 10:04:17 GMT, Christian Stein wrote:
>> Please review this follow-up PR to improve `java`'s manpage section about
>> wildcards in argument files: the confusing sentence is now removed.
>>
>> This is a cleanup of commit
>> https://github.com/openjdk/jdk/commit/5cb0d438231383d
On Wed, 4 Dec 2024 05:59:31 GMT, David Holmes wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set java.vm.vendor from VersionProps.java
>
> src/hotspot/share/runtime/abstract_vm_v
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Tue, 3 Dec 2024 10:43:20 GMT, Christian Stein wrote:
>> Please review this follow-up PR to improve `java`'s manpage section about
>> wildcards in argument files: the confusing sentence is now removed.
>>
>> This is a cleanup of commit
>> https://github.com/openjdk/jdk/commit/5cb0d438231383d
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Mon, 2 Dec 2024 18:53:12 GMT, Henry Jen wrote:
>> src/hotspot/share/runtime/threads.cpp line 654:
>>
>>> 652: initialize_java_lang_classes(main_thread, CHECK_JNI_ERR);
>>> 653: // Update the java.vm.vendor property with
>>> java.lang.VersionProps.VM_VENDOR
>>> 654: Arguments::update_vm
On Fri, 29 Nov 2024 11:12:22 GMT, Alan Bateman wrote:
>> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
>> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
>> that support virtual threads doing blocking network I/O operations.
>>
>> This is a subset of t
On Thu, 28 Nov 2024 15:54:54 GMT, Alan Bateman wrote:
>> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
>> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
>> that support virtual threads doing blocking network I/O operations.
>>
>> This is a subset of t
On Thu, 28 Nov 2024 09:48:25 GMT, Severin Gehwolf wrote:
>> This PR adds missing Classpath exception in several files.
>>
>> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
>
> src/java.base/share/native/libjava/ub.h
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ru
On Thu, 28 Nov 2024 02:21:55 GMT, David Holmes wrote:
>> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783)
>> was integrated, the handling of certain symbol lookup code can be
>> simplified. The old code needed to support 32-bit Windows, where names
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a
On Thu, 28 Nov 2024 01:54:10 GMT, Kim Barrett wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/NativeLibraries.c
>>
>> Co-author
d"}
> #define AGENT_ONUNLOAD_SYMBOLS {"Agent_OnUnload"}
> #define AGENT_ONATTACH_SYMBOLS {"Agent_OnAttach"}
>
> are all singletons and so the actual strings can just be inlined directly
> into the code that uses them.
>
> Testing:
> - GHA
> - Tiers 1-4
d"}
> #define AGENT_ONUNLOAD_SYMBOLS {"Agent_OnUnload"}
> #define AGENT_ONATTACH_SYMBOLS {"Agent_OnAttach"}
>
> are all singletons and so the actual strings can just be inlined directly
> into the code that uses them.
>
> Testing:
> - GHA
> - Tiers 1-
On Wed, 27 Nov 2024 01:43:34 GMT, Alex Menkov wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/NativeLibraries.c
>>
>> Co-author
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a
After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
integrated, the handling of certain symbol lookup code can be simplified. The
old code needed to support 32-bit Windows, where names had a trailing
`@`. When this special case now is removed, some streamlining is
poss
On Tue, 26 Nov 2024 03:38:25 GMT, Calvin Cheung wrote:
>> Currently, when retrieving a ClassFileStream during runtime, we call into
>> the zip library to retrieve the stream based only on a class name. This
>> doesn't work well if the class is in a multi-release jar under a versioned
>> direct
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
On Tue, 26 Nov 2024 01:38:55 GMT, David Holmes wrote:
>> c.f:
>> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420)
>>
>> Summary
>> ---
>>
>> Add `jcmd Thread.vthread_summary` to print summary information
On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote:
> c.f:
> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420)
>
> Summary
> ---
>
> Add `jcmd Thread.vthread_summary` to print summary information that is
> useful when trying to diagnose issues wi
On Mon, 25 Nov 2024 19:30:12 GMT, Calvin Cheung wrote:
>> Currently, when retrieving a ClassFileStream during runtime, we call into
>> the zip library to retrieve the stream based only on a class name. This
>> doesn't work well if the class is in a multi-release jar under a versioned
>> direct
On Mon, 25 Nov 2024 19:26:40 GMT, Calvin Cheung wrote:
>> src/hotspot/share/cds/filemap.cpp line 2718:
>>
>>> 2716: // The result should be a [B
>>> 2717: assert(obj->is_typeArray(), "just checking");
>>> 2718: assert(TypeArrayKlass::cast(obj->klass())->element_type() ==
>>> T_BYTE, "just
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
On Fri, 22 Nov 2024 17:25:54 GMT, Calvin Cheung wrote:
>> Currently, when retrieving a ClassFileStream during runtime, we call into
>> the zip library to retrieve the stream based only on a class name. This
>> doesn't work well if the class is in a multi-release jar under a versioned
>> direct
1 - 100 of 904 matches
Mail list logo
