On Wed, 8 Jan 2025 14:56:55 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Please review this trivial test-only patch in support of running tests on >> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run >> `jlink` in-process of the test JVM which includes module patches (as in - >> uses `--patch-module`) which is not supported for JEP 493 enabled JDKs. The >> proposed fix is to run those two tests in `/othervm` so as to no longer see >> the module patch of the test JDK. >> >> Testing: >> - [ ] GHA >> - [x] Affected tests which fail prior the patch and pass after with a JEP >> 493 enabled JDK. Also tested on a JDK that includes `jmods` folder. >> >> Thoughts? > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Copyright and @comment Pardon my ignorance, but in neither of these tests is it evident to me that "patched modules" are being used. Where does that arise? ------------- PR Review: https://git.openjdk.org/jdk/pull/22969#pullrequestreview-2538683215
